dasharo/edk2-upstream
0
0
Fork 0
mirror of https://github.com/Dasharo/edk2-upstream.git synced 2026-03-06 15:03:57 -08:00
Code Issues Packages Projects Releases Wiki Activity

OvmfPkg/XenBusDxe: fix UninstallMultipleProtocolInterfaces() call

Browse Source 
Unlike the InstallMultipleProtocolInterfaces() boot service, which takes
an (EFI_HANDLE*) as first parameter, the
UninstallMultipleProtocolInterfaces() boot service takes an EFI_HANDLE as
first parameter.

This is an actual bug. It must have remained hidden until now because it's
on an error path. Fix the UninstallMultipleProtocolInterfaces() call.

Cc: Anthony Perard <anthony.perard@citrix.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Julien Grall <julien.grall@arm.com>
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>
Reviewed-by: Julien Grall <julien.grall@arm.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
This commit is contained in:
Laszlo Ersek
2019-09-07 00:50:42 +02:00
parent 30af652ee1
commit 2ef0c27cb8
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
OvmfPkg/XenBusDxe/XenBus.c
View File

@@ -210,7 +210,7 @@ XenBusAddDevice (
ErrorOpenProtocolByChild:
gBS->UninstallMultipleProtocolInterfaces (
&Private->Handle,
Private->Handle,
&gEfiDevicePathProtocolGuid, Private->DevicePath,
&gXenBusProtocolGuid, &Private->XenBusIo,
NULL);