Commit Graph

1384 Commits

Author SHA1 Message Date
Ard Biesheuvel
abd92d65cf Platform/Socionext/DeveloperBoxMm: increase FV size
Due to recent changes in core EDK2, the DeveloperBoxMM standalone MM
build no longer fits when built in DEBUG or NOOPT mode. So increase
the FD size a little bit - we still have some spare room available in
the FIP image.

Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
2020-11-27 12:53:29 +00:00
Leif Lindholm
85b777b69f Platform/SocioNext: add VariablePolicy resolutions
Add resolutions for
- VariablePolicyLib
- VariablePolicyHelperLib
- VariablePolicyLib (DXE_RUNTIME_DRIVER)
to DeveloperBox/DeveloperBoxMm platforms.

Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Signed-off-by: Leif Lindholm <leif@nuviainc.com>
Acked-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
2020-11-27 11:53:23 +00:00
Leif Lindholm
a6c44c7bc5 Platform/BeagleBoard: add VariablePolicy resolutions
Add resolutions for
- SafeIntLib
- VariablePolicyLib
- VariablePolicyHelperLib
- VariablePolicyLib (DXE_RUNTIME_DRIVER)

Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Signed-off-by: Leif Lindholm <leif@nuviainc.com>
Acked-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
2020-11-27 11:53:23 +00:00
Leif Lindholm
c9e62f2910 Platform/SiFive: add VariablePolicy resolutions
Add resolutions for
- SafeIntLib
- VariablePolicyLib
- VariablePolicyHelperLib
- VariablePolicyLib (DXE_RUNTIME_DRIVER)

for u500/u540 platforms.

Cc: Abner Chang <abner.chang@hpe.com>
Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
Signed-off-by: Leif Lindholm <leif@nuviainc.com>
Reviewed-by: Abner Chang <abner.chang@hpe.com>
2020-11-27 11:53:23 +00:00
Leif Lindholm
9abe91cbe0 Platform/LeMaker: add VariablePolicy resolutions for cello
Add resolutions for
- SafeIntLib
- VariablePolicyLib
- VariablePolicyHelperLib
- VariablePolicyLib (DXE_RUNTIME_DRIVER)

Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Signed-off-by: Leif Lindholm <leif@nuviainc.com>
Acked-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
2020-11-27 11:53:23 +00:00
Leif Lindholm
4bf172cee3 Platform/SoftIron: add VariablePolicy resolutions for Overdrive1000
Add resolutions for
- SafeIntLib
- VariablePolicyLib
- VariablePolicyHelperLib
- VariablePolicyLib (DXE_RUNTIME_DRIVER)

Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Signed-off-by: Leif Lindholm <leif@nuviainc.com>
Acked-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
2020-11-27 11:53:23 +00:00
Leif Lindholm
cdc997a3f1 Platform/AMD: add VariablePolicy library resolutions for Overdrive
Add resolutions for
- VariablePolicyLib
- VariablePolicyHelperLib
- VariablePolicyLib (DXE_RUNTIME_DRIVER)

Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Signed-off-by: Leif Lindholm <leif@nuviainc.com>
Acked-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
2020-11-27 11:53:23 +00:00
Leif Lindholm
33c7e8b1eb Platform/ARM: VExpressPkg fixes to work with new VariablePolicyLib
Update .dsc.inc by adding mappings for:
- SafeIntLib
- VariablePolicyLib
- VariablePolicyHelperLib
- VariablePolicyLib (runtime)

Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Thomas Abraham <thomas.abraham@arm.com>
Signed-off-by: Leif Lindholm <leif@nuviainc.com>
Acked-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
2020-11-27 11:53:23 +00:00
Leif Lindholm
4a297d1ea7 Platform,Silicon: fix beagleboard tautological compares
Fix two instances of masking a single bit and testing another.

Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Signed-off-by: Leif Lindholm <leif@nuviainc.com>
Acked-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
2020-11-26 16:20:24 +00:00
Leif Lindholm
6072e08490 Platform/AMD: add RngLib for Overdriveboard
OpenSSL now requires an RngLib. Since we have EFI_RNG_PROTOCOL,
add MdePkg/Library/DxeRngLib/DxeRngLib.inf to fix Overdrive build.

Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Signed-off-by: Leif Lindholm <leif@nuviainc.com>
Acked-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
2020-11-26 16:20:22 +00:00
Samer El-Haj-Mahmoud
734fed7db6 Platforms/RaspberryPi: RPi4 PMU interrupts are SPI not PPI
REF: https://github.com/pftf/RPi4/issues/103

Commit 602a7ea1ab changed the RPi4 PMU interrupts reported
in GICC to the PPI values recommended by SBSA specification.
This caused the PMU overflow interrupts to stop working.

The RPi documentation (Figure 7, page 111) state that the
PMU interrupts are SPI not PPI: https://www.raspberrypi.org/
documentation/hardware/raspberrypi/bcm2711/rpi_DATA_2711_1p0.pdf

Also, the BSA 1.0 spec (page 24) clarifies hat the PPI values are
recommendations, not requirements:
https://developer.arm.com/documentation/den0094/latest

Fix by reverting to the old SPI values per the RPi spec.

Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Pete Batard <pete@akeo.ie>
Cc: Andrei Warkentin <awarkentin@vmware.com>
Signed-off-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
2020-11-25 16:17:27 +01:00
Graeme Gregory
ff052d38e5 Platform/Qemu: add VariablePolicyLib
Build breakage after b6490426e320
Based on commit 879f483ce4

Add the VariablePolicyLib to the dsc to fix the build.

Signed-off-by: Graeme Gregory <graeme@nuviainc.com>
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
2020-11-25 14:32:00 +00:00
Liu, Zhiguang
d3cba2c7ea Platform\Intel\MinPlatformPkg: Add Variable Policy library
Makes the changes because of the new added library instances: VariablePolicyLib
and VariablePolicyHelperLib

Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
Reviewed-by: Eric Dong <eric.dong@intel.com>
2020-11-25 16:17:07 +08:00
Andrei Warkentin
663c3108f7 Platform/RaspberryPi: get RPi4 and RPi3 building again.
Add VariablePolicyLib and its dependency.

Testing: Pi 4 boot.

Signed-off-by: Andrei Warkentin <andrey.warkentin@gmail.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
2020-11-20 16:08:06 +01:00
Joey Gouly
879f483ce4 Platform/ARM: Add VariablePolicy and SafeInt
Fixes the build breakage introduced by b6490426e320:
MdeModulePkg: Connect VariablePolicy business logic to VariableServices

Signed-off-by: Joey Gouly <joey.gouly@arm.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
2020-11-20 16:05:46 +01:00
Pierre Gondois
adcb0c92ca Platform/ARM/Juno: Increase FD size
Dynamic Tables Framework has been updated to include
support for SSDT Serial Port generator. The SSDT Serial
port generator uses AmlLib library to parse, iterate
and update AML nodes.

The addition of these libraries to the Dynamic Tables
Framework have increased the size requirement of the
Firmware Device (FD) Image.

The current FD size is not sufficient due to which the
Juno firmware builds are failing. This patch adds one
additional block to accommodate the increase in FD size.

Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
2020-11-19 12:58:25 +01:00
Pierre Gondois
cba022f7ca Platform/ARM/VExpressPkg: Merge ASL and CfgMngr directories
Due to the following patch available in edk2:
  0a4aa20e8d446c2f5dd54f3a0a7ec4d52f0ebdb6
  BaseTools: Compile AML bytecode arrays into .obj file
a C array containing the AML bytecode is generated from
ASL files, and a .obj file containing this array is
generated.

The Configuration Manager is currently providing an extra
flag to the ASL compiler to generate a C array containing
AML bytecode. This C array is contained in a .hex file.
This .hex file is included where necessary.

This mechanism was necessary due to the impossibility
to describe dependencies between ASL files and C files.
This mechanism is not required anymore. Thus the ASL and
CfgMngr directories can me merged in one module.

This patch merge the two directories for the FVP.

Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
2020-11-19 12:58:22 +01:00
Pierre Gondois
d9c4a98aa0 Platform/ARM/Juno: Merge ASL and CfgMngr directories
Due to the following patch available in edk2:
  0a4aa20e8d446c2f5dd54f3a0a7ec4d52f0ebdb6
  BaseTools: Compile AML bytecode arrays into .obj file
a C array containing the AML bytecode is generated from
ASL files, and a .obj file containing this array is
generated.

The Configuration Manager is currently providing an extra
flag to the ASL compiler to generate a C array containing
AML bytecode. This C array is contained in a .hex file.
This .hex file is included where necessary.

This mechanism was necessary due to the impossibility
to describe dependencies between ASL files and C files.
This mechanism is not required anymore. Thus the ASL and
CfgMngr directories can me merged in one module.

This patch merge the two directories for the Juno.

Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
2020-11-19 12:58:14 +01:00
Vijayenthiran Subramaniam
867efd012b SgiPkg/RdN1EdgeX2: Add missing reference to PcdChipCount
Commit e8fe2026dd (“Platform/ARM/SgiPkg: Use chip count constant on
rdn1edgex2 platformâ€) used the PcdChipCount constant but did not declare
its use in the ACPI table module. Fix this by listing it in the list of
PCDs to be looked up.

Signed-off-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
Reviewed-by: Thomas Abraham <thomas.abraham@arm.com>
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
2020-11-12 10:11:52 +01:00
Michael Kubacki
1a9cbd7fe9 Vlv2TbltDevicePkg/FmpDeviceLib: Add LastAttemptStatus compatibility
Makes the changes necessary for these library instances of
FmpDeviceLib to be compatible with new functions added recently
to FmpDeviceLib.

Two new functions were introduced in FmpDeviceLib to allow a
library instance to return a Last Attempt Status code during
check image and set image operations:
  1. FmpDeviceCheckImageWithStatus ( )
  2. FmpDeviceSetImageWithStatus ( )

FmpDxe (in FmpDevicePkg) will begin calling these new functions
instead of the previous functions. Therefore, this change:
  1. Adds these functions to Vlv2TbltDevicePkg implementations
  2. Moves the main functionality to these new functions
  3. Updates the old functions to call the new functions
     (for backward compatibility)

Note: As of this commit, the Vlv2TbltDevicePkg build is broken
due to:
  1. A required RngLib library instance not defined by the platform
  2. Other FMP libraries not being defined by the platform
     (e.g. FmpDependencyLib, FmpDependencyCheckLib, etc.)

Those changes were fixed locally to test the changes in this commit
but maintainers should make the proper changes for those issues.

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Yi Qian <yi.qian@intel.com>
Cc: Zailiang Sun <zailiang.sun@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
Tested-by: Michael D Kinney <Michael.d.kinney@intel.com>
2020-11-10 18:50:47 -08:00
Michael D Kinney
b0de06c7d8 Vlv2TbltDevicePkg: Add missing RngLib mapping
Cc: Zailiang Sun <zailiang.sun@intel.com>
Cc: Yi Qian <yi.qian@intel.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
Reviewed-by: Zailiang Sun <zailiang.sun@intel.com>
2020-11-04 09:32:11 -08:00
Michael D Kinney
2fcfe47630 Vlv2TbltDevicePkg: Add missing FMP dependency libs
https://bugzilla.tianocore.org/show_bug.cgi?id=2983

Cc: Zailiang Sun <zailiang.sun@intel.com>
Cc: Yi Qian <yi.qian@intel.com>
Cc: Kilian Kegel <kilian_kegel@outlook.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
Reviewed-by: Zailiang Sun <zailiang.sun@intel.com>
2020-11-04 09:32:11 -08:00
Michael D Kinney
391ef3d7bd Vlv2TbltDevicePkg: Use safe string and PCD functions
Update all modules to use safe string functions from BaseLib
and PcdLib to address build failures.

Cc: Zailiang Sun <zailiang.sun@intel.com>
Cc: Yi Qian <yi.qian@intel.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
Reviewed-by: Zailiang Sun <zailiang.sun@intel.com>
2020-11-04 09:32:11 -08:00
Samer El-Haj-Mahmoud
38c387d2da Platforms/RaspberryPi: Fix incorrect display resolution
Fix https://github.com/pftf/RPi4/issues/100 by swapping RPi DisplayDxe
resolution settings for 640x480 and 800x600, which were incorrectly
mapped to the settings shown in the Setup configuration variable.

Signed-off-by: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
Reviewed-by: Pete Batard <pete@akeo.ie>
Reviewed-by: Andrei Warkentin <awarkentin@vmware.com>
2020-11-04 18:22:39 +01:00
Heng Luo
27ba1e1ab4 BoardModulePkg: Early connect PCI Root Bridge in BoardBdsHookLib
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3016

Trigger PCI Bus scanning at BdsBeforeConsoleAfterTrustedConsoleCallback().
Move the call to EnumUsbKeyboard() to after PciEnumComplete.

Cc: Eric Dong <eric.dong@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Signed-off-by: Heng Luo <heng.luo@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
2020-11-02 16:00:17 +08:00