CrystalLee
341d41ac40
Features/Intel/OutOfBandManagement/AsfFeaturePkg: Add initial package
...
Add a new feature package for Alert standard format support.
Alert Standard format specification(DSP0136)
REF:https://www.dmtf.org/sites/default/files/standards/documents/DSP0136.pdf
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com >
Cc: Isaac Oram <isaac.w.oram@intel.com >
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com >
Cc: Liming Gao <gaoliming@byosoft.com.cn >
Signed-off-by: CrystalLee <CrystalLee@ami.com >
Reviewed-by: Isaac Oram <isaac.w.oram@intel.com >
2022-09-07 15:37:34 -07:00
Isaac Oram
63f9e0d918
Features/Intel: Reduce duplicate code
...
Enable simpler initialation of the MinPlatformPkg feature
selection PCD. Most features and boards don't benefit from
initializing these.
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com >
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com >
Cc: Liming Gao <gaoliming@byosoft.com.cn >
Signed-off-by: Isaac Oram <isaac.w.oram@intel.com >
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com >
2022-08-31 18:42:40 -07:00
Isaac Oram
24316d1e48
IpmiFeaturePkg/GenericIpmi: Fix GCC compilation warnings
...
Fix compiler warnings for unused variables.
Fix PeimIpmiInterfaceInit to return initialization status instead of
EFI_SUCCESS.
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com >
Cc: Liming Gao <gaoliming@byosoft.com.cn >
Signed-off-by: Isaac Oram <isaac.w.oram@intel.com >
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com >
2022-07-20 15:22:53 -07:00
Oram, Isaac W
2082072cc8
SpcrFeaturePkg: Use MinPlatform build include files
...
Also added feature enable flag
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com >
Cc: Liming Gao <gaoliming@byosoft.com.cn >
Signed-off-by: Isaac Oram <isaac.w.oram@intel.com >
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com >
Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com >
2022-01-19 11:01:56 -08:00
Oram, Isaac W
af5a7863ff
IpmiFeaturePkg: Fix all relative package paths
...
Packages should be at the root of a PACKAGES_PATH entry.
At some point, paths were relative to edk2-platforms/Features/Intel
which was functional, but interferes with the proper functioning
of packaging tools.
Cc: Liming Gao <gaoliming@byosoft.com.cn >
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com >
Signed-off-by: Isaac Oram <isaac.w.oram@intel.com >
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com >
2022-01-18 15:44:57 -08:00
Oram, Isaac W
025d67dccc
IpmiFeaturePkg: Fix build errors
...
Fix build issues with standalone build.
Switch to using MinPlatformPkg common core include for common modules.
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com >
Cc: Liming Gao <gaoliming@byosoft.com.cn >
Signed-off-by: Isaac Oram <isaac.w.oram@intel.com >
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com >
2022-01-18 15:24:27 -08:00
Ming Tan
e9149e2c1b
SpcrFeaturePkg: Modify PCI device interrupt setting.
...
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3708
The original code will cause FWTS V21.08.00 testing failed.
spcr: SPCR PC-AT compatible IRQ 0xff is invalid
spcr: SPCR PCI flags compatibility bit 0 is 0, expecting 1 for PCI device
Now modify the SpcrAcpi for following:
1. Disable the support of PC-AT compatible IRQ support.
Now only support IO-APIC interrupt type.
2. Set irq to 0.
3. Set the GSI to the value read from PCI device cfg space 0x3C.
4. Set PCI Flags to 1.
Cc: Isaac Oram <isaac.w.oram@intel.com >
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com >
Cc: Liming Gao <gaoliming@byosoft.com.cn >
Signed-off-by: Ming Tan <ming.tan@intel.com >
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com >
Reviewed-by: Abdul Lateef Attar <abdattar@amd.com >
2021-12-01 16:52:19 -08:00
Abdul Lateef Attar
f53964786a
SpcrFeaturePkg: Close the event after first callback.
...
Adds CloseEvent in callback routine OutOfBandACPITableConstruction(),
to avoid multiple installation of SPCR table.
Cc: Isaac Oram <isaac.w.oram@intel.com >
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com >
Cc: Liming Gao <gaoliming@byosoft.com.cn >
Signed-off-by: Abdul Lateef Attar <AbdulLateef.Attar@amd.com >
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com >
2021-10-11 15:00:28 -07:00
Nate DeSimone
d6794cce9f
IpmiFeaturePkg: Fix standalone package build
...
Building the IpmiFeaturePkg standalone
(not as part of a platform build) currently
fails because the IpmiPlatformHookLib was added
but the reference to the NULL implementation of
that LibraryClass was miseed.
Cc: Isaac Oram <isaac.w.oram@intel.com >
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com >
Cc: Liming Gao <gaoliming@byosoft.com.cn >
Cc: Manickavasakam Karpagavinayagam <manickavasakamk@ami.com >
Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com >
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com >
2021-08-05 13:19:32 -07:00
Manickavasakam Karpagavinayagam
2333ea4b85
IpmiFeaturePkg: IPMI Transport PPI and Protocol for BIOS/BMC communication
...
Enable IPMI Transport PPI and Protocol for BIOS/BMC communication
Add PlatformIpmiIoRangeSet() to enable OEM specific southbridge SIO KCS I/O address range
Cc: Isaac Oram <isaac.w.oram@intel.com >
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com >
Cc: Felix Polyudov <Felixp@ami.com >
Cc: Harikrishna Doppalapudi <harikrishnad@ami.com >
Cc: Manish Jha <manishj@ami.com >
Cc: Zachary Bobroff <zacharyb@ami.com >
Signed-off-by: Manickavasakam Karpagavinayagam <manickavasakamk@ami.com >
Reviewed-by: Isaac Oram <isaac.w.oram@intel.com >
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com >
2021-08-04 20:35:09 -07:00
Chasel Chiu
d549e39ca1
Features/Intel/IpmiFeaturePkg: Use MdePkg macros instead of redefining.
...
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3494
Renamed below macros and structure to use MdePkg ones.
IPMI_MSG_GET_BMC_EXEC_RSP
IPMI_GET_BMC_EXECUTION_CONTEXT
IPMI_BMC_IN_FORCED_UPDATE_MODE
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com >
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com >
Cc: Liming Gao <gaoliming@byosoft.com.cn >
Cc: Isaac Oram <isaac.w.oram@intel.com >
Signed-off-by: Chasel Chiu <chasel.chiu@intel.com >
Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com >
2021-07-21 09:45:10 +08:00
Chasel Chiu
107af998af
IpmiFeaturePkg: Fail to build this package.
...
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3484
Fixed the build failure of this package.
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com >
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com >
Cc: Liming Gao <gaoliming@byosoft.com.cn >
Cc: Isaac Oram <isaac.w.oram@intel.com >
Signed-off-by: Chasel Chiu <chasel.chiu@intel.com >
Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com >
2021-07-09 14:34:51 +08:00
Isaac Oram
3a82792302
IpmiFeaturePkg: Add IPMI driver build files
...
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3242
* Adds DEC/DSC build files for the generic IPMI
transport driver.
* Updates Readme.md
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com >
Cc: Liming Gao <gaoliming@byosoft.com.cn >
Cc: Michael Kubacki <michael.kubacki@microsoft.com >
Signed-off-by: Isaac Oram <isaac.w.oram@intel.com >
Co-authored-by: Nate DeSimone <nathaniel.l.desimone@intel.com >
Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com >
Acked-by: Michael Kubacki <michael.kubacki@microsoft.com >
2021-04-05 11:41:41 -07:00
Isaac Oram
655bbd3910
IpmiFeaturePkg: Add GenericIpmi SMM Driver
...
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3242
Adds the SMM version of the generic
IPMI transport driver.
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com >
Cc: Liming Gao <gaoliming@byosoft.com.cn >
Cc: Michael Kubacki <michael.kubacki@microsoft.com >
Signed-off-by: Isaac Oram <isaac.w.oram@intel.com >
Co-authored-by: Nate DeSimone <nathaniel.l.desimone@intel.com >
Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com >
Acked-by: Michael Kubacki <michael.kubacki@microsoft.com >
2021-04-05 11:38:10 -07:00
Isaac Oram
67efd81a6b
IpmiFeaturePkg: Add GenericIpmi DXE Driver
...
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3242
Adds the DXE version of the generic
IPMI transport driver.
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com >
Cc: Liming Gao <gaoliming@byosoft.com.cn >
Cc: Michael Kubacki <michael.kubacki@microsoft.com >
Signed-off-by: Isaac Oram <isaac.w.oram@intel.com >
Co-authored-by: Nate DeSimone <nathaniel.l.desimone@intel.com >
Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com >
Acked-by: Michael Kubacki <michael.kubacki@microsoft.com >
2021-04-05 11:38:06 -07:00
Isaac Oram
156631a5cf
IpmiFeaturePkg: Add GenericIpmi PEIM
...
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3242
Adds the PEI version of the generic
IPMI transport driver.
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com >
Cc: Liming Gao <gaoliming@byosoft.com.cn >
Cc: Michael Kubacki <michael.kubacki@microsoft.com >
Signed-off-by: Isaac Oram <isaac.w.oram@intel.com >
Co-authored-by: Nate DeSimone <nathaniel.l.desimone@intel.com >
Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com >
Acked-by: Michael Kubacki <michael.kubacki@microsoft.com >
2021-04-05 11:37:59 -07:00
Isaac Oram
cd3b71ec14
IpmiFeaturePkg: Add GenericIpmi driver common code
...
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3242
Adds phase independent code for the generic IPMI
transport driver.
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com >
Cc: Liming Gao <gaoliming@byosoft.com.cn >
Cc: Michael Kubacki <michael.kubacki@microsoft.com >
Signed-off-by: Isaac Oram <isaac.w.oram@intel.com >
Co-authored-by: Nate DeSimone <nathaniel.l.desimone@intel.com >
Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com >
Acked-by: Michael Kubacki <michael.kubacki@microsoft.com >
2021-04-05 11:37:54 -07:00
Isaac Oram
a4d7d1bfab
IpmiFeaturePkg: Add IpmiInit driver DEPEXs
...
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3242
Adds IPMI Transport Protocol/PPI to the
IpmiInit PEIM and DXE driver's DEPEXs
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com >
Cc: Liming Gao <gaoliming@byosoft.com.cn >
Cc: Michael Kubacki <michael.kubacki@microsoft.com >
Signed-off-by: Isaac Oram <isaac.w.oram@intel.com >
Co-authored-by: Nate DeSimone <nathaniel.l.desimone@intel.com >
Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com >
Acked-by: Michael Kubacki <michael.kubacki@microsoft.com >
2021-04-05 11:37:49 -07:00
Isaac Oram
6f92062a62
IpmiFeaturePkg: Add IpmiBaseLib and IpmiCommandLib
...
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3242
Adds IpmiBaseLib and adds new commands to IpmiCommandLib
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com >
Cc: Liming Gao <gaoliming@byosoft.com.cn >
Cc: Michael Kubacki <michael.kubacki@microsoft.com >
Signed-off-by: Isaac Oram <isaac.w.oram@intel.com >
Co-authored-by: Nate DeSimone <nathaniel.l.desimone@intel.com >
Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com >
Acked-by: Michael Kubacki <michael.kubacki@microsoft.com >
2021-04-05 11:37:43 -07:00
Isaac Oram
0f14235b55
IpmiFeaturePkg: Add IPMI driver Include headers
...
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3242
Adds header files for the IPMI transport drivers.
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com >
Cc: Liming Gao <gaoliming@byosoft.com.cn >
Cc: Michael Kubacki <michael.kubacki@microsoft.com >
Signed-off-by: Isaac Oram <isaac.w.oram@intel.com >
Co-authored-by: Nate DeSimone <nathaniel.l.desimone@intel.com >
Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com >
Acked-by: Michael Kubacki <michael.kubacki@microsoft.com >
2021-04-05 11:37:20 -07:00
Dandan Bi
6abbe473f5
Features/OutOfBandManagement: Consume MdeLibs.dsc.inc for RegisterFilterLib
...
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
MdeLibs.dsc.inc was added for some basic/default library
instances provided by MdePkg and RegisterFilterLibNull Library
was also added into it as the first version of MdeLibs.dsc.inc.
So update platform dsc to consume MdeLibs.dsc.inc for
RegisterFilterLibNull which will be consumed by IoLib and BaseLib.
Cc: Liming Gao <gaoliming@byosoft.com.cn >
Signed-off-by: Dandan Bi <dandan.bi@intel.com >
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com >
2021-03-31 14:20:11 +08:00
Tan, Ming
41110569ba
Add Features/Intel/OutOfBandManagement/SpcrFeaturePkg.
...
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2710
It is used to support the Serial Port Console Redirection Table (SPCR).
Signed-off-by: Ming Tan <ming.tan@intel.com >
Reviewed-by: Eric Dong <eric.dong@intel.com >
2020-05-18 15:27:12 +08:00
Michael Kubacki
9cc828d9d4
Features/Intel: Add a Performance Impact section to Readme.md files
...
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2417
Performance impact is an important consideration for feature
integration. This new section captures the general expectation
for overall boot performance impact due to using an advanced
feature.
Cc: Dandan Bi <dandan.bi@intel.com >
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com >
Cc: Chasel Chiu <chasel.chiu@intel.com >
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com >
Cc: Eric Dong <eric.dong@intel.com >
Cc: Liming Gao <liming.gao@intel.com >
Signed-off-by: Michael Kubacki <michael.a.kubacki@intel.com >
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com >
Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com >
2020-01-31 15:25:13 -08:00
Michael Kubacki
ad1425fbc2
Features/Intel/IpmiFeaturePkg: Add modules
...
This change adds the modules for the IPMI feature to
IpmiFeaturePkg.
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com >
Cc: Liming Gao <liming.gao@intel.com >
Signed-off-by: Michael Kubacki <michael.a.kubacki@intel.com >
Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com >
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com >
2019-12-06 17:37:56 -08:00
Michael Kubacki
99805a4fa8
Features/Intel/IpmiFeaturePkg: Add libraries
...
This change adds the libraries required for the IPMI feature to
IpmiFeaturePkg.
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com >
Cc: Liming Gao <liming.gao@intel.com >
Signed-off-by: Michael Kubacki <michael.a.kubacki@intel.com >
Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com >
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com >
2019-12-06 17:37:56 -08:00