From 9e89ad4b9e4158904255adc8564d6e5bb78edb62 Mon Sep 17 00:00:00 2001 From: "Agyeman, Prince" Date: Wed, 11 Sep 2019 09:40:09 -0700 Subject: [PATCH] SimicsOpenBoardPkg: Fix GCC build issues REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2162 Removed unused functions in SecMain.c and BdsPlatform.c. Cc: David Wei Cc: Liming Gao Cc: Ankit Sinha Cc: Agyeman Prince Cc: Kubacki Michael A Cc: Nate DeSimone Signed-off-by: Prince Agyeman Reviewed-by: Nate DeSimone Reviewed-by: Michael Kubacki --- .../PlatformBootManagerLib/BdsPlatform.c | 38 ------------------- .../SimicsOpenBoardPkg/SecCore/SecMain.c | 23 ----------- 2 files changed, 61 deletions(-) diff --git a/Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootManagerLib/BdsPlatform.c b/Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootManagerLib/BdsPlatform.c index 117c72b3..953a4a6c 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootManagerLib/BdsPlatform.c +++ b/Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootManagerLib/BdsPlatform.c @@ -316,12 +316,6 @@ ConnectRootBridge ( IN VOID *Context ); -STATIC -VOID -SaveS3BootScript ( - VOID - ); - // // BDS Platform Functions // @@ -1296,38 +1290,6 @@ PlatformBdsConnectSequence ( PciAcpiInitialization (); } -/** - Save the S3 boot script. - - Note that DxeSmmReadyToLock must be signaled after this function returns; - otherwise the script wouldn't be saved actually. -**/ -STATIC -VOID -SaveS3BootScript ( - VOID - ) -{ - EFI_STATUS Status; - EFI_S3_SAVE_STATE_PROTOCOL *BootScript; - STATIC CONST UINT8 Info[] = { 0xDE, 0xAD, 0xBE, 0xEF }; - - Status = gBS->LocateProtocol (&gEfiS3SaveStateProtocolGuid, NULL, - (VOID **) &BootScript); - ASSERT_EFI_ERROR (Status); - - // - // Despite the opcode documentation in the PI spec, the protocol - // implementation embeds a deep copy of the info in the boot script, rather - // than storing just a pointer to runtime or NVS storage. - // - Status = BootScript->Write(BootScript, EFI_BOOT_SCRIPT_INFORMATION_OPCODE, - (UINT32) sizeof Info, - (EFI_PHYSICAL_ADDRESS)(UINTN) &Info); - ASSERT_EFI_ERROR (Status); -} - - /** Do the platform specific action after the console is ready diff --git a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c b/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c index 5cbb4768..4514641b 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c +++ b/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c @@ -495,29 +495,6 @@ FindPeiCoreImageBaseInFv ( return EFI_SUCCESS; } - -/** - Reads 8-bits of CMOS data. - - Reads the 8-bits of CMOS data at the location specified by Index. - The 8-bit read value is returned. - - @param Index The CMOS location to read. - - @return The value read. - -**/ -STATIC -UINT8 -CmosRead8 ( - IN UINTN Index - ) -{ - IoWrite8 (0x70, (UINT8) Index); - return IoRead8 (0x71); -} - - STATIC BOOLEAN IsS3Resume (