"test -v" checks whether a variable has been declared, it does not check
its value. We sometimes use "unset" for some variables, and then check
again with "test -v". The problem is, "unset" erases variable value, but
the variable still exists, so the "test -v" will be true before, as well
as after the "unset".
We must use "test -n" (whether a variable holds non-zero length
string value) and "test -z" (whether a variable holds zero length string
value) to check string values of variables. This way the "unset" will
work.
Signed-off-by: Daniil Klimuk <daniil.klimuk@3mdeb.com>
CMD_DASHARO_DEPLOY is already defined in /usr/sbin/dts-environment.sh
which is included at the beginning of the dasharo-hcl-report script.
Signed-off-by: Daniil Klimuk <daniil.klimuk@3mdeb.com>
We have detected that the ME and IGB regions are not backed up
on MTL laptops (should affect other hw as well) due to the
mismatch in this detection logic.
Another issue is why we have two functions doing the same thing,
but this can be resolved by a followup commits.
Signed-off-by: Maciej Pijanowski <maciej.pijanowski@3mdeb.com>
Running HCL on platforms that are not listed in board_config ends on
exiting the script. Calling that function was added while working on APU
support, as there is multiple flash chip detected when try to use
flashrom on that platform so chip name definition was added to specific
platform in board_config.
There is no need for that as check_flash_chip function check one by one
known chips from the list defined as FLASH_CHIP_LIST (in dts_environment)
and uses one, that does not return error when flashrom is invoked.
Later in HCL we uses check_intel_regions func which needs
PROGRAMMER_BIOS variable but this is by default defined in
dts_enviroment as `internal` so in HCL we can assume to use this
programmer for every platform.
Signed-off-by: Tomasz Żyjewski <tomasz.zyjewski@3mdeb.com>
