I believe this patch eliminates all remaining uses of _context
or _linkingContext variable names. Consistent naming improves
readability.
git-svn-id: https://llvm.org/svn/llvm-project/lld/trunk@234645 91177308-0d34-0410-b5e6-96231b3b80d8
Merge::mergeByLargestSection is half-baked since it's defined
in terms of section size, there's no way to get the section size
of an atom.
Currently we work around the issue by traversing the layout edges
to both directions and calculate the sum of all atoms reachable.
I wrote that code but I knew it's hacky. It's even not guaranteed
to work. If you add layout edges before the core linking, it
miscalculates a size.
Also it's of course slow. It's basically a linked list traversal.
In this patch I added DefinedAtom::sectionSize so that we can use
that for mergeByLargestSection. I'm not very happy to add a new
field to DefinedAtom base class, but I think it's legitimate since
mergeByLargestSection is defined for section size, and the section
size is currently just missing.
http://reviews.llvm.org/D7966
git-svn-id: https://llvm.org/svn/llvm-project/lld/trunk@231290 91177308-0d34-0410-b5e6-96231b3b80d8
The mergeByContent attribute on DefinedAtoms triggers the symbol table to
coalesce atoms with the exact same content. The problem is that atoms can also
have a required custom section. The coalescing should never change the custom
section of an atom.
The fix is to only consider to atoms to have the same content if their
sectionChoice() and customSectionName() attributes match.
git-svn-id: https://llvm.org/svn/llvm-project/lld/trunk@218893 91177308-0d34-0410-b5e6-96231b3b80d8
defined in a shared library.
Now LLD does not export a strong defined symbol if it coalesces away a
weak symbol defined in a shared library. This bug affects all ELF
architectures and leads to segfault:
% cat foo.c
extern int __attribute__((weak)) flag;
int foo() { return flag; }
% cat main.c
int flag = 1;
int foo();
int main() { return foo() == 1 ? 0 : -1; }
% clang -c -fPIC foo.c main.c
% lld -flavor gnu -target x86_64 -shared -o libfoo.so ... foo.o
% lld -flavor gnu -target x86_64 -o a.out ... main.o libfoo.so
% ./a.out
Segmentation fault
The problem is caused by the fact that we lose all information about
coalesced symbols after the `Resolver::resolve()` method is finished.
The patch solves the problem by overriding the
`LinkingContext::notifySymbolTableCoalesce()` method and saving names
of coalesced symbols. Later in the `buildDynamicSymbolTable()` routine
we use this information to export these symbols.
git-svn-id: https://llvm.org/svn/llvm-project/lld/trunk@217363 91177308-0d34-0410-b5e6-96231b3b80d8
isCoalescedAway(x) is faster than replacement(x) != x as the former
does not follow the replacement atom chain. Also it's easier to use.
git-svn-id: https://llvm.org/svn/llvm-project/lld/trunk@210242 91177308-0d34-0410-b5e6-96231b3b80d8
In r205566, I made a change to Resolver so that Resolver revisit
only archive files in --start-group and --end-group pair. That's
not correct, as it also has to revisit DSO files.
This patch is to fix the issue.
Added a test to demonstrate the fix. I confirmed that it succeeded
before r205566, failed after r205566, and is ok with this patch.
Differential Revision: http://reviews.llvm.org/D3734
git-svn-id: https://llvm.org/svn/llvm-project/lld/trunk@208797 91177308-0d34-0410-b5e6-96231b3b80d8
Davide Italiano
Rui Ueyama
Rafael Espindola
Simon Atanasyan
Shankar Easwaran
Nick Kledzik