atl/android_translation_layer
0
0
Fork 0
mirror of https://gitlab.com/android_translation_layer/android_translation_layer.git synced 2025-10-27 11:48:10 -07:00
Code Issues Packages Projects Releases Wiki Activity

Revert "View: call onLayout() only on size change or on request"

Browse Source 
This reverts commit b33a470c7b.

This commit was added as fix for layout recreation loops, but this is no
longer a problem, since ViewGroup.detachViewFromParent() has been
improved. The first fix is no longer needed and it seems to cause some
minor regressions, so we revert it.
This commit is contained in:
Julian Winkler
2025-03-25 19:59:25 +01:00
parent caa4700487
commit 15a6432d01
3 changed files with 7 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/api-impl-jni/views/AndroidLayout.c
View File

@@ -70,18 +70,9 @@ static void android_layout_allocate(GtkLayoutManager *layout_manager, GtkWidget
height = layout->real_height;
}
jboolean layoutChanged = (*env)->CallBooleanMethod(env, layout->view, handle_cache.view.layoutInternal, width, height);
(*env)->CallVoidMethod(env, layout->view, handle_cache.view.layoutInternal, width, height);
if((*env)->ExceptionCheck(env))
(*env)->ExceptionDescribe(env);
if (!layoutChanged) { // No change in layout. Reapply the current allocations
for (GtkWidget *child = gtk_widget_get_first_child(widget); child; child = gtk_widget_get_next_sibling(child)) {
graphene_matrix_t transform_matrix;
if (gtk_widget_compute_transform(child, widget, &transform_matrix)) {
GskTransform *transform = gsk_transform_matrix(NULL, &transform_matrix);
gtk_widget_allocate(child, gtk_widget_get_width(child), gtk_widget_get_height(child), gtk_widget_get_baseline(child), transform);
}
}
}
}
static GtkSizeRequestMode android_layout_get_request_mode(GtkLayoutManager *layout_manager, GtkWidget *widget)