Oleg Nesterov e72f38d31b oom: fix the unsafe usage of badness() in proc_oom_score() ...

commit b95c35e76b upstream.

proc_oom_score(task) has a reference to task_struct, but that is all.
If this task was already released before we take tasklist_lock

	- we can't use task->group_leader, it points to nowhere

	- it is not safe to call badness() even if this task is
	  ->group_leader, has_intersects_mems_allowed() assumes
	  it is safe to iterate over ->thread_group list.

	- even worse, badness() can hit ->signal == NULL

Add the pid_alive() check to ensure __unhash_process() was not called.

Also, use "task" instead of task->group_leader. badness() should return
the same result for any sub-thread. Currently this is not true, but
this should be changed anyway.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

2010-04-26 07:41:13 -07:00

..

array.c

procfs: fix /proc/<pid>/stat stack pointer for kernel threads

2009-11-17 17:40:33 -08:00

base.c

oom: fix the unsafe usage of badness() in proc_oom_score()

2010-04-26 07:41:13 -07:00

cmdline.c

proc: switch /proc/cmdline to seq_file

2008-10-23 14:29:04 +04:00

cpuinfo.c

proc: move /proc/cpuinfo code to fs/proc/cpuinfo.c

2008-10-23 15:05:11 +04:00

devices.c

proc: move /proc/devices code to fs/proc/devices.c

2008-10-23 15:02:18 +04:00

generic.c

proc 1/2: do PDE usecounting even for ->read_proc, ->write_proc

2009-03-31 01:14:27 +04:00

inode.c

proc 2/2: remove struct proc_dir_entry::owner

2009-03-31 01:14:44 +04:00

internal.h

Move junk from proc_fs.h to fs/proc/internal.h

2009-06-11 21:36:01 -04:00

interrupts.c

proc: move /proc/interrupts boilerplate code to fs/proc/interrupts.c

2008-10-23 15:15:46 +04:00

Kconfig

proc: move PROC_PAGE_MONITOR to fs/proc/Kconfig

2008-10-10 04:18:57 +04:00

kcore.c

fs: includecheck fix: proc, kcore.c

2009-10-08 07:36:38 -07:00

kmsg.c

proc: move /proc/kmsg creation to fs/proc/kmsg.c

2008-10-23 14:35:08 +04:00

loadavg.c

sched, timers: cleanup avenrun users

2009-05-15 15:32:45 +02:00

Makefile

proc: export statistics for softirq to /proc

2009-06-18 13:03:41 -07:00

meminfo.c

hwpoison: fix/proc/meminfo alignment

2009-10-29 07:39:25 -07:00

mmu.c

fs/proc/mmu.c: headers butchery

2007-10-17 08:42:48 -07:00

nommu.c

seq_file: constify seq_operations

2009-09-23 07:39:29 -07:00

page.c

pagemap: export KPF_HWPOISON

2009-10-08 07:36:39 -07:00

proc_devtree.c

procfs: remove sparse errors in proc_devtree.c

2009-06-18 13:03:41 -07:00

proc_net.c

proc: stop using BKL

2009-01-05 12:27:44 +03:00

proc_sysctl.c

sysctl: remove "struct file *" argument of ->proc_handler

2009-09-24 07:21:04 -07:00

proc_tty.c

proc tty: remove struct tty_operations::read_proc

2009-04-01 08:59:10 -07:00

root.c

Convert obvious places to deactivate_locked_super()

2009-05-09 10:49:40 -04:00

softirqs.c

proc: export statistics for softirq to /proc

2009-06-18 13:03:41 -07:00

stat.c

proc: export statistics for softirq to /proc

2009-06-18 13:03:41 -07:00

task_mmu.c

procfs: provide stack information for threads

2009-09-23 07:39:41 -07:00

task_nommu.c

mm_for_maps: shift down_read(mmap_sem) to the caller

2009-08-10 20:48:32 +10:00

uptime.c

[PATCH] Fix idle time field in /proc/uptime

2009-09-24 10:16:24 +02:00

version.c

proc: switch /proc/version to seq_file

2008-10-23 14:19:58 +04:00

vmcore.c

proc: vmcore - use kzalloc in get_new_element()

2009-06-18 13:03:41 -07:00