Files
linux/drivers
Stanislav Brabec 599343ebd4 b44 WOL setup: one-bit-off stack corruption kernel panic fix
[ Upstream commit: e0188829cb ]

About 50% of shutdowns of b44 Ethernet adapter ends by kernel panic
with kernels compiled with stack-protector.

Checking b44_magic_pattern() return values, one call of
b44_magic_pattern() returns 127. It means, that set_bit(128, pmask)
was called on line 1509. It means that bit 0 of 17th byte of pmask was
overwritten. But pmask has only 16 bytes. Stack corruption happens.

It seems that set_bit() on line 1509 always writes one bit off.

The fix does not only solve the stack corruption, but also makes Wake
On LAN working on my onboard B44 on Asus A7V-333X mainboard.

It seems that this problem affects all kernel versions since commit
725ad800 ([PATCH] b44: add wol for old nic) on 2006-06-20.

Signed-off-by: Stanislav Brabec <sbrabec@suse.cz>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-18 14:05:08 -08:00
..
2009-12-01 16:32:20 -08:00
2009-12-01 16:32:19 -08:00
2009-12-18 14:05:04 -08:00
2009-12-01 11:24:19 +01:00
2009-11-26 09:22:33 +01:00
2009-11-12 07:26:01 -08:00
2009-12-18 14:03:24 -08:00
2009-11-30 16:39:42 -08:00
2009-12-18 14:04:01 -08:00