mirror of
https://github.com/armbian/linux.git
synced 2026-01-06 10:13:00 -08:00
8a533666d1
[ Upstream commitd3aaeb38c4, along with dependent backports of commits:69cce1d1409de79c127c218fa90f07580da35a31f7e57044eee049f28883] Gergely Kalman reported crashes in check_peer_redir(). It appears commitf39925dbde(ipv4: Cache learned redirect information in inetpeer.) added a race, leading to possible NULL ptr dereference. Since we can now change dst neighbour, we should make sure a reader can safely use a neighbour. Add RCU protection to dst neighbour, and make sure check_peer_redir() can be called safely by different cpus in parallel. As neighbours are already freed after one RCU grace period, this patch should not add typical RCU penalty (cache cold effects) Many thanks to Gergely for providing a pretty report pointing to the bug. Reported-by: Gergely Kalman <synapse@hippy.csoma.elte.hu> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
32 lines
1.1 KiB
C
32 lines
1.1 KiB
C
/* linux/net/inet/arp.h */
|
|
#ifndef _ARP_H
|
|
#define _ARP_H
|
|
|
|
#include <linux/if_arp.h>
|
|
#include <net/neighbour.h>
|
|
|
|
|
|
extern struct neigh_table arp_tbl;
|
|
|
|
extern void arp_init(void);
|
|
extern int arp_find(unsigned char *haddr, struct sk_buff *skb);
|
|
extern int arp_ioctl(struct net *net, unsigned int cmd, void __user *arg);
|
|
extern void arp_send(int type, int ptype, __be32 dest_ip,
|
|
struct net_device *dev, __be32 src_ip,
|
|
const unsigned char *dest_hw,
|
|
const unsigned char *src_hw, const unsigned char *th);
|
|
extern int arp_bind_neighbour(struct dst_entry *dst);
|
|
extern struct neighbour *__arp_bind_neighbour(struct dst_entry *dst, __be32 nexthop);
|
|
extern int arp_mc_map(__be32 addr, u8 *haddr, struct net_device *dev, int dir);
|
|
extern void arp_ifdown(struct net_device *dev);
|
|
|
|
extern struct sk_buff *arp_create(int type, int ptype, __be32 dest_ip,
|
|
struct net_device *dev, __be32 src_ip,
|
|
const unsigned char *dest_hw,
|
|
const unsigned char *src_hw,
|
|
const unsigned char *target_hw);
|
|
extern void arp_xmit(struct sk_buff *skb);
|
|
int arp_invalidate(struct net_device *dev, __be32 ip);
|
|
|
|
#endif /* _ARP_H */
|