Files
linux/include/linux
Tejun Heo b6891ed4e6 cgroup: fix RCU accesses to task->cgroups
commit 14611e51a5 upstream.

task->cgroups is a RCU pointer pointing to struct css_set.  A task
switches to a different css_set on cgroup migration but a css_set
doesn't change once created and its pointers to cgroup_subsys_states
aren't RCU protected.

task_subsys_state[_check]() is the macro to acquire css given a task
and subsys_id pair.  It RCU-dereferences task->cgroups->subsys[] not
task->cgroups, so the RCU pointer task->cgroups ends up being
dereferenced without read_barrier_depends() after it.  It's broken.

Fix it by introducing task_css_set[_check]() which does
RCU-dereference on task->cgroups.  task_subsys_state[_check]() is
reimplemented to directly dereference ->subsys[] of the css_set
returned from task_css_set[_check]().

This removes some of sparse RCU warnings in cgroup.

v2: Fixed unbalanced parenthsis and there's no need to use
    rcu_dereference_raw() when !CONFIG_PROVE_RCU.  Both spotted by Li.

Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Acked-by: Li Zefan <lizefan@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-07-21 18:21:25 -07:00
..
2013-05-17 14:31:05 -04:00
2013-05-07 19:46:02 -07:00
2013-04-29 15:40:23 -04:00
2013-03-23 16:11:31 -07:00
2013-05-10 14:37:17 +01:00
2013-05-01 16:36:22 +05:30
2013-03-28 10:10:25 -06:00
2013-05-07 18:38:27 -07:00
2013-04-29 18:28:40 -07:00
2013-05-06 13:07:33 +02:00
2013-04-30 17:04:06 -07:00
2013-04-01 11:04:50 -07:00
2013-04-30 17:04:00 -07:00
2013-04-29 18:28:44 -07:00
2013-05-04 14:47:26 -04:00
2013-04-29 15:54:28 -07:00
2013-05-28 11:05:08 +02:00
2013-04-29 15:54:28 -07:00
2013-04-12 10:26:23 +02:00
2013-04-09 14:13:29 -04:00
2013-03-29 15:31:30 -04:00
2013-06-25 16:07:44 -07:00
2013-04-30 15:50:12 +05:30
2013-03-28 11:10:22 -07:00
2013-04-29 15:54:37 -07:00