Files
linux/fs
Al Viro e808b6adb5 aio: fix the "too late munmap()" race
commit c7b2855505 upstream.

Current code has put_ioctx() called asynchronously from aio_fput_routine();
that's done *after* we have killed the request that used to pin ioctx,
so there's nothing to stop io_destroy() waiting in wait_for_all_aios()
from progressing.  As the result, we can end up with async call of
put_ioctx() being the last one and possibly happening during exit_mmap()
or elf_core_dump(), neither of which expects stray munmap() being done
to them...

We do need to prevent _freeing_ ioctx until aio_fput_routine() is done
with that, but that's all we care about - neither io_destroy() nor
exit_aio() will progress past wait_for_all_aios() until aio_fput_routine()
does really_put_req(), so the ioctx teardown won't be done until then
and we don't care about the contents of ioctx past that point.

Since actual freeing of these suckers is RCU-delayed, we don't need to
bump ioctx refcount when request goes into list for async removal.
All we need is rcu_read_lock held just over the ->ctx_lock-protected
area in aio_fput_routine().

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
Acked-by: Benjamin LaHaise <bcrl@kvack.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-03-19 08:57:43 -07:00
..
2011-03-31 11:26:23 -03:00
2011-03-31 11:26:23 -03:00
2011-05-19 16:55:28 +09:30
2011-07-17 23:20:29 -04:00
2011-12-21 12:57:44 -08:00
2011-11-11 09:35:59 -08:00
2011-06-20 17:53:24 -05:00
2011-03-31 11:26:23 -03:00
2012-01-06 14:13:52 -08:00
2011-03-31 11:26:23 -03:00
2011-06-03 18:24:58 -04:00
2011-04-14 16:06:56 -07:00
2011-07-17 23:21:35 -04:00
2012-03-19 08:57:43 -07:00
2011-07-06 12:15:16 -07:00
2012-01-25 17:24:51 -08:00
2012-02-29 16:34:35 -08:00
2011-07-06 10:41:13 -07:00
2011-05-26 10:01:43 -06:00
2011-05-23 19:58:53 +02:00
2011-06-03 18:24:58 -04:00