Gera Kazakov e041da0630 target: Fix >= v3.9+ regression in PR APTPL + ALUA metadata write-out ...

commit f730f9158f upstream.

This patch fixes a >= v3.9+ regression in __core_scsi3_write_aptpl_to_file()
+ core_alua_write_tpg_metadata() write-out, where a return value of -EIO was
incorrectly being returned upon success.

This bug was originally introduced in:

commit 0e9b10a90f
Author: Al Viro <viro@zeniv.linux.org.uk>
Date:   Sat Feb 23 15:22:43 2013 -0500

    target: writev() on single-element vector is pointless

However, given that the return of core_scsi3_update_and_write_aptpl()
was not used to determine if a command should be returned with non GOOD
status, this bug was not being triggered in PR logic until v3.11-rc1 by
commit:

commit 459f213ba1
Author: Andy Grover <agrover@redhat.com>
Date:   Thu May 16 10:41:02 2013 -0700

    target: Allocate aptpl_buf inside update_and_write_aptpl()

So, go ahead and only return -EIO if kernel_write() returned a
negative value.

Reported-by: Gera Kazakov <gkazakov@msn.com>
Signed-off-by: Gera Kazakov <gkazakov@msn.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Andy Grover <agrover@redhat.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2013-09-26 17:18:27 -07:00

..

iscsi

iscsi-target: Fix potential NULL pointer in solicited NOPOUT reject

2013-09-07 22:09:59 -07:00

loopback

tcm: switch to ->show_info()

2013-04-09 14:13:19 -04:00

sbp

Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending

2013-03-02 11:43:27 -08:00

tcm_fc

tcm_fc: Check for aborted sequence

2013-04-25 01:05:28 -07:00

Kconfig

sbp-target: Initial merge of firewire/ieee-1394 target mode support

2012-05-09 15:25:17 -07:00

Makefile

target: move code for CDB emulation

2012-07-16 17:27:45 -07:00

target_core_alua.c

target: Fix >= v3.9+ regression in PR APTPL + ALUA metadata write-out

2013-09-26 17:18:27 -07:00

target_core_alua.h

target: pass sense_reason as a return value

2012-11-06 20:55:46 -08:00

target_core_configfs.c

target: Have dev/enable show if TCM device is configured

2013-05-03 16:46:02 -07:00

target_core_device.c

target: Remove unused struct members in se_dev_entry

2013-05-03 16:42:18 -07:00

target_core_fabric_configfs.c

target: Add missing mapped_lun bounds checking during make_mappedlun setup

2013-02-18 18:47:28 -08:00

target_core_fabric_lib.c

target: Update copyright information to 2012

2012-11-27 22:47:02 -08:00

target_core_file.c

target/file: Fix off-by-one READ_CAPACITY bug for !S_ISBLK export

2013-05-30 17:46:27 -07:00

target_core_file.h

target/file: Bump FD_MAX_SECTORS to 2048 to handle 1M sized I/Os

2013-03-19 17:24:28 -07:00

target_core_hba.c

target: Update copyright information to 2012

2012-11-27 22:47:02 -08:00

target_core_iblock.c

target/iblock: Fix WCE=1 + DPOFUA=1 backend WRITE regression

2013-05-15 01:46:34 -07:00

target_core_iblock.h

target: kill struct se_subsystem_dev

2012-11-06 20:55:43 -08:00

target_core_internal.h

target: Remove unused struct members in se_dev_entry

2013-05-03 16:42:18 -07:00

target_core_pr.c

target: Fix >= v3.9+ regression in PR APTPL + ALUA metadata write-out

2013-09-26 17:18:27 -07:00

target_core_pr.h

target: pass sense_reason as a return value

2012-11-06 20:55:46 -08:00

target_core_pscsi.c

target/pscsi: Reject cross page boundary case in pscsi_map_sg

2013-03-19 17:31:14 -07:00

target_core_pscsi.h

target: kill struct se_subsystem_dev

2012-11-06 20:55:43 -08:00

target_core_rd.c

target/rd: Add ramdisk bit for NULLIO operation

2013-05-11 16:22:39 -07:00

target_core_rd.h

target/rd: Add ramdisk bit for NULLIO operation

2013-05-11 16:22:39 -07:00

target_core_sbc.c

target: Add sbc_execute_unmap() helper

2013-04-25 01:05:24 -07:00

target_core_spc.c

target: Fix trailing ASCII space usage in INQUIRY vendor+model

2013-09-07 22:09:59 -07:00

target_core_stat.c

target: Update copyright information to 2012

2012-11-27 22:47:02 -08:00

target_core_tmr.c

target: Remove useless if statement

2013-02-13 11:27:22 -08:00

target_core_tpg.c

target: fix possible memory leak in core_tpg_register()

2013-03-18 12:45:52 -07:00

target_core_transport.c

target: Propigate up ->cmd_kref put return via transport_generic_free_cmd

2013-05-31 01:21:23 -07:00

target_core_ua.c

target: Update copyright information to 2012

2012-11-27 22:47:02 -08:00

target_core_ua.h

target: pass sense_reason as a return value

2012-11-06 20:55:46 -08:00