Files
linux/include/net
Dan Carpenter dee4506f06 sctp: potential read out of bounds in sctp_ulpevent_type_enabled()
[ Upstream commit fa5f7b51fc3080c2b195fa87c7eca7c05e56f673 ]

This code causes a static checker warning because Smatch doesn't trust
anything that comes from skb->data.  I've reviewed this code and I do
think skb->data can be controlled by the user here.

The sctp_event_subscribe struct has 13 __u8 fields and we want to see
if ours is non-zero.  sn_type can be any value in the 0-USHRT_MAX range.
We're subtracting SCTP_SN_TYPE_BASE which is 1 << 15 so we could read
either before the start of the struct or after the end.

This is a very old bug and it's surprising that it would go undetected
for so long but my theory is that it just doesn't have a big impact so
it would be hard to notice.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-10-21 17:09:01 +02:00
..
2014-09-18 10:54:36 +02:00
2015-03-04 00:23:23 -05:00
2015-06-28 16:55:44 -07:00
2016-04-20 15:42:04 +09:00
2015-03-06 21:50:02 -05:00
2015-09-17 17:18:37 -07:00
2017-06-07 12:05:59 +02:00
2013-11-07 19:28:58 -05:00
2014-09-30 01:02:26 -04:00
2015-09-24 12:25:23 -07:00
2015-12-07 17:07:33 -05:00
2017-08-30 10:19:19 +02:00
2014-01-03 20:56:48 -05:00
2015-10-08 04:27:03 -07:00
2015-10-23 06:26:42 -07:00
2014-06-02 11:00:41 -07:00
2016-11-15 07:46:36 +01:00
2015-03-12 22:58:12 -04:00
2015-10-26 22:24:22 -07:00