Files
linux/kernel
Jiri Bohac 44d4037eb7 timer: Prevent overflow in apply_slack
commit 98a01e779f upstream.

On architectures with sizeof(int) < sizeof (long), the
computation of mask inside apply_slack() can be undefined if the
computed bit is > 32.

E.g. with: expires = 0xffffe6f5 and slack = 25, we get:

expires_limit = 0x20000000e
bit = 33
mask = (1 << 33) - 1  /* undefined */

On x86, mask becomes 1 and and the slack is not applied properly.
On s390, mask is -1, expires is set to 0 and the timer fires immediately.

Use 1UL << bit to solve that issue.

Suggested-by: Deborah Townsend <dstownse@us.ibm.com>
Signed-off-by: Jiri Bohac <jbohac@suse.cz>
Link: http://lkml.kernel.org/r/20140418152310.GA13654@midget.suse.cz
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-07 13:25:30 -07:00
..
2013-04-22 07:09:06 -07:00
2013-04-15 13:25:16 +02:00
2012-12-20 17:40:19 -08:00
2013-05-05 00:16:35 -04:00
2013-04-30 17:04:03 -07:00
2014-06-07 13:25:30 -07:00