Files
linux/kernel
Tejun Heo 21de4eb26e workqueue: add missing smp_wmb() in process_one_work()
commit 959d1af8cf upstream.

WORK_STRUCT_PENDING is used to claim ownership of a work item and
process_one_work() releases it before starting execution.  When
someone else grabs PENDING, all pre-release updates to the work item
should be visible and all updates made by the new owner should happen
afterwards.

Grabbing PENDING uses test_and_set_bit() and thus has a full barrier;
however, clearing doesn't have a matching wmb.  Given the preceding
spin_unlock and use of clear_bit, I don't believe this can be a
problem on an actual machine and there hasn't been any related report
but it still is theretically possible for clear_pending to permeate
upwards and happen before work->entry update.

Add an explicit smp_wmb() before work_clear_pending().

Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-10-13 05:28:03 +09:00
..
2012-08-15 12:04:28 -07:00
2011-03-14 09:15:23 -04:00
2010-10-30 01:42:19 -04:00
2011-05-19 18:51:57 +10:00
2012-10-02 09:47:55 -07:00
2011-05-17 23:19:17 +02:00
2011-03-31 11:26:23 -03:00
2011-05-26 17:12:34 -07:00
2012-04-02 09:27:20 -07:00
2011-05-26 17:12:34 -07:00
2011-03-31 11:26:23 -03:00
2011-04-18 10:35:30 -07:00
2011-05-24 12:10:51 +02:00
2011-05-20 12:50:29 -07:00
2011-03-31 11:26:23 -03:00
2011-04-24 13:18:38 +02:00
2012-10-02 09:47:42 -07:00
2011-03-23 19:46:51 -07:00
2011-12-21 12:57:40 -08:00
2011-03-31 11:26:23 -03:00
2011-03-31 11:26:23 -03:00