David Jeffery c4d98e2535 lockd: protect nlm_blocked access in nlmsvc_retry_blocked ...

commit 1c327d962f upstream.

In nlmsvc_retry_blocked, the check that the list is non-empty and acquiring
the pointer of the first entry is unprotected by any lock.  This allows a rare
race condition when there is only one entry on the list.  A function such as
nlmsvc_grant_callback() can be called, which will temporarily remove the entry
from the list.  Between the list_empty() and list_entry(),the list may become
empty, causing an invalid pointer to be used as an nlm_block, leading to a
possible crash.

This patch adds the nlm_block_lock around these calls to prevent concurrent
use of the nlm_blocked list.

This was a regression introduced by
f904be9cc7  "lockd: Mostly remove BKL from
the server".

Signed-off-by: David Jeffery <djeffery@redhat.com>
Cc: Bryan Schumaker <bjschuma@netapp.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2013-07-28 16:30:22 -07:00

..

9p

aio: don't include aio.h in sched.h

2013-05-07 20:16:25 -07:00

adfs

fs: Limit sys_mount to only request filesystem modules.

2013-03-03 19:36:31 -08:00

affs

fs: Limit sys_mount to only request filesystem modules.

2013-03-03 19:36:31 -08:00

afs

aio: don't include aio.h in sched.h

2013-05-07 20:16:25 -07:00

autofs4

autofs - remove autofs dentry mount check

2013-05-06 13:06:59 -07:00

befs

befs_readdir(): do not increment ->f_pos if filldir tells us to stop

2013-05-31 15:17:56 -04:00

bfs

fs: Limit sys_mount to only request filesystem modules.

2013-03-03 19:36:31 -08:00

btrfs

Btrfs: only do the tree_mod_log_free_eb if this is our last ref

2013-07-21 18:21:32 -07:00

cachefiles

lift sb_start_write() out of ->write()

2013-04-09 14:12:56 -04:00

ceph

ceph: fix sleeping function called from invalid context.

2013-07-13 11:42:26 -07:00

cifs

Handle big endianness in NTLM (ntlmv2) authentication

2013-07-21 18:21:36 -07:00

coda

lift sb_start_write() out of ->write()

2013-04-09 14:12:56 -04:00

configfs

fs: Limit sys_mount to only request filesystem modules.

2013-03-03 19:36:31 -08:00

cramfs

fs: Limit sys_mount to only request filesystem modules.

2013-03-03 19:36:31 -08:00

debugfs

fs: Limit sys_mount to only request filesystem modules.

2013-03-03 19:36:31 -08:00

devpts

fs: Limit sys_mount to only request filesystem modules (Part 2).

2013-03-07 01:08:55 -08:00

dlm

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next

2013-05-01 14:08:52 -07:00

ecryptfs

eCryptfs: Check return of filemap_write_and_wait during fsync

2013-06-04 23:53:31 -07:00

efivarfs

efivarfs: Never return ENOENT from firmware again

2013-05-13 20:12:10 +01:00

efs

fs: Limit sys_mount to only request filesystem modules.

2013-03-03 19:36:31 -08:00

exofs

block: Add bio_for_each_segment_all()

2013-03-23 14:26:28 -07:00

exportfs

hlist: drop the node parameter from iterators

2013-02-27 19:10:24 -08:00

ext2

aio: don't include aio.h in sched.h

2013-05-07 20:16:25 -07:00

ext3

ext3,ext4: don't mess with dir_file->f_pos in htree_dirblock_to_tree()

2013-07-21 18:21:23 -07:00

ext4

ext4: fix error handling in ext4_ext_truncate()

2013-07-28 16:30:21 -07:00

f2fs

Merge tag 'f2fs-for-v3.10' of git://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs

2013-05-08 15:11:48 -07:00

fat

fat: fix possible overflow for fat_clusters

2013-05-24 16:22:50 -07:00

freevxfs

fs: Readd the fs module aliases.

2013-03-12 18:55:21 -07:00

fscache

fs/fscache/stats.c: fix memory leak

2013-04-29 15:54:27 -07:00

fuse

fuse: readdirplus: sanity checks

2013-07-28 16:30:08 -07:00

gfs2

GFS2: Don't cache iopen glocks

2013-06-03 16:40:22 +01:00

hfs

hfs: avoid crash in hfs_bnode_create

2013-05-24 16:22:51 -07:00

hfsplus

aio: don't include aio.h in sched.h

2013-05-07 20:16:25 -07:00

hostfs

hostfs: use kmalloc instead of kzalloc

2013-05-04 15:48:45 -04:00

hpfs

hpfs: better test for errors

2013-07-13 11:42:26 -07:00

hppfs

hppfs: get rid of ->fsync()

2013-04-29 15:41:42 -04:00

hugetlbfs

hugetlbfs: fix mmap failure in unaligned size request

2013-05-07 18:38:27 -07:00

isofs

fs: Readd the fs module aliases.

2013-03-12 18:55:21 -07:00

jbd

Merge branch 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs

2013-05-03 09:56:25 -07:00

jbd2

jbd2: fix theoretical race in jbd2__journal_restart

2013-07-21 18:21:22 -07:00

jffs2

fs: Limit sys_mount to only request filesystem modules.

2013-03-03 19:36:31 -08:00

jfs

fs/jfs: Add check if journaling to disk has been disabled in lbmRead()

2013-05-24 16:03:47 -05:00

lockd

lockd: protect nlm_blocked access in nlmsvc_retry_blocked

2013-07-28 16:30:22 -07:00

logfs

block: Remove bi_idx references

2013-03-23 14:15:31 -07:00

minix

fs: Limit sys_mount to only request filesystem modules.

2013-03-03 19:36:31 -08:00

ncpfs

ncpfs: fix rmdir returns Device or resource busy

2013-06-07 12:15:38 -04:00

nfs

NFSv4.1 end back channel session draining

2013-07-13 11:42:27 -07:00

nfs_common

nfs_common: Update the translation between nfsv3 acls linux posix acls

2013-02-13 06:15:14 -08:00

nfsd

nfsd4: fix decoding of compounds across page boundaries

2013-07-13 11:42:27 -07:00

nilfs2

nilfs2: fix issue of nilfs_set_page_dirty() for page at EOF boundary

2013-05-24 16:22:52 -07:00

nls

…

notify

unify compat fanotify_mark(2), switch to COMPAT_SYSCALL_DEFINE

2013-05-09 13:46:38 -04:00

ntfs

aio: don't include aio.h in sched.h

2013-05-07 20:16:25 -07:00

ocfs2

ocfs2: xattr: fix inlined xattr reflink

2013-07-21 18:21:29 -07:00

omfs

fs: Limit sys_mount to only request filesystem modules.

2013-03-03 19:36:31 -08:00

openpromfs

fs: Limit sys_mount to only request filesystem modules.

2013-03-03 19:36:31 -08:00

proc

kmsg: honor dmesg_restrict sysctl on /dev/kmsg

2013-06-12 16:29:44 -07:00

pstore

Merge tag 'please-pull-pstore' of git://git.kernel.org/pub/scm/linux/kernel/git/aegl/linux

2013-05-09 16:42:10 -07:00

qnx4

fs: Limit sys_mount to only request filesystem modules.

2013-03-03 19:36:31 -08:00

qnx6

qnx6: qnx6_readdir() has a braino in pos calculation

2013-05-31 15:17:31 -04:00

quota

quota: add missing use of dq_data_lock in __dquot_initialize

2013-03-11 22:05:56 +01:00

ramfs

Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs

2013-02-26 20:16:07 -08:00

reiserfs

reiserfs: fix deadlock with nfs racing on create/lookup

2013-05-31 23:14:20 +02:00

romfs

romfs: fix nommu map length to keep inside filesystem

2013-04-29 09:17:57 +10:00

squashfs

fs: Limit sys_mount to only request filesystem modules. (Part 3)

2013-03-11 07:09:48 -07:00

sysfs

sysfs: check if one entry has been removed before freeing

2013-04-05 15:35:52 -07:00

sysv

fs: Readd the fs module aliases.

2013-03-12 18:55:21 -07:00

ubifs

UBIFS: correct mount message

2013-07-21 18:21:36 -07:00

udf

aio: don't include aio.h in sched.h

2013-05-07 20:16:25 -07:00

ufs

Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial

2013-04-30 09:36:50 -07:00

xfs

xfs: don't shutdown log recovery on validation errors

2013-06-14 15:59:45 -05:00

aio.c

aio: fix io_destroy() regression by using call_rcu()

2013-06-12 16:29:46 -07:00

anon_inodes.c

get_empty_filp()/alloc_file() leave both ->f_pos and ->f_version zero

2013-02-26 02:46:11 -05:00

attr.c

…

bad_inode.c

…

binfmt_aout.c

Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs

2013-05-01 17:51:54 -07:00

binfmt_elf_fdpic.c

Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc

2013-05-02 10:16:16 -07:00

binfmt_elf.c

Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc

2013-05-02 10:16:16 -07:00

binfmt_em86.c

…

binfmt_flat.c

new helper: read_code()

2013-04-29 15:40:23 -04:00

binfmt_misc.c

binfmt_misc: reuse string_unescape_inplace()

2013-04-30 17:04:03 -07:00

binfmt_script.c

…

binfmt_som.c

…

bio-integrity.c

bio-integrity: Add explicit field for owner of bip_buf

2013-03-23 14:26:34 -07:00

bio.c

Merge branch 'for-3.10/core' of git://git.kernel.dk/linux-block

2013-05-08 10:13:35 -07:00

block_dev.c

writeback: Fix periodic writeback after fs mount

2013-07-28 16:29:40 -07:00

buffer.c

Merge branch 'for-3.10/core' of git://git.kernel.dk/linux-block

2013-05-08 10:13:35 -07:00

char_dev.c

…

compat_binfmt_elf.c

…

compat_ioctl.c

Removed unused typedef to avoid "unused local typedef" warnings.

2013-05-04 15:03:05 -04:00

compat.c

aio: don't include aio.h in sched.h

2013-05-07 20:16:25 -07:00

coredump.c

do_coredump(): don't wait for thaw if coredump has already been interrupted

2013-05-04 14:45:54 -04:00

coredump.h

…

dcache.c

vfs: use list_move instead of list_del/list_add

2013-05-04 15:43:02 -04:00

dcookies.c

consolidate compat lookup_dcookie()

2013-03-03 23:00:23 -05:00

direct-io.c

Merge branch 'for-3.10/core' of git://git.kernel.dk/linux-block

2013-05-08 10:13:35 -07:00

drop_caches.c

…

eventfd.c

…

eventpoll.c

Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/signal

2013-05-01 07:21:43 -07:00

exec.c

perf: Disable monitoring on setuid processes for regular users

2013-06-26 11:40:18 +02:00

fcntl.c

new helper: file_inode(file)

2013-02-22 23:31:31 -05:00

fhandle.c

…

file_table.c

fput: task_work_add() can fail if the caller has passed exit_task_work()

2013-06-15 05:39:08 +04:00

file.c

don't bother with deferred freeing of fdtables

2013-05-01 17:31:42 -04:00

filesystems.c

fs: Limit sys_mount to only request filesystem modules.

2013-03-03 19:36:31 -08:00

fs_struct.c

constify path_get/path_put and fs_struct.c stuff

2013-03-01 23:51:07 -05:00

fs-writeback.c

Merge branch 'for-3.10/core' of git://git.kernel.dk/linux-block

2013-05-08 10:13:35 -07:00

generic_acl.c

…

inode.c

Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs

2013-05-01 17:51:54 -07:00

internal.h

splice: don't pass the address of ->f_pos to methods

2013-06-20 19:02:45 +04:00

ioctl.c

new helper: file_inode(file)

2013-02-22 23:31:31 -05:00

ioprio.c

…

Kconfig

efivarfs: Move to fs/efivarfs

2013-04-17 13:25:09 +01:00

Kconfig.binfmt

fs: make binfmt support for #! scripts modular and removable

2013-04-30 17:04:04 -07:00

libfs.c

…

locks.c

new helper: file_inode(file)

2013-02-22 23:31:31 -05:00

Makefile

Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs

2013-05-01 17:51:54 -07:00

mbcache.c

…

mount.h

get rid of full-hash scan on detaching vfsmounts

2013-04-09 14:12:52 -04:00

mpage.c

…

namei.c

use can_lookup() instead of direct checks of ->i_op->lookup

2013-06-15 05:41:45 +04:00

namespace.c

create_mnt_ns: unidiomatic use of list_add()

2013-05-04 15:18:53 -04:00

no-block.c

…

open.c

make SYSCALL_DEFINE<n>-generated wrappers do asmlinkage_protect

2013-03-03 22:58:33 -05:00

pipe.c

aio: don't include aio.h in sched.h

2013-05-07 20:16:25 -07:00

pnode.c

vfs: Fix invalid ida_remove() call

2013-05-31 15:16:33 -04:00

pnode.h

Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs

2013-05-01 17:51:54 -07:00

posix_acl.c

…

proc_namespace.c

…

read_write.c

splice: don't pass the address of ->f_pos to methods

2013-06-20 19:02:45 +04:00

readdir.c

new helper: file_inode(file)

2013-02-22 23:31:31 -05:00

select.c

sched/rt: Move rt specific bits into new header file

2013-02-07 20:51:08 +01:00

seq_file.c

new helper: single_open_size()

2013-04-09 14:13:29 -04:00

signalfd.c

switch signalfd{,4}() to COMPAT_SYSCALL_DEFINE

2013-03-03 22:58:46 -05:00

splice.c

fs: fix new splice.c kernel-doc warning

2013-06-23 16:19:56 -10:00

stack.c

…

stat.c

switch vfs_getattr() to struct path

2013-02-26 02:46:08 -05:00

statfs.c

…

super.c

hlist: drop the node parameter from iterators

2013-02-27 19:10:24 -08:00

sync.c

teach SYSCALL_DEFINE<n> how to deal with long long/unsigned long long

2013-03-03 22:46:22 -05:00

timerfd.c

compat: restore timerfd settime and gettime compat syscalls

2013-03-02 09:35:13 -05:00

utimes.c

…

xattr_acl.c

…

xattr.c

…