Linus Torvalds
c32da02342
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial
...
* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial: (56 commits)
doc: fix typo in comment explaining rb_tree usage
Remove fs/ntfs/ChangeLog
doc: fix console doc typo
doc: cpuset: Update the cpuset flag file
Fix of spelling in arch/sparc/kernel/leon_kernel.c no longer needed
Remove drivers/parport/ChangeLog
Remove drivers/char/ChangeLog
doc: typo - Table 1-2 should refer to "status", not "statm"
tree-wide: fix typos "ass?o[sc]iac?te" -> "associate" in comments
No need to patch AMD-provided drivers/gpu/drm/radeon/atombios.h
devres/irq: Fix devm_irq_match comment
Remove reference to kthread_create_on_cpu
tree-wide: Assorted spelling fixes
tree-wide: fix 'lenght' typo in comments and code
drm/kms: fix spelling in error message
doc: capitalization and other minor fixes in pnp doc
devres: typo fix s/dev/devm/
Remove redundant trailing semicolons from macros
fix typo "definetly" -> "definitely" in comment
tree-wide: s/widht/width/g typo in comments
...
Fix trivial conflict in Documentation/laptops/00-INDEX
2010-03-12 16:04:50 -08:00
Joe Perches
724ee626f3
drivers/block/floppy.c: remove unnecessary casting in fd_ioctl
...
Convert outparam to const void *.
Cast outparam to const char * for strlen().
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:31 -08:00
Joe Perches
0aad92cfea
drivers/block/floppy.c: remove misleading, used once FD_IOCTL_ALLOWED macro
...
Just code the test directly
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:31 -08:00
Joe Perches
712e1de43e
drivers/block/floppy.c: remove obfuscating CODE2SIZE macro
...
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:31 -08:00
Joe Perches
ded2863d09
drivers/block/floppy.c: add __func__ to debugt
...
Make debugt messages a little neater.
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:31 -08:00
Joe Perches
7f2527174a
drivers/block/floppy.c: convert raw_cmd_copyin from while(1) to label: goto
...
Reduces indent.
Makes a bit more readable and intelligible.
Return value now at bottom of function.
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:31 -08:00
Joe Perches
ce2f11fe78
drivers/block/floppy.c: remove some unnecessary casting
...
Remove char/void __user * use.
Remove kmalloc cast.
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:31 -08:00
Joe Perches
1ebddd85a6
drivers/block/floppy.c: use %pf in logging messages
...
Print the function name not the pointer address where useful and possible
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:31 -08:00
Joe Perches
275176bc2a
drivers/block/floppy.c: use __func__ where appropriate
...
Add and use __func__ to is_alive.
Use __func__ in some DPRINTs.
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:31 -08:00
Joe Perches
891eda80a5
drivers/block/floppy.c: DPRINT neatening
...
Move DPRINT macro definition above 1st use Consolidate a format string
(>80 columns) Add a newline to an unterminated message Comment neatened
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:31 -08:00
Joe Perches
1a23d13335
drivers/block/floppy.c: remove #define FLOPPY_SANITY_CHECK
...
The code could not be compiled without the #define, so just remove it and
the #ifdef/#endif lines.
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:31 -08:00
Joe Perches
73507e6cd8
drivers/block/floppy.c: remove unnecessary argument from [__]reschedule_timeout
...
Prior to patch "drivers/block/floppy.c: Use pr_<level>" only
reschedule_timeout(,"request done"...) printed a numeric value after a
reschedule_timeout event message.
Restore that behavior and remove the now unnecessary argument.
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:31 -08:00
Joe Perches
0da3132f90
drivers/block/floppy.c: unclutter redo_fd_request logic
...
Change for(;;) with continue; to label: goto label
Reduces indentation and adds a bit of clarity.
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:31 -08:00
Joe Perches
416d8d2888
drivers/block/floppy.c: remove REPEAT macro
...
Macros with hidden flow changes aren't nice.
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:30 -08:00
Joe Perches
15b2630c58
drivers/block/floppy.c: remove unnecessary return and braces
...
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:30 -08:00
Joe Perches
57584c5a38
drivers/block/floppy.c: add function is_ready_state
...
Used a couple of times, might simplify the code a bit.
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:30 -08:00
Joe Perches
29f1c7848f
drivers/block/floppy.c: convert int initialising to bool initialized
...
Don't initialize initialized either. Default is false.
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:30 -08:00
Joe Perches
4d18ef09df
drivers/block/floppy.c: remove #define DEVICE_NAME "floppy"
...
Use it directly in the one place it's used.
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:30 -08:00
Joe Perches
c529730a98
drivers/block/floppy.c: move leading && and || to preceding line
...
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:30 -08:00
Joe Perches
74f63f469e
drivers/block/floppy.c: convert int 1/0 to bool true/false
...
Various functions use int where bool is appropriate
lock_fdc, wait_til_done, poll_drive, user_reset_fdc
Convert to bool.
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:30 -08:00
Joe Perches
55eee80c62
drivers/block/floppy.c: remove macros CALL, WAIT and IWAIT
...
Obfuscating macros with embedded returns are not nice
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:30 -08:00
Joe Perches
86b12b48a2
drivers/block/floppy.c: remove [_]COPYIN [_]COPYOUT and ECALL macros
...
Remove these obfuscating macros with hidden returns
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:30 -08:00
Joe Perches
4575b55281
drivers/block/floppy.c: remove most uses of CALL and ECALL macros
...
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:30 -08:00
Joe Perches
e029853612
drivers/block/floppy.c: remove [U]CLEARF, [U]SETF, and [U]TESTF macros
...
Use clear_bit, set_bit, and test_bit functions directly
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:30 -08:00
Joe Perches
87f530d8f1
drivers/block/floppy.c: add debug_dcl(...) macro
...
Converted #ifdef DCL_DEBUG if (test) DPRINTK(...); #endif
to debug_dcl(test, ...);
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:30 -08:00