Nick Piggin
75ad23bc0f
block: make queue flags non-atomic
...
We can save some atomic ops in the IO path, if we clearly define
the rules of how to modify the queue flags.
Signed-off-by: Jens Axboe <jens.axboe@oracle.com >
2008-04-29 14:48:33 +02:00
FUJITA Tomonori
8dea0d02f8
[SCSI] scsi_debug: remove unnecessary function declarations
...
This patch removes function declarations with moving some
functions. This cleans up them a bit to silence checkpatch.pl. There
is no functional change.
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp >
Acked-by: Douglas Gilbert <dougg@torque.net >
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com >
2008-04-07 12:19:07 -05:00
FUJITA Tomonori
5f2578e579
[SCSI] scsi_debug: support large non-fake virtual disk
...
Currently, the maximum amount of RAM that scsi_debug can allocate is
4GB. This patch increases it to 2TB; scsi_debug can allocates 2TB
memory and export it as if it were 2TB scsi disk.
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp >
Acked-by: Douglas Gilbert <dougg@torque.net >
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com >
2008-04-07 12:19:07 -05:00
FUJITA Tomonori
1978910062
[SCSI] scsi_debug: remove the duplicated code in resp_read and resp_write
...
resp_read and resp_write performs READ_* and WRITE_* commands
respectively. This sweeps up the similar code in them.
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp >
Acked-by: Douglas Gilbert <dougg@torque.net >
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com >
2008-04-07 12:19:06 -05:00
FUJITA Tomonori
28898873b0
[SCSI] scsi_debug: sweep up sdebug_capacity calculation
...
sdebug_capacity is calculated at five different places. This add a
helper function to calculate sdebug_capacity to sweep up the
duplicatated code.
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp >
Acked-by: Douglas Gilbert <dougg@torque.net >
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com >
2008-04-07 12:19:06 -05:00
FUJITA Tomonori
f58b0efbf4
[SCSI] scsi_debug: remove unnecessary sdebug_store_size
...
sdebug_store_size doesn't need to be static global. It's used at
startup only.
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp >
Acked-by: Douglas Gilbert <dougg@torque.net >
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com >
2008-04-07 12:19:06 -05:00
FUJITA Tomonori
d5cdc9898b
[SCSI] scsi_debug: fix lba and data length calculation bugs
...
For example, `modprobe scsi_debug virtual_gb=1100` gives:
scsi7 : scsi_debug, version 1.81 [20070104], dev_size_mb=8, opts=0x0
scsi 7:0:0:0: Direct-Access Linux scsi_debug 0004 PQ: 0 ANSI: 5
sd 7:0:0:0: [sdc] 2306867200 512-byte hardware sectors (1181116 MB)
sd 7:0:0:0: [sdc] Write Protect is off
sd 7:0:0:0: [sdc] Mode Sense: 73 00 10 08
sd 7:0:0:0: [sdc] Write cache: enabled, read cache: enabled, supports DPO and FUA
sd 7:0:0:0: [sdc] 2306867200 512-byte hardware sectors (1181116 MB)
sd 7:0:0:0: [sdc] Write Protect is off
sd 7:0:0:0: [sdc] Mode Sense: 73 00 10 08
sd 7:0:0:0: [sdc] Write cache: enabled, read cache: enabled, supports DPO and FUA
sdc: unknown partition table
sd 7:0:0:0: [sdc] Attached SCSI disk
sd 7:0:0:0: Attached scsi generic sg6 type 0
end_request: I/O error, dev sdc, sector 2306867072
Buffer I/O error on device sdc, logical block 288358384
end_request: I/O error, dev sdc, sector 2306867072
Buffer I/O error on device sdc, logical block 288358384
end_request: I/O error, dev sdc, sector 2306867192
(snip)
Note that this converts all the calculations (including the correct
calculations) for unification.
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp >
Acked-by: Douglas Gilbert <dougg@torque.net >
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com >
2008-04-07 12:19:03 -05:00
FUJITA Tomonori
a34c4e9836
[SCSI] scsi_debug: use scsi_build_sense_buffer
...
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp >
Cc: Douglas Gilbert <dougg@torque.net >
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com >
2008-04-07 12:19:01 -05:00
FUJITA Tomonori
639db475c8
[SCSI] scsi_debug: remove unnecessary function declarations
...
This patch removes lots of function declarations with moving
scsi_debug_queuecommand. This cleans up scsi_debug_queuecommand a bit
to silence checkpatch.pl
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp >
Acked-by: Douglas Gilbert <dougg@torque.net >
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com >
2008-04-07 12:18:59 -05:00
FUJITA Tomonori
8b40228f3f
[SCSI] scsi_debug: use list_for_each_entry_safe
...
This replaces list_for_each_safe and list_entry with
list_for_each_entry_safe.
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp >
Acked-by: Douglas Gilbert <dougg@torque.net >
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com >
2008-04-07 12:18:59 -05:00
FUJITA Tomonori
a75869d1ff
[SCSI] scsi_debug: remove unnecessary condition test in devInfoReg
...
open_devip is always non NULL.
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp >
Acked-by: Douglas Gilbert <dougg@torque.net >
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com >
2008-04-07 12:18:58 -05:00
FUJITA Tomonori
5cb2fc0610
[SCSI] scsi_debug: create new scsi_debug devices at a single place
...
Two functions, sdebug_add_adapter and devInfoReg, creates new
scsi_debug devices. To simplify the code, this patch adds a new helper
function to create new scsi_debug devices (sdebug_device_create) and
converts both functions to use it.
I plan to add more to scsi_debug devices (e.g. using a thread for a
scsi_debug device for scalability testings). This patch enable me to
add such to just the new helper function instead of touching two
functions, sdebug_add_adapter and devInfoReg.
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp >
Acked-by: Douglas Gilbert <dougg@torque.net >
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com >
2008-04-07 12:18:58 -05:00
FUJITA Tomonori
f3df41cff4
[SCSI] scsi_debug: remove temporary hack around sscanf for negative values
...
sscanf can handle negative values.
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp >
Acked-by: Douglas Gilbert <dougg@torque.net >
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com >
2008-04-07 12:18:58 -05:00
FUJITA Tomonori
21a6182924
[SCSI] scsi_debug: use sg buffer copy helper functions
...
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp >
Cc: Douglas Gilbert <dougg@torque.net >
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com >
2008-04-07 12:15:45 -05:00
FUJITA Tomonori
d1e4c9c57c
[SCSI] scsi_debug: use shost_priv macro
...
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp >
Acked-by: Douglas Gilbert <dougg@torque.net >
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com >
2008-04-07 12:15:41 -05:00
FUJITA Tomonori
96ad0dfe83
[SCSI] scsi_debug: remove unnecessary checking
...
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp >
Acked-by: Douglas Gilbert <dougg@torque.net >
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com >
2008-04-07 12:15:41 -05:00
FUJITA Tomonori
9e603ca06a
[SCSI] scsi_debug: remove scsi_debug.h
...
scsi_debug.h just incldues some function declarations. This patch removes it
with moving the scsi_host_template.
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp >
Acked-by: Douglas Gilbert <dougg@torque.net >
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com >
2008-04-07 12:15:41 -05:00
FUJITA Tomonori
9ff26eefd4
[SCSI] scsi_debug: stop including drivers/scsi/scsi.h
...
This converts scsi_debug to include header files in include/scsi/
instead of drivers/scsi/scsi.h.
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp >
Acked-by: Douglas Gilbert <dougg@torque.net >
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com >
2008-04-07 12:15:40 -05:00
Andi Kleen
9924a781f3
[SCSI] Remove random noop unchecked_isa_dma users
...
Lots of drivers set it to 0. Remove that. Patch should be a nop.
Signed-off-by: Andi Kleen <ak@suse.de >
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com >
2008-04-07 12:15:40 -05:00
FUJITA Tomonori
cbccc20712
[SCSI] scsi_debug: disable clustering
...
scsi_debug does at several places:
for_each_sg(sdb->table.sgl, sg, sdb->table.nents, k) {
kaddr = (unsigned char *)
kmap_atomic(sg_page(sg), KM_USER0);
We cannot do something like that with the clustering enabled (or we
can use scsi_kmap_atomic_sg).
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp >
Acked-by: Douglas Gilbert <dougg@torque.net >
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com >
2008-02-18 08:57:16 -06:00
FUJITA Tomonori
c639d14e2f
[SCSI] scsi_debug: add XDWRITEREAD_10 support
...
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp >
Acked-by: Douglas Gilbert <dougg@torque.net >
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com >
2008-01-30 13:14:25 -06:00
FUJITA Tomonori
072d0bb3ce
[SCSI] scsi_debug: add bidi data transfer support
...
This enables fill_from_dev_buffer and fetch_to_dev_buffer to handle
bidi commands.
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp >
Acked-by: Douglas Gilbert <dougg@torque.net >
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com >
2008-01-30 13:14:24 -06:00
FUJITA Tomonori
3de9f94479
[SCSI] scsi_debug: add get_data_transfer_info helper function
...
This adds get_data_transfer_info helper function that get lha and
sectors for READ_* and WRITE_* commands (and XDWRITEREAD_10 later).
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp >
Acked-by: Douglas Gilbert <dougg@torque.net >
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com >
2008-01-30 13:14:24 -06:00
Boaz Harrosh
c73961e563
[SCSI] scsi_debug: convert to use the data buffer accessors
...
- remove the unnecessary map_single path.
- convert to use the new accessors for the sg lists and the
parameters.
Signed-off-by: Boaz Harrosh <bharrosh@panasas.com >
Acked-by: Douglas Gilbert <dougg@torque.net >
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com >
2008-01-11 18:22:38 -06:00
Jens Axboe
45711f1af6
[SG] Update drivers to use sg helpers
...
Signed-off-by: Jens Axboe <jens.axboe@oracle.com >
2007-10-22 21:19:53 +02:00