linux-rockchip

mirror of https://github.com/armbian/linux-rockchip.git synced 2026-01-06 11:08:10 -08:00

Files

Dan Carpenter 7b4741644c fanotify: Fix stale file descriptor in copy_event_to_user()

commit ee12595147 upstream.

This code calls fd_install() which gives the userspace access to the fd.
Then if copy_info_records_to_user() fails it calls put_unused_fd(fd) but
that will not release it and leads to a stale entry in the file
descriptor table.

Generally you can't trust the fd after a call to fd_install().  The fix
is to delay the fd_install() until everything else has succeeded.

Fortunately it requires CAP_SYS_ADMIN to reach this code so the security
impact is less.

Fixes: f644bc449b ("fanotify: fix copy_event_to_user() fid error clean up")
Link: https://lore.kernel.org/r/20220128195656.GA26981@kili
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Mathias Krause <minipli@grsecurity.net>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2022-02-05 12:37:56 +01:00

dnotify

fsnotify: generalize handle_inode_event()

2020-12-30 11:54:18 +01:00

fanotify

fanotify: Fix stale file descriptor in copy_event_to_user()

2022-02-05 12:37:56 +01:00

inotify

inotify: convert to handle_inode_event() interface

2020-12-30 11:54:18 +01:00

fdinfo.c

fsnotify: Remove proc_fs.h include