You've already forked linux-rockchip
mirror of
https://github.com/armbian/linux-rockchip.git
synced 2026-01-06 11:08:10 -08:00
can: isotp: change error format from decimal to symbolic error names
commit 46d8657a6b upstream
This patch changes the format string for errors from decimal %d to
symbolic error names %pe to achieve more comprehensive log messages.
Link: https://lore.kernel.org/r/20210427052150.2308-2-menschel.p@posteo.de
Signed-off-by: Patrick Menschel <menschel.p@posteo.de>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
committed by
Greg Kroah-Hartman
parent
b881ce6c7d
commit
186ab56451
@@ -228,8 +228,8 @@ static int isotp_send_fc(struct sock *sk, int ae, u8 flowstatus)
|
||||
|
||||
can_send_ret = can_send(nskb, 1);
|
||||
if (can_send_ret)
|
||||
pr_notice_once("can-isotp: %s: can_send_ret %d\n",
|
||||
__func__, can_send_ret);
|
||||
pr_notice_once("can-isotp: %s: can_send_ret %pe\n",
|
||||
__func__, ERR_PTR(can_send_ret));
|
||||
|
||||
dev_put(dev);
|
||||
|
||||
@@ -814,8 +814,8 @@ isotp_tx_burst:
|
||||
|
||||
can_send_ret = can_send(skb, 1);
|
||||
if (can_send_ret)
|
||||
pr_notice_once("can-isotp: %s: can_send_ret %d\n",
|
||||
__func__, can_send_ret);
|
||||
pr_notice_once("can-isotp: %s: can_send_ret %pe\n",
|
||||
__func__, ERR_PTR(can_send_ret));
|
||||
|
||||
if (so->tx.idx >= so->tx.len) {
|
||||
/* we are done */
|
||||
@@ -976,8 +976,8 @@ static int isotp_sendmsg(struct socket *sock, struct msghdr *msg, size_t size)
|
||||
err = can_send(skb, 1);
|
||||
dev_put(dev);
|
||||
if (err) {
|
||||
pr_notice_once("can-isotp: %s: can_send_ret %d\n",
|
||||
__func__, err);
|
||||
pr_notice_once("can-isotp: %s: can_send_ret %pe\n",
|
||||
__func__, ERR_PTR(err));
|
||||
|
||||
/* no transmission -> no timeout monitoring */
|
||||
if (hrtimer_sec)
|
||||
|
||||
Reference in New Issue
Block a user