Linus Walleij
92b53ece5d
ASoC: tas2781-i2c: Drop weird GPIO code
...
[ Upstream commit c2c0b67dca3cb3b3cea0dd60075a1c5ba77e2fcd ]
The tas2781-i2c driver gets an IRQ from either ACPI or device tree,
then proceeds to check if the IRQ has a corresponding GPIO and in
case it does enforce the GPIO as input and set a label on it.
This is abuse of the API:
- First we cannot guarantee that the numberspaces of the GPIOs and
the IRQs are the same, i.e that an IRQ number corresponds to
a GPIO number like that.
- Second, GPIO chips and IRQ chips should be treated as orthogonal
APIs, the irqchip needs to ascertain that the backing GPIO line
is set to input etc just using the irqchip.
- Third it is using the legacy <linux/gpio.h> API which should not
be used in new code yet this was added just a year ago.
Delete the offending code.
If this creates problems the GPIO and irqchip maintainers can help
to fix the issues.
It *should* not create any problems, because the irq isn't
used anywhere in the driver, it's just obtained and then
left unused.
Fixes: ef3bcde75d ("ASoC: tas2781: Add tas2781 driver")
Signed-off-by: Linus Walleij <linus.walleij@linaro.org >
Link: https://patch.msgid.link/20240807-asoc-tas-gpios-v2-1-bd0f2705d58b@linaro.org
Signed-off-by: Mark Brown <broonie@kernel.org >
Signed-off-by: Sasha Levin <sashal@kernel.org >
2024-10-04 16:29:05 +02:00
..
2023-01-25 09:34:20 +01:00
2023-07-31 23:24:03 +01:00
2023-03-30 17:04:56 +02:00
2023-02-03 12:04:02 +00:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:25:18 -07:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2019-06-19 17:09:55 +02:00
2023-05-23 12:11:21 +02:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2023-08-17 09:24:15 +02:00
2023-07-21 09:37:47 +02:00
2023-08-17 09:24:33 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-02-08 13:00:28 +00:00
2023-11-20 11:59:17 +01:00
2024-06-12 11:12:44 +02:00
2023-01-31 12:10:46 +00:00
2023-08-18 23:41:54 +01:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:37 -07:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2019-06-19 17:09:55 +02:00
2019-05-30 11:26:32 -07:00
2023-05-23 18:49:36 +01:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2023-08-23 13:56:40 +01:00
2024-07-25 09:50:49 +02:00
2019-05-30 11:26:35 -07:00
2024-05-17 12:02:03 +02:00
2019-05-30 11:26:35 -07:00
2021-07-19 16:17:14 +02:00
2019-05-30 11:26:35 -07:00
2023-06-13 07:42:08 +02:00
2021-08-05 08:24:17 +02:00
2021-10-15 16:10:41 +01:00
2020-07-07 11:59:59 +02:00
2023-07-18 14:22:19 +02:00
2019-02-08 16:58:59 +01:00
2019-05-24 17:27:10 +02:00
2023-04-06 16:45:34 +01:00
2020-01-13 13:40:41 +01:00
2022-02-11 15:18:56 +01:00
2023-08-07 23:09:46 +01:00
2022-12-05 14:05:18 +00:00
2023-07-18 14:22:17 +02:00
2022-12-02 14:07:12 +00:00
2023-08-17 09:24:01 +02:00
2019-05-30 11:26:35 -07:00
2023-08-08 14:45:45 +02:00
2020-01-05 16:14:26 +01:00
2022-05-17 11:58:04 +01:00
2022-09-20 12:25:03 +01:00
2022-04-12 12:19:05 +02:00
2022-07-05 13:00:49 +01:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2022-08-24 08:00:26 +02:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2020-07-19 20:49:25 +02:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2021-06-08 17:05:41 +02:00
2019-05-30 11:26:35 -07:00
2020-09-09 18:43:07 +02:00
2023-03-24 14:52:58 +01:00
2023-08-18 12:19:19 +02:00
2019-05-30 11:26:35 -07:00
2022-05-07 22:55:48 +02:00
2023-08-17 09:24:08 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2020-11-05 17:25:17 +00:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2023-08-17 15:10:11 +01:00
2023-08-17 15:10:12 +01:00
2023-08-17 15:10:13 +01:00
2023-08-17 15:10:13 +01:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2022-11-28 13:04:24 +00:00
2023-05-23 12:11:33 +02:00
2023-05-23 12:11:21 +02:00
2020-01-03 09:24:19 +01:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2019-06-19 17:09:55 +02:00
2023-07-17 06:15:47 +01:00
2024-06-12 11:11:59 +02:00
2023-11-28 17:19:42 +00:00
2024-03-06 14:48:38 +00:00
2023-09-01 15:38:49 +02:00
2023-11-28 17:20:04 +00:00
2023-10-09 13:03:28 +01:00
2023-05-19 02:31:14 +09:00
2020-11-30 12:54:02 +00:00
2020-12-09 12:13:38 +00:00
2023-01-30 16:56:41 +00:00
2024-03-06 14:48:37 +00:00
2024-05-17 12:01:59 +02:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:41 -07:00
2024-08-03 08:53:57 +02:00
2023-06-19 12:59:29 +01:00
2024-10-04 16:29:05 +02:00
2019-05-30 11:26:35 -07:00
2020-09-09 18:32:52 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-05-30 11:26:35 -07:00
2019-06-05 17:37:07 +02:00
2019-06-19 17:09:55 +02:00
2024-09-08 07:54:30 +02:00
2023-06-12 18:22:26 +02:00
2023-08-24 10:03:17 +02:00
2019-05-30 11:26:35 -07:00
2020-01-03 09:24:20 +01:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:32 -07:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-10-25 11:06:57 +01:00
2019-05-30 11:26:32 -07:00
2020-06-15 20:58:33 +01:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-05-30 11:26:35 -07:00