Breno Leitao 27fe713c62 netpoll: Ensure clean state on setup failures ...

[ Upstream commit ae5a0456e0b4cfd7e61619e55251ffdf1bc7adfb ]

Modify netpoll_setup() and __netpoll_setup() to ensure that the netpoll
structure (np) is left in a clean state if setup fails for any reason.
This prevents carrying over misconfigured fields in case of partial
setup success.

Key changes:
- np->dev is now set only after successful setup, ensuring it's always
  NULL if netpoll is not configured or if netpoll_setup() fails.
- np->local_ip is zeroed if netpoll setup doesn't complete successfully.
- Added DEBUG_NET_WARN_ON_ONCE() checks to catch unexpected states.
- Reordered some operations in __netpoll_setup() for better logical flow.

These changes improve the reliability of netpoll configuration, since it
assures that the structure is fully initialized or totally unset.

Suggested-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Breno Leitao <leitao@debian.org>
Link: https://patch.msgid.link/20240822111051.179850-2-leitao@debian.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2024-10-10 11:57:26 +02:00

..

bpf_sk_storage.c

…

datagram.c

net: fix rc7's __skb_datagram_iter()

2024-07-18 13:21:13 +02:00

dev_addr_lists_test.c

…

dev_addr_lists.c

…

dev_ioctl.c

…

dev.c

net: add more sanity checks to qdisc_pkt_len_init()

2024-10-10 11:57:17 +02:00

dev.h

net: fix removing a namespace with conflicting altnames

2024-01-31 16:19:01 -08:00

drop_monitor.c

drop_monitor: replace spin_lock by raw_spin_lock

2024-06-27 13:49:01 +02:00

dst_cache.c

…

dst.c

…

failover.c

…

fib_notifier.c

…

fib_rules.c

…

filter.c

bpf: Zero former ARG_PTR_TO_{LONG,INT} args in case of error

2024-10-04 16:29:23 +02:00

flow_dissector.c

net: flow_dissector: use DEBUG_NET_WARN_ON_ONCE

2024-08-03 08:54:05 +02:00

flow_offload.c

…

gen_estimator.c

…

gen_stats.c

…

gro_cells.c

…

gro.c

net: Add netif_get_gro_max_size helper for GRO

2024-10-10 11:57:16 +02:00

gso.c

…

hwbm.c

…

link_watch.c

net: linkwatch: use system_unbound_wq

2024-08-14 13:58:39 +02:00

lwt_bpf.c

…

lwtunnel.c

…

Makefile

…

neighbour.c

neighbour: Don't let neigh_forced_gc() disable preemption for long

2024-01-20 11:51:43 +01:00

net_namespace.c

netns: Make get_net_ns() handle zero refcount net

2024-06-27 13:49:06 +02:00

net-procfs.c

…

net-sysfs.c

ethtool: check device is present when getting link settings

2024-09-04 13:28:26 +02:00

net-sysfs.h

…

net-traces.c

…

netclassid_cgroup.c

…

netdev-genl-gen.c

…

netdev-genl-gen.h

…

netdev-genl.c

…

netevent.c

…

netpoll.c

netpoll: Ensure clean state on setup failures

2024-10-10 11:57:26 +02:00

netprio_cgroup.c

…

of_net.c

…

page_pool.c

…

pktgen.c

kthread: add kthread_stop_put

2024-06-12 11:12:52 +02:00

ptp_classifier.c

…

request_sock.c

tcp: make sure init the accept_queue's spinlocks once

2024-01-31 16:19:00 -08:00

rtnetlink.c

rtnetlink: Don't ignore IFLA_TARGET_NETNSID when ifname is specified in rtnl_dellink().

2024-08-11 12:47:20 +02:00

scm.c

io_uring/unix: drop usage of io_uring socket

2024-03-26 18:19:09 -04:00

secure_seq.c

…

selftests.c

…

skbuff.c

net: core: reject skb_copy(_expand) for fraglist GSO skbs

2024-05-17 12:02:06 +02:00

skmsg.c

skmsg: Skip zero length skb in sk_msg_recvmsg

2024-07-18 13:21:12 +02:00

sock_destructor.h

…

sock_diag.c

sock_diag: annotate data-races around sock_diag_handlers[family]

2024-03-26 18:19:22 -04:00

sock_map.c

sock_map: Add a cond_resched() in sock_hash_free()

2024-10-04 16:28:58 +02:00

sock_reuseport.c

…

sock.c

net/socket: Break down __sys_getsockopt

2024-09-12 11:11:34 +02:00

stream.c

net: Return error from sk_stream_wait_connect() if sk_wait_event() fails

2024-01-01 12:42:30 +00:00

sysctl_net_core.c

net: make SK_MEMORY_PCPU_RESERV tunable

2024-05-02 16:32:36 +02:00

timestamping.c

…

tso.c

…

utils.c

…

xdp.c

xdp: fix invalid wait context of page_pool_destroy()

2024-08-03 08:53:44 +02:00