David Hildenbrand
9291799884
mm/memory_hotplug: drop valid_start/valid_end from test_pages_in_a_zone()
...
The callers are only interested in the actual zone, they don't care about
boundaries. Return the zone instead to simplify.
Link: http://lkml.kernel.org/r/20200110183308.11849-1-david@redhat.com
Signed-off-by: David Hildenbrand <david@redhat.com >
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
Cc: "Rafael J. Wysocki" <rafael@kernel.org >
Cc: Michal Hocko <mhocko@suse.com >
Cc: Oscar Salvador <osalvador@suse.de >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2020-02-04 03:05:23 +00:00
David Hildenbrand
bd5c2344f9
mm/memory_hotplug: pass in nid to online_pages()
...
Patch series "mm/memory_hotplug: pass in nid to online_pages()".
Simplify onlining code and get rid of find_memory_block(). Pass in the
nid from the memory block we are trying to online directly, instead of
manually looking it up.
This patch (of 2):
No need to lookup the memory block, we can directly pass in the nid.
Link: http://lkml.kernel.org/r/20200113113354.6341-2-david@redhat.com
Signed-off-by: David Hildenbrand <david@redhat.com >
Reviewed-by: Andrew Morton <akpm@linux-foundation.org >
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
Cc: "Rafael J. Wysocki" <rafael@kernel.org >
Cc: Michal Hocko <mhocko@suse.com >
Cc: Oscar Salvador <osalvador@suse.de >
Cc: Anshuman Khandual <anshuman.khandual@arm.com >
Cc: Dan Williams <dan.j.williams@intel.com >
Cc: Pavel Tatashin <pasha.tatashin@soleen.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2020-01-31 10:30:39 -08:00
David Hildenbrand
feee6b2989
mm/memory_hotplug: shrink zones when offlining memory
...
We currently try to shrink a single zone when removing memory. We use
the zone of the first page of the memory we are removing. If that
memmap was never initialized (e.g., memory was never onlined), we will
read garbage and can trigger kernel BUGs (due to a stale pointer):
BUG: unable to handle page fault for address: 000000000000353d
#PF: supervisor write access in kernel mode
#PF: error_code(0x0002) - not-present page
PGD 0 P4D 0
Oops: 0002 [#1 ] SMP PTI
CPU: 1 PID: 7 Comm: kworker/u8:0 Not tainted 5.3.0-rc5-next-20190820+ #317
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.12.1-0-ga5cab58e9a3f-prebuilt.qemu.4
Workqueue: kacpi_hotplug acpi_hotplug_work_fn
RIP: 0010:clear_zone_contiguous+0x5/0x10
Code: 48 89 c6 48 89 c3 e8 2a fe ff ff 48 85 c0 75 cf 5b 5d c3 c6 85 fd 05 00 00 01 5b 5d c3 0f 1f 840
RSP: 0018:ffffad2400043c98 EFLAGS: 00010246
RAX: 0000000000000000 RBX: 0000000200000000 RCX: 0000000000000000
RDX: 0000000000200000 RSI: 0000000000140000 RDI: 0000000000002f40
RBP: 0000000140000000 R08: 0000000000000000 R09: 0000000000000001
R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000140000
R13: 0000000000140000 R14: 0000000000002f40 R15: ffff9e3e7aff3680
FS: 0000000000000000(0000) GS:ffff9e3e7bb00000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 000000000000353d CR3: 0000000058610000 CR4: 00000000000006e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
__remove_pages+0x4b/0x640
arch_remove_memory+0x63/0x8d
try_remove_memory+0xdb/0x130
__remove_memory+0xa/0x11
acpi_memory_device_remove+0x70/0x100
acpi_bus_trim+0x55/0x90
acpi_device_hotplug+0x227/0x3a0
acpi_hotplug_work_fn+0x1a/0x30
process_one_work+0x221/0x550
worker_thread+0x50/0x3b0
kthread+0x105/0x140
ret_from_fork+0x3a/0x50
Modules linked in:
CR2: 000000000000353d
Instead, shrink the zones when offlining memory or when onlining failed.
Introduce and use remove_pfn_range_from_zone(() for that. We now
properly shrink the zones, even if we have DIMMs whereby
- Some memory blocks fall into no zone (never onlined)
- Some memory blocks fall into multiple zones (offlined+re-onlined)
- Multiple memory blocks that fall into different zones
Drop the zone parameter (with a potential dubious value) from
__remove_pages() and __remove_section().
Link: http://lkml.kernel.org/r/20191006085646.5768-6-david@redhat.com
Fixes: f1dd2cd13cd0dc12e86bdavid@redhat.com >
Reviewed-by: Oscar Salvador <osalvador@suse.de >
Cc: Michal Hocko <mhocko@suse.com >
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org >
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com >
Cc: Pavel Tatashin <pasha.tatashin@soleen.com >
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
Cc: Dan Williams <dan.j.williams@intel.com >
Cc: Logan Gunthorpe <logang@deltatee.com >
Cc: <stable@vger.kernel.org > [5.0+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2020-01-04 13:55:08 -08:00
Souptick Joarder
12cc1c7345
mm/memory_hotplug.c: remove __online_page_set_limits()
...
__online_page_set_limits() is a dummy function - remove it and all
callers.
Link: http://lkml.kernel.org/r/8e1bc9d3b492f6bde16e95ebc1dee11d6aefabd7.1567889743.git.jrdr.linux@gmail.com
Link: http://lkml.kernel.org/r/854db2cf8145d9635249c95584d9a91fd774a229.1567889743.git.jrdr.linux@gmail.com
Link: http://lkml.kernel.org/r/9afe6c5a18158f3884a6b302ac2c772f3da49ccc.1567889743.git.jrdr.linux@gmail.com
Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com >
Reviewed-by: David Hildenbrand <david@redhat.com >
Acked-by: Michal Hocko <mhocko@suse.com >
Cc: Juergen Gross <jgross@suse.com >
Cc: "Kirill A. Shutemov" <kirill@shutemov.name >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2019-12-01 12:59:10 -08:00
Ben Dooks (Codethink)
aba9817da1
include/linux/memory_hotplug.h: move definitions of {set,clear}_zone_contiguous
...
The {set,clear}_zone_contiguous are built whatever the configuratoon so
move the definitions outside the current ifdef to avoid the following
compiler warnings:
mm/page_alloc.c:1550:6: warning: no previous prototype for 'set_zone_contiguous' [-Wmissing-prototypes]
mm/page_alloc.c:1571:6: warning: no previous prototype for 'clear_zone_contiguous' [-Wmissing-prototypes]
Link: http://lkml.kernel.org/r/20191106123911.7435-1-ben.dooks@codethink.co.uk
Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk >
Acked-by: Michal Hocko <mhocko@suse.com >
Reviewed-by: David Hildenbrand <david@redhat.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2019-12-01 12:59:04 -08:00
David Hildenbrand
0ec4709743
mm/memory_hotplug: remove __online_page_free() and __online_page_increment_counters()
...
Let's drop the now unused functions.
Link: http://lkml.kernel.org/r/20190909114830.662-4-david@redhat.com
Signed-off-by: David Hildenbrand <david@redhat.com >
Acked-by: Michal Hocko <mhocko@suse.com >
Cc: Oscar Salvador <osalvador@suse.com >
Cc: Pavel Tatashin <pasha.tatashin@soleen.com >
Cc: Wei Yang <richard.weiyang@gmail.com >
Cc: Dan Williams <dan.j.williams@intel.com >
Cc: Qian Cai <cai@lca.pw >
Cc: Haiyang Zhang <haiyangz@microsoft.com >
Cc: "K. Y. Srinivasan" <kys@microsoft.com >
Cc: Sasha Levin <sashal@kernel.org >
Cc: Stephen Hemminger <sthemmin@microsoft.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2019-12-01 12:59:04 -08:00
David Hildenbrand
18db149120
mm/memory_hotplug: export generic_online_page()
...
Patch series "mm/memory_hotplug: Export generic_online_page()".
Let's replace the __online_page...() functions by generic_online_page().
Hyper-V only wants to delay the actual onlining of un-backed pages, so
we can simpy re-use the generic function.
This patch (of 3):
Let's expose generic_online_page() so online_page_callback users can
simply fall back to the generic implementation when actually deciding to
online the pages.
Link: http://lkml.kernel.org/r/20190909114830.662-2-david@redhat.com
Signed-off-by: David Hildenbrand <david@redhat.com >
Acked-by: Michal Hocko <mhocko@suse.com >
Cc: Oscar Salvador <osalvador@suse.com >
Cc: Pavel Tatashin <pasha.tatashin@soleen.com >
Cc: Dan Williams <dan.j.williams@intel.com >
Cc: Wei Yang <richard.weiyang@gmail.com >
Cc: Qian Cai <cai@lca.pw >
Cc: Haiyang Zhang <haiyangz@microsoft.com >
Cc: "K. Y. Srinivasan" <kys@microsoft.com >
Cc: Sasha Levin <sashal@kernel.org >
Cc: Stephen Hemminger <sthemmin@microsoft.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2019-12-01 12:59:04 -08:00
Dan Williams
ba72b4c8cf
mm/sparsemem: support sub-section hotplug
...
The libnvdimm sub-system has suffered a series of hacks and broken
workarounds for the memory-hotplug implementation's awkward
section-aligned (128MB) granularity.
For example the following backtrace is emitted when attempting
arch_add_memory() with physical address ranges that intersect 'System
RAM' (RAM) with 'Persistent Memory' (PMEM) within a given section:
# cat /proc/iomem | grep -A1 -B1 Persistent\ Memory
100000000-1ffffffff : System RAM
200000000-303ffffff : Persistent Memory (legacy)
304000000-43fffffff : System RAM
440000000-23ffffffff : Persistent Memory
2400000000-43bfffffff : Persistent Memory
2400000000-43bfffffff : namespace2.0
WARNING: CPU: 38 PID: 928 at arch/x86/mm/init_64.c:850 add_pages+0x5c/0x60
[..]
RIP: 0010:add_pages+0x5c/0x60
[..]
Call Trace:
devm_memremap_pages+0x460/0x6e0
pmem_attach_disk+0x29e/0x680 [nd_pmem]
? nd_dax_probe+0xfc/0x120 [libnvdimm]
nvdimm_bus_probe+0x66/0x160 [libnvdimm]
It was discovered that the problem goes beyond RAM vs PMEM collisions as
some platform produce PMEM vs PMEM collisions within a given section.
The libnvdimm workaround for that case revealed that the libnvdimm
section-alignment-padding implementation has been broken for a long
while.
A fix for that long-standing breakage introduces as many problems as it
solves as it would require a backward-incompatible change to the
namespace metadata interpretation. Instead of that dubious route [1],
address the root problem in the memory-hotplug implementation.
Note that EEXIST is no longer treated as success as that is how
sparse_add_section() reports subsection collisions, it was also obviated
by recent changes to perform the request_region() for 'System RAM'
before arch_add_memory() in the add_memory() sequence.
[1] https://lore.kernel.org/r/155000671719.348031.2347363160141119237.stgit@dwillia2-desk3.amr.corp.intel.com
[osalvador@suse.de: fix deactivate_section for early sections]
Link: http://lkml.kernel.org/r/20190715081549.32577-2-osalvador@suse.de
Link: http://lkml.kernel.org/r/156092354368.979959.6232443923440952359.stgit@dwillia2-desk3.amr.corp.intel.com
Signed-off-by: Dan Williams <dan.j.williams@intel.com >
Signed-off-by: Oscar Salvador <osalvador@suse.de >
Tested-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com > [ppc64]
Reviewed-by: Oscar Salvador <osalvador@suse.de >
Cc: Michal Hocko <mhocko@suse.com >
Cc: Vlastimil Babka <vbabka@suse.cz >
Cc: Logan Gunthorpe <logang@deltatee.com >
Cc: Pavel Tatashin <pasha.tatashin@soleen.com >
Cc: David Hildenbrand <david@redhat.com >
Cc: Jane Chu <jane.chu@oracle.com >
Cc: Jeff Moyer <jmoyer@redhat.com >
Cc: Jérôme Glisse <jglisse@redhat.com >
Cc: Jonathan Corbet <corbet@lwn.net >
Cc: Mike Rapoport <rppt@linux.ibm.com >
Cc: Toshi Kani <toshi.kani@hpe.com >
Cc: Wei Yang <richardw.yang@linux.intel.com >
Cc: Jason Gunthorpe <jgg@mellanox.com >
Cc: Christoph Hellwig <hch@lst.de >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2019-07-18 17:08:07 -07:00
Dan Williams
7ea6216049
mm/sparsemem: prepare for sub-section ranges
...
Prepare the memory hot-{add,remove} paths for handling sub-section
ranges by plumbing the starting page frame and number of pages being
handled through arch_{add,remove}_memory() to
sparse_{add,remove}_one_section().
This is simply plumbing, small cleanups, and some identifier renames.
No intended functional changes.
Link: http://lkml.kernel.org/r/156092353780.979959.9713046515562743194.stgit@dwillia2-desk3.amr.corp.intel.com
Signed-off-by: Dan Williams <dan.j.williams@intel.com >
Reviewed-by: Pavel Tatashin <pasha.tatashin@soleen.com >
Tested-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com > [ppc64]
Reviewed-by: Oscar Salvador <osalvador@suse.de >
Cc: Michal Hocko <mhocko@suse.com >
Cc: Vlastimil Babka <vbabka@suse.cz >
Cc: Logan Gunthorpe <logang@deltatee.com >
Cc: David Hildenbrand <david@redhat.com >
Cc: Jane Chu <jane.chu@oracle.com >
Cc: Jeff Moyer <jmoyer@redhat.com >
Cc: Jérôme Glisse <jglisse@redhat.com >
Cc: Jonathan Corbet <corbet@lwn.net >
Cc: Mike Rapoport <rppt@linux.ibm.com >
Cc: Toshi Kani <toshi.kani@hpe.com >
Cc: Wei Yang <richardw.yang@linux.intel.com >
Cc: Jason Gunthorpe <jgg@mellanox.com >
Cc: Christoph Hellwig <hch@lst.de >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2019-07-18 17:08:07 -07:00
David Hildenbrand
ea8846411a
mm/memory_hotplug: move and simplify walk_memory_blocks()
...
Let's move walk_memory_blocks() to the place where memory block logic
resides and simplify it. While at it, add a type for the callback
function.
Link: http://lkml.kernel.org/r/20190614100114.311-6-david@redhat.com
Signed-off-by: David Hildenbrand <david@redhat.com >
Reviewed-by: Andrew Morton <akpm@linux-foundation.org >
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
Cc: "Rafael J. Wysocki" <rafael@kernel.org >
Cc: David Hildenbrand <david@redhat.com >
Cc: Stephen Rothwell <sfr@canb.auug.org.au >
Cc: Pavel Tatashin <pasha.tatashin@soleen.com >
Cc: Andrew Banman <andrew.banman@hpe.com >
Cc: Mike Travis <mike.travis@hpe.com >
Cc: Oscar Salvador <osalvador@suse.com >
Cc: Michal Hocko <mhocko@suse.com >
Cc: Wei Yang <richard.weiyang@gmail.com >
Cc: Arun KS <arunks@codeaurora.org >
Cc: Qian Cai <cai@lca.pw >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2019-07-18 17:08:06 -07:00
David Hildenbrand
fbcf73ce65
mm/memory_hotplug: rename walk_memory_range() and pass start+size instead of pfns
...
walk_memory_range() was once used to iterate over sections. Now, it
iterates over memory blocks. Rename the function, fixup the
documentation.
Also, pass start+size instead of PFNs, which is what most callers
already have at hand. (we'll rework link_mem_sections() most probably
soon)
Follow-up patches will rework, simplify, and move walk_memory_blocks()
to drivers/base/memory.c.
Note: walk_memory_blocks() only works correctly right now if the
start_pfn is aligned to a section start. This is the case right now,
but we'll generalize the function in a follow up patch so the semantics
match the documentation.
[akpm@linux-foundation.org: remove unused variable]
Link: http://lkml.kernel.org/r/20190614100114.311-5-david@redhat.com
Signed-off-by: David Hildenbrand <david@redhat.com >
Reviewed-by: Andrew Morton <akpm@linux-foundation.org >
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org >
Cc: Paul Mackerras <paulus@samba.org >
Cc: Michael Ellerman <mpe@ellerman.id.au >
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net >
Cc: Len Brown <lenb@kernel.org >
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
Cc: David Hildenbrand <david@redhat.com >
Cc: Rashmica Gupta <rashmica.g@gmail.com >
Cc: Pavel Tatashin <pasha.tatashin@soleen.com >
Cc: Anshuman Khandual <anshuman.khandual@arm.com >
Cc: Michael Neuling <mikey@neuling.org >
Cc: Thomas Gleixner <tglx@linutronix.de >
Cc: Oscar Salvador <osalvador@suse.de >
Cc: Michal Hocko <mhocko@suse.com >
Cc: Wei Yang <richard.weiyang@gmail.com >
Cc: Juergen Gross <jgross@suse.com >
Cc: Qian Cai <cai@lca.pw >
Cc: Arun KS <arunks@codeaurora.org >
Cc: Nick Desaulniers <ndesaulniers@google.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2019-07-18 17:08:06 -07:00
David Hildenbrand
b9bf8d342d
mm/memory_hotplug: remove "zone" parameter from sparse_remove_one_section
...
The parameter is unused, so let's drop it. Memory removal paths should
never care about zones. This is the job of memory offlining and will
require more refactorings.
Link: http://lkml.kernel.org/r/20190527111152.16324-12-david@redhat.com
Signed-off-by: David Hildenbrand <david@redhat.com >
Reviewed-by: Dan Williams <dan.j.williams@intel.com >
Reviewed-by: Wei Yang <richardw.yang@linux.intel.com >
Reviewed-by: Oscar Salvador <osalvador@suse.de >
Acked-by: Michal Hocko <mhocko@suse.com >
Cc: Alex Deucher <alexander.deucher@amd.com >
Cc: Andrew Banman <andrew.banman@hpe.com >
Cc: Andy Lutomirski <luto@kernel.org >
Cc: Anshuman Khandual <anshuman.khandual@arm.com >
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org >
Cc: Arun KS <arunks@codeaurora.org >
Cc: Baoquan He <bhe@redhat.com >
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org >
Cc: Borislav Petkov <bp@alien8.de >
Cc: Catalin Marinas <catalin.marinas@arm.com >
Cc: Chintan Pandya <cpandya@codeaurora.org >
Cc: Christophe Leroy <christophe.leroy@c-s.fr >
Cc: Chris Wilson <chris@chris-wilson.co.uk >
Cc: Dave Hansen <dave.hansen@linux.intel.com >
Cc: "David S. Miller" <davem@davemloft.net >
Cc: Fenghua Yu <fenghua.yu@intel.com >
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
Cc: Heiko Carstens <heiko.carstens@de.ibm.com >
Cc: "H. Peter Anvin" <hpa@zytor.com >
Cc: Ingo Molnar <mingo@kernel.org >
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com >
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com >
Cc: Jun Yao <yaojun8558363@gmail.com >
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com >
Cc: Logan Gunthorpe <logang@deltatee.com >
Cc: Mark Brown <broonie@kernel.org >
Cc: Mark Rutland <mark.rutland@arm.com >
Cc: Masahiro Yamada <yamada.masahiro@socionext.com >
Cc: Mathieu Malaterre <malat@debian.org >
Cc: Michael Ellerman <mpe@ellerman.id.au >
Cc: Mike Rapoport <rppt@linux.vnet.ibm.com >
Cc: "mike.travis@hpe.com " <mike.travis@hpe.com >
Cc: Nicholas Piggin <npiggin@gmail.com >
Cc: Paul Mackerras <paulus@samba.org >
Cc: Pavel Tatashin <pasha.tatashin@soleen.com >
Cc: Peter Zijlstra <peterz@infradead.org >
Cc: Qian Cai <cai@lca.pw >
Cc: "Rafael J. Wysocki" <rafael@kernel.org >
Cc: Rich Felker <dalias@libc.org >
Cc: Rob Herring <robh@kernel.org >
Cc: Robin Murphy <robin.murphy@arm.com >
Cc: Thomas Gleixner <tglx@linutronix.de >
Cc: Tony Luck <tony.luck@intel.com >
Cc: Vasily Gorbik <gor@linux.ibm.com >
Cc: Will Deacon <will.deacon@arm.com >
Cc: Yoshinori Sato <ysato@users.sourceforge.jp >
Cc: Yu Zhao <yuzhao@google.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2019-07-18 17:08:06 -07:00
David Hildenbrand
05f800a0bd
mm/memory_hotplug: drop MHP_MEMBLOCK_API
...
No longer needed, the callers of arch_add_memory() can handle this
manually.
Link: http://lkml.kernel.org/r/20190527111152.16324-9-david@redhat.com
Signed-off-by: David Hildenbrand <david@redhat.com >
Reviewed-by: Wei Yang <richardw.yang@linux.intel.com >
Acked-by: Michal Hocko <mhocko@suse.com >
Cc: David Hildenbrand <david@redhat.com >
Cc: Oscar Salvador <osalvador@suse.com >
Cc: Pavel Tatashin <pasha.tatashin@soleen.com >
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com >
Cc: Qian Cai <cai@lca.pw >
Cc: Arun KS <arunks@codeaurora.org >
Cc: Mathieu Malaterre <malat@debian.org >
Cc: Mike Rapoport <rppt@linux.vnet.ibm.com >
Cc: Alex Deucher <alexander.deucher@amd.com >
Cc: Andrew Banman <andrew.banman@hpe.com >
Cc: Andy Lutomirski <luto@kernel.org >
Cc: Anshuman Khandual <anshuman.khandual@arm.com >
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org >
Cc: Baoquan He <bhe@redhat.com >
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org >
Cc: Borislav Petkov <bp@alien8.de >
Cc: Catalin Marinas <catalin.marinas@arm.com >
Cc: Chintan Pandya <cpandya@codeaurora.org >
Cc: Christophe Leroy <christophe.leroy@c-s.fr >
Cc: Chris Wilson <chris@chris-wilson.co.uk >
Cc: Dan Williams <dan.j.williams@intel.com >
Cc: Dave Hansen <dave.hansen@linux.intel.com >
Cc: "David S. Miller" <davem@davemloft.net >
Cc: Fenghua Yu <fenghua.yu@intel.com >
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
Cc: Heiko Carstens <heiko.carstens@de.ibm.com >
Cc: "H. Peter Anvin" <hpa@zytor.com >
Cc: Ingo Molnar <mingo@kernel.org >
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com >
Cc: Jun Yao <yaojun8558363@gmail.com >
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com >
Cc: Logan Gunthorpe <logang@deltatee.com >
Cc: Mark Brown <broonie@kernel.org >
Cc: Mark Rutland <mark.rutland@arm.com >
Cc: Masahiro Yamada <yamada.masahiro@socionext.com >
Cc: Michael Ellerman <mpe@ellerman.id.au >
Cc: Mike Rapoport <rppt@linux.ibm.com >
Cc: "mike.travis@hpe.com " <mike.travis@hpe.com >
Cc: Nicholas Piggin <npiggin@gmail.com >
Cc: Oscar Salvador <osalvador@suse.de >
Cc: Paul Mackerras <paulus@samba.org >
Cc: Peter Zijlstra <peterz@infradead.org >
Cc: "Rafael J. Wysocki" <rafael@kernel.org >
Cc: Rich Felker <dalias@libc.org >
Cc: Rob Herring <robh@kernel.org >
Cc: Robin Murphy <robin.murphy@arm.com >
Cc: Thomas Gleixner <tglx@linutronix.de >
Cc: Tony Luck <tony.luck@intel.com >
Cc: Vasily Gorbik <gor@linux.ibm.com >
Cc: Will Deacon <will.deacon@arm.com >
Cc: Yoshinori Sato <ysato@users.sourceforge.jp >
Cc: Yu Zhao <yuzhao@google.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2019-07-18 17:08:06 -07:00
David Hildenbrand
80ec922dbd
mm/memory_hotplug: allow arch_remove_memory() without CONFIG_MEMORY_HOTREMOVE
...
We want to improve error handling while adding memory by allowing to use
arch_remove_memory() and __remove_pages() even if
CONFIG_MEMORY_HOTREMOVE is not set to e.g., implement something like:
arch_add_memory()
rc = do_something();
if (rc) {
arch_remove_memory();
}
We won't get rid of CONFIG_MEMORY_HOTREMOVE for now, as it will require
quite some dependencies for memory offlining.
Link: http://lkml.kernel.org/r/20190527111152.16324-7-david@redhat.com
Signed-off-by: David Hildenbrand <david@redhat.com >
Reviewed-by: Pavel Tatashin <pasha.tatashin@soleen.com >
Cc: Tony Luck <tony.luck@intel.com >
Cc: Fenghua Yu <fenghua.yu@intel.com >
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org >
Cc: Paul Mackerras <paulus@samba.org >
Cc: Michael Ellerman <mpe@ellerman.id.au >
Cc: Heiko Carstens <heiko.carstens@de.ibm.com >
Cc: Yoshinori Sato <ysato@users.sourceforge.jp >
Cc: Rich Felker <dalias@libc.org >
Cc: Dave Hansen <dave.hansen@linux.intel.com >
Cc: Andy Lutomirski <luto@kernel.org >
Cc: Peter Zijlstra <peterz@infradead.org >
Cc: Thomas Gleixner <tglx@linutronix.de >
Cc: Borislav Petkov <bp@alien8.de >
Cc: "H. Peter Anvin" <hpa@zytor.com >
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
Cc: "Rafael J. Wysocki" <rafael@kernel.org >
Cc: Michal Hocko <mhocko@suse.com >
Cc: David Hildenbrand <david@redhat.com >
Cc: Oscar Salvador <osalvador@suse.com >
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com >
Cc: Alex Deucher <alexander.deucher@amd.com >
Cc: "David S. Miller" <davem@davemloft.net >
Cc: Mark Brown <broonie@kernel.org >
Cc: Chris Wilson <chris@chris-wilson.co.uk >
Cc: Christophe Leroy <christophe.leroy@c-s.fr >
Cc: Nicholas Piggin <npiggin@gmail.com >
Cc: Vasily Gorbik <gor@linux.ibm.com >
Cc: Rob Herring <robh@kernel.org >
Cc: Masahiro Yamada <yamada.masahiro@socionext.com >
Cc: "mike.travis@hpe.com " <mike.travis@hpe.com >
Cc: Andrew Banman <andrew.banman@hpe.com >
Cc: Arun KS <arunks@codeaurora.org >
Cc: Qian Cai <cai@lca.pw >
Cc: Mathieu Malaterre <malat@debian.org >
Cc: Baoquan He <bhe@redhat.com >
Cc: Logan Gunthorpe <logang@deltatee.com >
Cc: Anshuman Khandual <anshuman.khandual@arm.com >
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org >
Cc: Catalin Marinas <catalin.marinas@arm.com >
Cc: Chintan Pandya <cpandya@codeaurora.org >
Cc: Dan Williams <dan.j.williams@intel.com >
Cc: Ingo Molnar <mingo@kernel.org >
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com >
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com >
Cc: Jun Yao <yaojun8558363@gmail.com >
Cc: Mark Rutland <mark.rutland@arm.com >
Cc: Mike Rapoport <rppt@linux.vnet.ibm.com >
Cc: Oscar Salvador <osalvador@suse.de >
Cc: Robin Murphy <robin.murphy@arm.com >
Cc: Wei Yang <richard.weiyang@gmail.com >
Cc: Will Deacon <will.deacon@arm.com >
Cc: Yu Zhao <yuzhao@google.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2019-07-18 17:08:06 -07:00
Pavel Tatashin
eca499ab37
mm/hotplug: make remove_memory() interface usable
...
Presently the remove_memory() interface is inherently broken. It tries
to remove memory but panics if some memory is not offline. The problem
is that it is impossible to ensure that all memory blocks are offline as
this function also takes lock_device_hotplug that is required to change
memory state via sysfs.
So, between calling this function and offlining all memory blocks there
is always a window when lock_device_hotplug is released, and therefore,
there is always a chance for a panic during this window.
Make this interface to return an error if memory removal fails. This
way it is safe to call this function without panicking machine, and also
makes it symmetric to add_memory() which already returns an error.
Link: http://lkml.kernel.org/r/20190517215438.6487-3-pasha.tatashin@soleen.com
Signed-off-by: Pavel Tatashin <pasha.tatashin@soleen.com >
Reviewed-by: David Hildenbrand <david@redhat.com >
Acked-by: Michal Hocko <mhocko@suse.com >
Cc: Bjorn Helgaas <bhelgaas@google.com >
Cc: Borislav Petkov <bp@suse.de >
Cc: Dan Williams <dan.j.williams@intel.com >
Cc: Dave Hansen <dave.hansen@intel.com >
Cc: Dave Hansen <dave.hansen@linux.intel.com >
Cc: Dave Jiang <dave.jiang@intel.com >
Cc: Fengguang Wu <fengguang.wu@intel.com >
Cc: Huang Ying <ying.huang@intel.com >
Cc: James Morris <jmorris@namei.org >
Cc: Jérôme Glisse <jglisse@redhat.com >
Cc: Keith Busch <keith.busch@intel.com >
Cc: Ross Zwisler <zwisler@kernel.org >
Cc: Sasha Levin <sashal@kernel.org >
Cc: Takashi Iwai <tiwai@suse.de >
Cc: Tom Lendacky <thomas.lendacky@amd.com >
Cc: Vishal Verma <vishal.l.verma@intel.com >
Cc: Yaowei Bai <baiyaowei@cmss.chinamobile.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2019-07-16 19:23:24 -07:00
David Hildenbrand
ac5c942645
mm/memory_hotplug: make __remove_pages() and arch_remove_memory() never fail
...
All callers of arch_remove_memory() ignore errors. And we should really
try to remove any errors from the memory removal path. No more errors are
reported from __remove_pages(). BUG() in s390x code in case
arch_remove_memory() is triggered. We may implement that properly later.
WARN in case powerpc code failed to remove the section mapping, which is
better than ignoring the error completely right now.
Link: http://lkml.kernel.org/r/20190409100148.24703-5-david@redhat.com
Signed-off-by: David Hildenbrand <david@redhat.com >
Cc: Tony Luck <tony.luck@intel.com >
Cc: Fenghua Yu <fenghua.yu@intel.com >
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org >
Cc: Paul Mackerras <paulus@samba.org >
Cc: Michael Ellerman <mpe@ellerman.id.au >
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com >
Cc: Heiko Carstens <heiko.carstens@de.ibm.com >
Cc: Yoshinori Sato <ysato@users.sourceforge.jp >
Cc: Rich Felker <dalias@libc.org >
Cc: Dave Hansen <dave.hansen@linux.intel.com >
Cc: Andy Lutomirski <luto@kernel.org >
Cc: Peter Zijlstra <peterz@infradead.org >
Cc: Thomas Gleixner <tglx@linutronix.de >
Cc: Ingo Molnar <mingo@redhat.com >
Cc: Borislav Petkov <bp@alien8.de >
Cc: "H. Peter Anvin" <hpa@zytor.com >
Cc: Michal Hocko <mhocko@suse.com >
Cc: Mike Rapoport <rppt@linux.ibm.com >
Cc: Oscar Salvador <osalvador@suse.com >
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com >
Cc: Christophe Leroy <christophe.leroy@c-s.fr >
Cc: Stefan Agner <stefan@agner.ch >
Cc: Nicholas Piggin <npiggin@gmail.com >
Cc: Pavel Tatashin <pasha.tatashin@soleen.com >
Cc: Vasily Gorbik <gor@linux.ibm.com >
Cc: Arun KS <arunks@codeaurora.org >
Cc: Geert Uytterhoeven <geert@linux-m68k.org >
Cc: Masahiro Yamada <yamada.masahiro@socionext.com >
Cc: Rob Herring <robh@kernel.org >
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com >
Cc: Wei Yang <richard.weiyang@gmail.com >
Cc: Qian Cai <cai@lca.pw >
Cc: Mathieu Malaterre <malat@debian.org >
Cc: Andrew Banman <andrew.banman@hpe.com >
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
Cc: Ingo Molnar <mingo@kernel.org >
Cc: Mike Travis <mike.travis@hpe.com >
Cc: Oscar Salvador <osalvador@suse.de >
Cc: "Rafael J. Wysocki" <rafael@kernel.org >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2019-05-14 09:47:50 -07:00
Michal Hocko
940519f0c8
mm, memory_hotplug: provide a more generic restrictions for memory hotplug
...
arch_add_memory, __add_pages take a want_memblock which controls whether
the newly added memory should get the sysfs memblock user API (e.g.
ZONE_DEVICE users do not want/need this interface). Some callers even
want to control where do we allocate the memmap from by configuring
altmap.
Add a more generic hotplug context for arch_add_memory and __add_pages.
struct mhp_restrictions contains flags which contains additional features
to be enabled by the memory hotplug (MHP_MEMBLOCK_API currently) and
altmap for alternative memmap allocator.
This patch shouldn't introduce any functional change.
[akpm@linux-foundation.org: build fix]
Link: http://lkml.kernel.org/r/20190408082633.2864-3-osalvador@suse.de
Signed-off-by: Michal Hocko <mhocko@suse.com >
Signed-off-by: Oscar Salvador <osalvador@suse.de >
Cc: Dan Williams <dan.j.williams@intel.com >
Cc: David Hildenbrand <david@redhat.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2019-05-14 09:47:49 -07:00
Michal Hocko
5557c766ab
mm, memory_hotplug: cleanup memory offline path
...
check_pages_isolated_cb currently accounts the whole pfn range as being
offlined if test_pages_isolated suceeds on the range. This is based on
the assumption that all pages in the range are freed which is currently
the case in most cases but it won't be with later changes, as pages marked
as vmemmap won't be isolated.
Move the offlined pages counting to offline_isolated_pages_cb and rely on
__offline_isolated_pages to return the correct value.
check_pages_isolated_cb will still do it's primary job and check the pfn
range.
While we are at it remove check_pages_isolated and offline_isolated_pages
and use directly walk_system_ram_range as do in online_pages.
Link: http://lkml.kernel.org/r/20190408082633.2864-2-osalvador@suse.de
Reviewed-by: David Hildenbrand <david@redhat.com >
Signed-off-by: Michal Hocko <mhocko@suse.com >
Signed-off-by: Oscar Salvador <osalvador@suse.de >
Cc: Dan Williams <dan.j.williams@intel.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2019-05-14 09:47:49 -07:00
Linus Torvalds
d14d7f14f1
Merge tag 'for-linus-5.1a-rc1-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip
...
Pull xen updates from Juergen Gross:
"xen fixes and features:
- remove fallback code for very old Xen hypervisors
- three patches for fixing Xen dom0 boot regressions
- an old patch for Xen PCI passthrough which was never applied for
unknown reasons
- some more minor fixes and cleanup patches"
* tag 'for-linus-5.1a-rc1-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip:
xen: fix dom0 boot on huge systems
xen, cpu_hotplug: Prevent an out of bounds access
xen: remove pre-xen3 fallback handlers
xen/ACPI: Switch to bitmap_zalloc()
x86/xen: dont add memory above max allowed allocation
x86: respect memory size limiting via mem= parameter
xen/gntdev: Check and release imported dma-bufs on close
xen/gntdev: Do not destroy context while dma-bufs are in use
xen/pciback: Don't disable PCI_COMMAND on PCI device reset.
xen-scsiback: mark expected switch fall-through
xen: mark expected switch fall-through
2019-03-11 17:08:14 -07:00
Arun KS
a9cd410a3d
mm/page_alloc.c: memory hotplug: free pages as higher order
...
When freeing pages are done with higher order, time spent on coalescing
pages by buddy allocator can be reduced. With section size of 256MB,
hot add latency of a single section shows improvement from 50-60 ms to
less than 1 ms, hence improving the hot add latency by 60 times. Modify
external providers of online callback to align with the change.
[arunks@codeaurora.org: v11]
Link: http://lkml.kernel.org/r/1547792588-18032-1-git-send-email-arunks@codeaurora.org
[akpm@linux-foundation.org: remove unused local, per Arun]
[akpm@linux-foundation.org: avoid return of void-returning __free_pages_core(), per Oscar]
[akpm@linux-foundation.org: fix it for mm-convert-totalram_pages-and-totalhigh_pages-variables-to-atomic.patch]
[arunks@codeaurora.org: v8]
Link: http://lkml.kernel.org/r/1547032395-24582-1-git-send-email-arunks@codeaurora.org
[arunks@codeaurora.org: v9]
Link: http://lkml.kernel.org/r/1547098543-26452-1-git-send-email-arunks@codeaurora.org
Link: http://lkml.kernel.org/r/1538727006-5727-1-git-send-email-arunks@codeaurora.org
Signed-off-by: Arun KS <arunks@codeaurora.org >
Reviewed-by: Andrew Morton <akpm@linux-foundation.org >
Acked-by: Michal Hocko <mhocko@suse.com >
Reviewed-by: Oscar Salvador <osalvador@suse.de >
Reviewed-by: Alexander Duyck <alexander.h.duyck@linux.intel.com >
Cc: K. Y. Srinivasan <kys@microsoft.com >
Cc: Haiyang Zhang <haiyangz@microsoft.com >
Cc: Stephen Hemminger <sthemmin@microsoft.com >
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com >
Cc: Juergen Gross <jgross@suse.com >
Cc: Dan Williams <dan.j.williams@intel.com >
Cc: Vlastimil Babka <vbabka@suse.cz >
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com >
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
Cc: Mathieu Malaterre <malat@debian.org >
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com >
Cc: Souptick Joarder <jrdr.linux@gmail.com >
Cc: Mel Gorman <mgorman@techsingularity.net >
Cc: Aaron Lu <aaron.lu@intel.com >
Cc: Srivatsa Vaddagiri <vatsa@codeaurora.org >
Cc: Vinayak Menon <vinmenon@codeaurora.org >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2019-03-05 21:07:14 -08:00
Juergen Gross
357b4da50a
x86: respect memory size limiting via mem= parameter
...
When limiting memory size via kernel parameter "mem=" this should be
respected even in case of memory made accessible via a PCI card.
Today this kind of memory won't be made usable in initial memory
setup as the memory won't be visible in E820 map, but it might be
added when adding PCI devices due to corresponding ACPI table entries.
Not respecting "mem=" can be corrected by adding a global max_mem_size
variable set by parse_memopt() which will result in rejecting adding
memory areas resulting in a memory size above the allowed limit.
Signed-off-by: Juergen Gross <jgross@suse.com >
Acked-by: Ingo Molnar <mingo@kernel.org >
Reviewed-by: William Kucharski <william.kucharski@oracle.com >
Signed-off-by: Juergen Gross <jgross@suse.com >
2019-02-18 06:50:34 +01:00
Qian Cai
b13bc35193
mm/hotplug: invalid PFNs from pfn_to_online_page()
...
On an arm64 ThunderX2 server, the first kmemleak scan would crash [1]
with CONFIG_DEBUG_VM_PGFLAGS=y due to page_to_nid() found a pfn that is
not directly mapped (MEMBLOCK_NOMAP). Hence, the page->flags is
uninitialized.
This is due to the commit 9f1eb38e0e68709f45382d070eab2ef52bb98f5a#1 ] SMP
CPU: 60 PID: 1408 Comm: kmemleak Not tainted 5.0.0-rc2+ #8
pstate: 60400009 (nZCv daif +PAN -UAO)
pc : page_mapping+0x24/0x144
lr : __dump_page+0x34/0x3dc
sp : ffff00003a5cfd10
x29: ffff00003a5cfd10 x28: 000000000000802f
x27: 0000000000000000 x26: 0000000000277d00
x25: ffff000010791f56 x24: ffff7fe000000000
x23: ffff000010772f8b x22: ffff00001125f670
x21: ffff000011311000 x20: ffff000010772f8b
x19: fffffffffffffffe x18: 0000000000000000
x17: 0000000000000000 x16: 0000000000000000
x15: 0000000000000000 x14: ffff802698b19600
x13: ffff802698b1a200 x12: ffff802698b16f00
x11: ffff802698b1a400 x10: 0000000000001400
x9 : 0000000000000001 x8 : ffff00001121a000
x7 : 0000000000000000 x6 : ffff0000102c53b8
x5 : 0000000000000000 x4 : 0000000000000003
x3 : 0000000000000100 x2 : 0000000000000000
x1 : ffff000010772f8b x0 : ffffffffffffffff
Process kmemleak (pid: 1408, stack limit = 0x(____ptrval____))
Call trace:
page_mapping+0x24/0x144
__dump_page+0x34/0x3dc
dump_page+0x28/0x4c
kmemleak_scan+0x4ac/0x680
kmemleak_scan_thread+0xb4/0xdc
kthread+0x12c/0x13c
ret_from_fork+0x10/0x18
Code: d503201f f9400660 36000040 d1000413 (f9400661)
---[ end trace 4d4bd7f573490c8e ]---
Kernel panic - not syncing: Fatal exception
SMP: stopping secondary CPUs
Kernel Offset: disabled
CPU features: 0x002,20000c38
Memory Limit: none
---[ end Kernel panic - not syncing: Fatal exception ]---
Link: http://lkml.kernel.org/r/20190122132916.28360-1-cai@lca.pw
Fixes: 9f1eb38e0ecai@lca.pw >
Acked-by: Michal Hocko <mhocko@suse.com >
Cc: Oscar Salvador <osalvador@suse.de >
Cc: Catalin Marinas <catalin.marinas@arm.com >
Cc: Vlastimil Babka <vbabka@suse.cz >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2019-02-01 15:46:23 -08:00
Wei Yang
0614ce9776
include/linux/memory_hotplug.h: remove duplicate declaration of offline_pages()
...
offline_pages() is already declared in this file.
Just remove the duplicated one.
Link: http://lkml.kernel.org/r/20181205031357.24769-1-richard.weiyang@gmail.com
Signed-off-by: Wei Yang <richard.weiyang@gmail.com >
Reviewed-by: David Hildenbrand <david@redhat.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2018-12-28 12:11:50 -08:00
Wei Yang
4e0d2e7ef1
mm, sparse: pass nid instead of pgdat to sparse_add_one_section()
...
Since the information needed in sparse_add_one_section() is node id to
allocate proper memory, it is not necessary to pass its pgdat.
This patch changes the prototype of sparse_add_one_section() to pass node
id directly. This is intended to reduce misleading that
sparse_add_one_section() would touch pgdat.
Link: http://lkml.kernel.org/r/20181204085657.20472-2-richard.weiyang@gmail.com
Signed-off-by: Wei Yang <richard.weiyang@gmail.com >
Reviewed-by: David Hildenbrand <david@redhat.com >
Acked-by: Michal Hocko <mhocko@suse.com >
Cc: Dave Hansen <dave.hansen@intel.com >
Cc: Oscar Salvador <osalvador@suse.de >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2018-12-28 12:11:49 -08:00
Oscar Salvador
2c2a5af6fe
mm, memory_hotplug: add nid parameter to arch_remove_memory
...
Patch series "Do not touch pages in hot-remove path", v2.
This patchset aims for two things:
1) A better definition about offline and hot-remove stage
2) Solving bugs where we can access non-initialized pages
during hot-remove operations [2] [3].
This is achieved by moving all page/zone handling to the offline
stage, so we do not need to access pages when hot-removing memory.
[1] https://patchwork.kernel.org/cover/10691415/
[2] https://patchwork.kernel.org/patch/10547445/
[3] https://www.spinics.net/lists/linux-mm/msg161316.html
This patch (of 5):
This is a preparation for the following-up patches. The idea of passing
the nid is that it will allow us to get rid of the zone parameter
afterwards.
Link: http://lkml.kernel.org/r/20181127162005.15833-2-osalvador@suse.de
Signed-off-by: Oscar Salvador <osalvador@suse.de >
Reviewed-by: David Hildenbrand <david@redhat.com >
Reviewed-by: Pavel Tatashin <pasha.tatashin@soleen.com >
Cc: Michal Hocko <mhocko@suse.com >
Cc: Dan Williams <dan.j.williams@intel.com >
Cc: Jerome Glisse <jglisse@redhat.com >
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com >
Cc: "Rafael J. Wysocki" <rafael@kernel.org >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2018-12-28 12:11:49 -08:00
