diff --git a/projects/ArchR/packages/ui/emulationstation/patches/0001-sound-load-nav-sounds-regardless-of-EnableSounds.patch b/projects/ArchR/packages/ui/emulationstation/patches/0001-sound-load-nav-sounds-regardless-of-EnableSounds.patch new file mode 100644 index 0000000000..6e6cc7608e --- /dev/null +++ b/projects/ArchR/packages/ui/emulationstation/patches/0001-sound-load-nav-sounds-regardless-of-EnableSounds.patch @@ -0,0 +1,23 @@ +sound: load navigation sounds regardless of EnableSounds + +Sound::init() loaded the WAV only when EnableSounds was already true, so +toggling "ENABLE NAVIGATION SOUNDS" on in Sound Settings left every Sound +with a null sample until the next reboot (when init() re-ran with the +setting now true). Sound::play() already gates on the live EnableSounds +value, so loading the sample unconditionally is enough and makes the menu +toggle take effect immediately, in both directions, with no reboot. + +Reported by a user and reproduced on hardware. + +--- a/es-core/src/Sound.cpp ++++ b/es-core/src/Sound.cpp +@@ -67,9 +67,6 @@ + if (mPath.empty() || !Utils::FileSystem::exists(mPath)) + return; + +- if (!Settings::getInstance()->getBool("EnableSounds")) +- return; +- + //load wav file via SDL + mSampleData = Mix_LoadWAV(mPath.c_str()); + if (mSampleData == nullptr)