archr/Arch-R
0
0
Fork 0
mirror of https://github.com/archr-linux/Arch-R.git synced 2026-07-12 18:19:42 -07:00
Code Issues Packages Projects Releases Wiki Activity

es-menu: drop dead VIDEO PREVIEWS / VRR toggles, warn on overlay-reset reboot

Browse Source 
From the ES menu audit:
- SHOW VIDEO PREVIEWS (UI) toggled Settings "EnableVideoPreviews", consumed
  nowhere. Dead toggle removed.
- VARIABLE REFRESH RATE (Latency) toggled <config>.vrr_runloop_enable, read by
  no launch script and meaningless on the fixed RK3326 panel. Dead toggle
  removed.
- RESET OVERLAYS / FULLY RESET RETROARCH reboot the device (factoryreset
  overlays -> systemctl reboot) without warning; their confirmation text now
  says "THE DEVICE WILL REBOOT."

Second patch under this package's patches/. Pending validation: takes effect
after the ES package is rebuilt.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Douglas Teles
2026-06-25 23:10:41 -03:00
parent d65cb345bf
commit 4abec79f22
1 changed files with 61 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
projects/ArchR/packages/ui/emulationstation/patches/0002-menu-drop-dead-toggles-and-warn-overlay-reset-reboot.patch
+61
View File
@@ -0,0 +1,61 @@
es-menu: drop dead VIDEO PREVIEWS / VRR toggles, warn on overlay-reset reboot
Menu-audit cleanup of GuiMenu.cpp:
- SHOW VIDEO PREVIEWS wrote Settings "EnableVideoPreviews", which nothing in
es-app/es-core ever reads (video playback is gated elsewhere). Dead toggle,
removed.
- VARIABLE REFRESH RATE wrote SystemConf <config>.vrr_runloop_enable, which no
launch script consumes, and VRR is meaningless on the fixed-refresh RK3326
panel anyway. Dead toggle, removed.
- RESET OVERLAYS and FULLY RESET RETROARCH run `factoryreset overlays`
(and retroarch-full+overlays), which calls `systemctl reboot`, but their
confirmation text never said so. Add "THE DEVICE WILL REBOOT." so the reboot
is not a surprise.
--- a/es-app/src/guis/GuiMenu.cpp
+++ b/es-app/src/guis/GuiMenu.cpp
@@ -288,14 +288,14 @@
});
s->addEntry(_("RESET OVERLAYS (CORES, CHEATS, JOYPADS, ETC)"), true, [window] {
- window->pushGui(new GuiMsgBox(window, _("WARNING: ALL CUSTOM RETROARCH OVERLAYS WILL BE REMOVED\n\nCUSTOM CORES, JOYSTICKS, CHEATS, ETC. NO BACKUP WILL BE CREATED!\n\nRESET RETROARCH OVERLAYS TO DEFAULT?"), _("YES"),
+ window->pushGui(new GuiMsgBox(window, _("WARNING: ALL CUSTOM RETROARCH OVERLAYS WILL BE REMOVED\n\nCUSTOM CORES, JOYSTICKS, CHEATS, ETC. NO BACKUP WILL BE CREATED!\n\nTHE DEVICE WILL REBOOT.\n\nRESET RETROARCH OVERLAYS TO DEFAULT?"), _("YES"),
[] {
Utils::Platform::runSystemCommand("/usr/bin/run \"/usr/bin/factoryreset overlays\"", "", nullptr);
}, _("NO"), nullptr));
});
s->addEntry(_("FULLY RESET RETROARCH"), true, [window] {
- window->pushGui(new GuiMsgBox(window, _("WARNING: RETROARCH AND ALL USER SAVED CONFIGURATIONS WILL RESET TO DEFAULT\n\nPER-CORE CONFIGURATIONS WILL BE REMOVED AND NO BACKUP WILL BE CREATED!\n\nRESET RETROARCH?"), _("YES"),
+ window->pushGui(new GuiMsgBox(window, _("WARNING: RETROARCH AND ALL USER SAVED CONFIGURATIONS WILL RESET TO DEFAULT\n\nPER-CORE CONFIGURATIONS WILL BE REMOVED AND NO BACKUP WILL BE CREATED!\n\nTHE DEVICE WILL REBOOT.\n\nRESET RETROARCH?"), _("YES"),
[] {
Utils::Platform::runSystemCommand("/usr/bin/run \"/usr/bin/factoryreset retroarch-full && /usr/bin/factoryreset overlays\"", "", nullptr);
}, _("NO"), nullptr));
@@ -2814,12 +2814,6 @@
guiLatency->addWithDescription(_("AUTO FRAME DELAY"), _("Automatically decrease frame delay temporarily to prevent frame drops. Can introduce stuttering."), video_frame_delay_auto);
guiLatency->addSaveFunc([configName, video_frame_delay_auto] { SystemConf::getInstance()->set(configName + ".video_frame_delay_auto", video_frame_delay_auto->getSelected()); });
- // variable refresh rate (freesync, gsync, etc.)
- auto vrr_runloop_enable = std::make_shared<OptionListComponent<std::string>>(mWindow, _("VARIABLE REFRESH RATE (G-SYNC, FREESYNC)"));
- vrr_runloop_enable->addRange({ { _("AUTO"), "" }, { _("ON"), "1" }, { _("OFF"), "0" } }, SystemConf::getInstance()->get(configName + ".vrr_runloop_enable"));
- guiLatency->addWithDescription(_("VARIABLE REFRESH RATE"), _("Don't deviate from core requested timing. G-Sync, FreeSync, HDMI 2.1 VRR."), vrr_runloop_enable);
- guiLatency->addSaveFunc([configName, vrr_runloop_enable] { SystemConf::getInstance()->set(configName + ".vrr_runloop_enable", vrr_runloop_enable->getSelected()); });
-
mWindow->pushGui(guiLatency);
}
@@ -4921,13 +4915,6 @@
s->addOptionList(_("SHOW BATTERY STATUS"), { { _("NO"), "" },{ _("ICON"), "icon" },{ _("ICON AND TEXT"), "text" } }, "ShowBattery", true);
s->addGroup(_("GAMELIST OPTIONS"));
-#if defined(ARCHR)
- // Enable Video Previews
- auto enable_preview = std::make_shared<SwitchComponent>(mWindow);
- enable_preview->setState(Settings::getInstance()->getBool("EnableVideoPreviews"));
- s->addWithLabel(_("SHOW VIDEO PREVIEWS"), enable_preview);
- s->addSaveFunc([enable_preview] { Settings::getInstance()->setBool("EnableVideoPreviews", enable_preview->getState()); });
-#endif
s->addSwitch(_("SHOW FAVORITES ON TOP"), "FavoritesFirst", true, [s] { s->setVariable("reloadAll", true); });
s->addSwitch(_("SHOW HIDDEN FILES"), "ShowHiddenFiles", true, [s] { s->setVariable("reloadAll", true); });
s->addOptionList(_("SHOW FOLDERS"), { { _("always"), "always" },{ _("never") , "never" },{ _("having multiple games"), "having multiple games" } }, "FolderViewMode", true, [s] { s->setVariable("reloadAll", true); });