Files
linux-apfs/arch/x86/include/asm
Roland Dreier dbee8a0aff x86: remove 32-bit versions of readq()/writeq()
The presense of a writeq() implementation on 32-bit x86 that splits the
64-bit write into two 32-bit writes turns out to break the mpt2sas driver
(and in general is risky for drivers as was discussed in
<http://lkml.kernel.org/r/adaab6c1h7c.fsf@cisco.com>).  To fix this,
revert 2c5643b1c5 ("x86: provide readq()/writeq() on 32-bit too") and
follow-on cleanups.

This unfortunately leads to pushing non-atomic definitions of readq() and
write() to various x86-only drivers that in the meantime started using the
definitions in the x86 version of <asm/io.h>.  However as discussed
exhaustively, this is actually the right thing to do, because the right
way to split a 64-bit transaction is hardware dependent and therefore
belongs in the hardware driver (eg mpt2sas needs a spinlock to make sure
no other accesses occur in between the two halves of the access).

Build tested on 32- and 64-bit x86 allmodconfig.

Link: http://lkml.kernel.org/r/x86-32-writeq-is-broken@mdm.bga.com
Acked-by: Hitoshi Mitake <h.mitake@gmail.com>
Cc: Kashyap Desai <Kashyap.Desai@lsi.com>
Cc: Len Brown <lenb@kernel.org>
Cc: Ravi Anand <ravi.anand@qlogic.com>
Cc: Vikas Chaudhary <vikas.chaudhary@qlogic.com>
Cc: Matthew Garrett <mjg@redhat.com>
Cc: Jason Uhlenkott <juhlenko@akamai.com>
Acked-by: James Bottomley <James.Bottomley@parallels.com>
Acked-by: Ingo Molnar <mingo@elte.hu>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2011-05-25 08:39:44 -07:00
..
2011-05-02 14:18:52 +02:00
2011-05-02 14:18:52 +02:00
2011-05-22 11:48:04 +02:00
2011-01-13 08:03:25 -08:00
2011-02-23 22:27:52 +01:00
2009-12-05 09:10:12 -08:00
2011-03-18 10:39:30 +01:00
2011-02-14 12:08:28 +01:00
2011-05-02 17:24:48 +02:00
2011-05-09 12:14:29 -07:00
2010-02-16 21:22:26 -08:00
2011-02-28 18:06:22 +01:00
2011-05-16 14:55:57 -04:00
2011-04-18 09:26:48 -07:00
2010-10-26 16:52:08 -07:00
2010-05-07 17:13:04 -07:00
2011-01-07 10:03:50 -05:00
2011-02-24 14:52:18 +01:00
2010-03-10 13:23:34 +01:00
2010-10-26 16:52:08 -07:00
2011-03-03 12:47:08 +01:00
2011-02-23 22:27:52 +01:00
2010-10-07 14:08:55 +01:00
2010-08-14 22:26:51 +02:00
2011-05-22 08:47:45 -04:00
2011-05-24 14:33:35 +02:00
2010-06-09 11:12:36 +02:00
2010-01-05 15:34:49 +09:00
2010-05-07 17:13:04 -07:00
2011-03-18 10:39:30 +01:00
2011-03-18 10:39:30 +01:00
2010-06-29 12:12:59 +02:00
2011-01-13 17:32:39 -08:00
2011-01-26 10:49:57 +10:00
2011-05-10 15:43:32 -07:00
2011-03-18 10:39:30 +01:00
2010-11-01 15:38:34 -04:00
2010-10-26 16:52:08 -07:00
2011-01-13 17:32:44 -08:00
2011-01-13 17:32:44 -08:00
2011-03-15 15:34:15 -07:00
2011-02-25 16:18:52 +01:00
2010-02-12 09:42:39 -08:00
2011-03-18 10:39:30 +01:00
2011-03-18 10:39:30 +01:00
2011-01-12 11:23:16 +02:00
2011-03-18 10:39:30 +01:00
2011-03-23 19:47:18 -07:00
2011-05-20 12:50:29 -07:00
2011-05-20 12:50:29 -07:00
2011-05-20 12:50:29 -07:00