Doug Anderson
7fb466a7a7
watchdog: dw_wdt: No need for a spinlock
...
Right now the dw_wdt uses a spinlock to protect dw_wdt_open(). The
problem is that while holding the spinlock we call:
-> dw_wdt_set_top()
-> dw_wdt_top_in_seconds()
-> clk_get_rate()
-> clk_prepare_lock()
-> mutex_lock()
Locking a mutex while holding a spinlock is not allowed and leads to
warnings like "BUG: spinlock wrong CPU on CPU#1", among other
problems.
There's no reason to use a spinlock. Only dw_wdt_open() was protected
and the test_and_set_bit() at the start of that function protects us
anyway.
Signed-off-by: Doug Anderson <dianders@chromium.org >
Tested-by: Jisheng Zhang <jszhang@marvell.com >
Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
Reviewed-by: Guenter Roeck <linux@roeck-us.net >
Signed-off-by: Wim Van Sebroeck <wim@iguana.be >
2015-06-22 15:54:31 +02:00
..
2014-10-20 16:21:56 +02:00
2014-10-20 16:21:56 +02:00
2014-01-28 19:07:07 +01:00
2014-09-26 00:00:32 -07:00
2014-10-20 16:21:56 +02:00
2014-10-20 16:21:56 +02:00
2015-03-16 17:03:02 +01:00
2015-06-22 15:53:57 +02:00
2014-10-20 16:21:56 +02:00
2015-02-17 21:33:27 +01:00
2014-10-20 16:21:56 +02:00
2014-10-20 16:21:56 +02:00
2015-04-22 15:27:39 +02:00
2014-10-20 16:21:56 +02:00
2014-10-20 20:44:22 +02:00
2015-01-21 14:52:34 +01:00
2014-10-20 16:21:56 +02:00
2014-03-31 13:22:45 +02:00
2014-10-20 16:21:56 +02:00
2014-03-31 13:23:19 +02:00
2014-03-31 13:23:19 +02:00
2015-02-17 21:33:06 +01:00
2014-10-20 16:21:56 +02:00
2015-03-25 11:49:42 +01:00
2015-06-22 15:53:59 +02:00
2015-06-22 15:54:31 +02:00
2014-10-20 16:21:56 +02:00
2013-11-17 19:38:13 +01:00
2014-10-20 16:21:56 +02:00
2014-10-20 16:21:56 +02:00
2015-02-17 21:33:22 +01:00
2015-02-17 21:32:10 +01:00
2014-03-31 13:22:45 +02:00
2014-10-20 16:21:56 +02:00
2014-03-31 13:31:06 +02:00
2014-10-20 16:21:56 +02:00
2015-06-22 15:54:15 +02:00
2015-06-22 15:54:25 +02:00
2014-03-31 13:26:31 +02:00
2014-03-31 13:26:56 +02:00
2014-10-20 16:21:56 +02:00
2013-11-17 19:38:13 +01:00
2015-02-17 21:32:08 +01:00
2013-11-17 19:38:13 +01:00
2015-04-03 15:25:04 +02:00
2013-11-17 19:38:13 +01:00
2015-02-17 21:34:09 +01:00
2015-06-22 15:54:24 +02:00
2014-10-20 16:21:56 +02:00
2014-10-20 16:21:56 +02:00
2014-10-20 16:21:56 +02:00
2013-11-17 19:38:13 +01:00
2013-11-17 19:38:13 +01:00
2015-06-22 15:53:59 +02:00
2015-06-22 15:54:22 +02:00
2014-10-20 16:21:56 +02:00
2015-01-21 14:52:34 +01:00
2013-11-17 19:38:13 +01:00
2014-10-20 16:21:56 +02:00
2014-10-20 16:21:56 +02:00
2015-03-27 08:47:36 +01:00
2014-03-31 13:22:45 +02:00
2014-10-20 16:21:56 +02:00
2014-10-20 16:21:56 +02:00
2014-10-20 16:21:56 +02:00
2015-04-22 15:28:40 +02:00
2014-10-20 20:43:42 +02:00
2015-06-22 15:54:07 +02:00
2014-12-14 16:10:09 -08:00
2014-03-31 13:31:06 +02:00
2014-01-28 19:07:07 +01:00
2014-03-31 13:23:19 +02:00
2013-11-17 19:38:13 +01:00
2013-11-17 19:38:13 +01:00
2013-11-17 19:38:13 +01:00
2015-04-22 15:30:41 +02:00
2015-04-22 15:27:47 +02:00
2013-11-17 19:38:13 +01:00
2014-10-20 16:21:56 +02:00
2015-02-17 21:32:36 +01:00
2014-10-20 16:21:56 +02:00
2014-10-20 20:55:02 +02:00
2015-02-17 21:32:21 +01:00
2014-12-14 16:10:09 -08:00
2013-11-17 19:38:13 +01:00
2013-11-17 19:38:13 +01:00
2013-11-17 19:38:13 +01:00
2013-11-17 19:38:13 +01:00
2013-11-17 19:38:13 +01:00
2013-11-17 19:38:13 +01:00
2013-11-17 19:38:13 +01:00
2014-03-31 13:27:34 +02:00
2013-12-10 08:48:15 +01:00
2014-10-20 16:21:56 +02:00
2013-11-17 19:38:13 +01:00
2014-10-20 16:21:56 +02:00
2014-10-20 16:21:56 +02:00
2013-11-17 19:38:13 +01:00
2014-03-31 13:31:06 +02:00
2014-06-10 21:47:47 +02:00
2014-10-20 16:21:56 +02:00
2015-06-22 15:53:52 +02:00
2015-04-22 15:30:45 +02:00
2014-11-03 19:53:56 -08:00
2014-10-20 16:21:56 +02:00
2014-11-03 19:53:56 -08:00
2015-02-17 21:32:36 +01:00
2014-10-20 16:21:56 +02:00
2014-10-20 16:21:56 +02:00
2014-06-10 21:38:25 +02:00
2015-02-17 21:33:37 +01:00
2013-11-17 19:38:13 +01:00
2013-11-17 19:38:13 +01:00
2013-11-17 19:38:13 +01:00
2014-01-28 19:07:56 +01:00
2013-11-17 19:38:13 +01:00
2014-03-31 13:28:20 +02:00
2013-11-17 19:38:13 +01:00
2014-03-31 13:22:45 +02:00
2013-11-17 19:38:13 +01:00
2014-03-31 13:23:19 +02:00
2014-10-20 16:21:56 +02:00