Jarek Poplawski 7a67e56fd3 net: Fix oops when splicing skbs from a frag_list. ...

Lennert Buytenhek wrote:
> Since 4fb6699481 ("net: Optimize memory
> usage when splicing from sockets.") I'm seeing this oops (e.g. in
> 2.6.30-rc3) when splicing from a TCP socket to /dev/null on a driver
> (mv643xx_eth) that uses LRO in the skb mode (lro_receive_skb) rather
> than the frag mode:

My patch incorrectly assumed skb->sk was always valid, but for
"frag_listed" skbs we can only use skb->sk of their parent.

Reported-by: Lennert Buytenhek <buytenh@wantstofly.org>
Debugged-by: Lennert Buytenhek <buytenh@wantstofly.org>
Tested-by: Lennert Buytenhek <buytenh@wantstofly.org>
Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

2009-04-30 05:41:19 -07:00

..

datagram.c

net: Avoid extra wakeups of threads blocked in wait_for_packet()

2009-04-28 02:24:21 -07:00

dev_mcast.c

net: Rationalise email address: Network Specific Parts

2008-10-13 19:01:08 -07:00

dev.c

net: Fix GRO for multiple page fragments

2009-04-20 02:20:30 -07:00

drop_monitor.c

Network Drop Monitor: Adding drop monitor implementation & Netlink protocol

2009-03-13 12:09:29 -07:00

dst.c

net: speedup dst_release()

2008-11-14 00:53:54 -08:00

ethtool.c

core: remove pointless conditional before kfree()

2009-03-31 15:06:26 -07:00

fib_rules.c

netlink: change nlmsg_notify() return value logic

2009-02-24 23:18:28 -08:00

filter.c

filter: add SKF_AD_NLATTR_NEST to look for nested attributes

2008-11-20 00:49:27 -08:00

flow.c

netns xfrm: lookup in netns

2008-11-25 17:35:18 -08:00

gen_estimator.c

pkt_sched: gen_estimator: Optimize gen_estimator_active()

2008-11-26 15:24:32 -08:00

gen_stats.c

[NET_SCHED]: Convert packet schedulers from rtnetlink to new netlink API

2008-01-28 15:11:10 -08:00

iovec.c

net: Use standard structures for generic socket address structures.

2008-07-19 22:35:47 -07:00

kmap_skb.h

…

link_watch.c

Revert "net: Fix for initial link state in 2.6.28"

2009-01-05 16:01:51 -08:00

Makefile

Network Drop Monitor: Adding Build changes to enable drop monitor

2009-03-13 12:09:29 -07:00

neighbour.c

neigh: Allow for user space users of the neighbour table

2009-03-04 00:03:08 -08:00

net_namespace.c

netns: Remove net_alive

2009-03-03 01:14:27 -08:00

net-sysfs.c

net: fix warning about non-const string

2009-03-10 05:22:43 -07:00

net-sysfs.h

netns: Fix device renaming for sysfs

2008-05-02 17:00:58 -07:00

net-traces.c

Network Drop Monitor: Add trace declaration for skb frees

2009-03-13 12:09:27 -07:00

netevent.c

…

netpoll.c

netpoll: store local and remote ip in net-endian

2009-03-28 23:55:58 -07:00

pktgen.c

proc 2/2: remove struct proc_dir_entry::owner

2009-03-31 01:14:44 +04:00

request_sock.c

net: convert BUG_TRAP to generic WARN_ON

2008-07-25 21:43:18 -07:00

rtnetlink.c

netlink: change nlmsg_notify() return value logic

2009-02-24 23:18:28 -08:00

scm.c

Merge branch 'master' into next

2008-11-18 18:52:37 +11:00

skb_dma_map.c

net: Fix off-by-one in skb_dma_map

2008-10-12 21:07:34 -07:00

skbuff.c

net: Fix oops when splicing skbs from a frag_list.

2009-04-30 05:41:19 -07:00

sock.c

epoll keyed wakeups: make sockets use keyed wakeups

2009-04-01 08:59:20 -07:00

stream.c

net: Rationalise email address: Network Specific Parts

2008-10-13 19:01:08 -07:00

sysctl_net_core.c

sysctl: fix sparse warning: Should it be static?

2009-02-26 23:13:34 -08:00

user_dma.c

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6

2008-07-26 20:17:56 -07:00

utils.c

net: core: remove unneeded include in net/core/utils.c.

2009-03-26 01:11:48 -07:00