73984137d3
rapidio: dereferencing an error pointer
...
Original patch: https://lkml.org/lkml/2016/8/4/32
If riocm_ch_alloc() fails then we end up dereferencing the error
pointer.
The problem is that we're not unwinding in the reverse order from how we
allocate things so it gets confusing. I've changed this around so now
"ch" is NULL when we are done with it after we call riocm_put_channel().
That way we can check if it's NULL and avoid calling riocm_put_channel()
on it twice.
I renamed err_nodev to err_put_new_ch so that it better reflects what
the goto does.
Then because we had flipping things around, it means we don't neeed to
initialize the pointers to NULL and we can remove an if statement and
pull things in an indent level.
Link: http://lkml.kernel.org/r/20160805152406.20713-1-alexandre.bounine@idt.com
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com >
Signed-off-by: Alexandre Bounine <alexandre.bounine@idt.com >
Cc: Matt Porter <mporter@kernel.crashing.org >
Cc: Andre van Herk <andre.van.herk@prodrive-technologies.com >
Cc: Barry Wood <barry.wood@idt.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2016-08-10 16:40:56 -07:00
0b9364b5cf
rapidio/switches: add driver for IDT gen3 switches
...
Add RapidIO switch driver for IDT Gen3 switch devices: RXS1632 and
RXS2448.
[alexandre.bounine@idt.com: fixup for original driver patch]
Link: http://lkml.kernel.org/r/1469137596-18241-1-git-send-email-alexandre.bounine@idt.com
Link: http://lkml.kernel.org/r/1469125134-16523-14-git-send-email-alexandre.bounine@idt.com
Signed-off-by: Alexandre Bounine <alexandre.bounine@idt.com >
Tested-by: Barry Wood <barry.wood@idt.com >
Cc: Matt Porter <mporter@kernel.crashing.org >
Cc: Andre van Herk <andre.van.herk@prodrive-technologies.com >
Cc: Barry Wood <barry.wood@idt.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2016-08-02 19:35:38 -04:00
1ae842de1d
rapidio: modify for rev.3 specification changes
...
Implement changes made in RapidIO specification rev.3 to LP-Serial Physical
Layer register definitions:
- use per-port register offset calculations based on LP-Serial Extended
Features Block (EFB) Register Map type (I or II) with different
per-port offset step (0x20 vs 0x40 respectfully).
- remove deprecated Parallel Physical layer definitions and related
code.
[alexandre.bounine@idt.com: fix DocBook warning for gen3 update]
Link: http://lkml.kernel.org/r/1469191173-19338-1-git-send-email-alexandre.bounine@idt.com
Link: http://lkml.kernel.org/r/1469125134-16523-12-git-send-email-alexandre.bounine@idt.com
Signed-off-by: Alexandre Bounine <alexandre.bounine@idt.com >
Tested-by: Barry Wood <barry.wood@idt.com >
Cc: Matt Porter <mporter@kernel.crashing.org >
Cc: Andre van Herk <andre.van.herk@prodrive-technologies.com >
Cc: Barry Wood <barry.wood@idt.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2016-08-02 19:35:37 -04:00
a057a52e94
rapidio: change inbound window size type to u64
...
Current definition of map_inb() mport operations callback uses u32 type
to specify required inbound window (IBW) size. This is limiting factor
because existing hardware - tsi721 and fsl_rio, both support IBW size up
to 16GB.
Changing type of size parameter to u64 to allow IBW size configurations
larger than 4GB.
[alexandre.bounine@idt.com: remove compiler warning about size of constant]
Link: http://lkml.kernel.org/r/20160802184856.2566-1-alexandre.bounine@idt.com
Link: http://lkml.kernel.org/r/1469125134-16523-11-git-send-email-alexandre.bounine@idt.com
Signed-off-by: Alexandre Bounine <alexandre.bounine@idt.com >
Cc: Matt Porter <mporter@kernel.crashing.org >
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org >
Cc: Michael Ellerman <mpe@ellerman.id.au >
Cc: Andre van Herk <andre.van.herk@prodrive-technologies.com >
Cc: Barry Wood <barry.wood@idt.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2016-08-02 19:35:37 -04:00
60e377b5c1
rapidio/idt_gen2: fix locking warning
...
Fix lockdep warning during device probing: move sysfs initialization out
of code protected by a spin lock.
Link: http://lkml.kernel.org/r/1469125134-16523-10-git-send-email-alexandre.bounine@idt.com
Signed-off-by: Alexandre Bounine <alexandre.bounine@idt.com >
Cc: Matt Porter <mporter@kernel.crashing.org >
Cc: Andre van Herk <andre.van.herk@prodrive-technologies.com >
Cc: Barry Wood <barry.wood@idt.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2016-08-02 19:35:36 -04:00
06e1b2497c
rapidio: fix error handling in mbox request/release functions
...
Add checking for error code returned by HW-specific mbox open routines.
Ensure that resources are properly release if failed.
This patch is applicable to kernel versions starting from v2.6.15.
Link: http://lkml.kernel.org/r/1469125134-16523-9-git-send-email-alexandre.bounine@idt.com
Signed-off-by: Alexandre Bounine <alexandre.bounine@idt.com >
Cc: Matt Porter <mporter@kernel.crashing.org >
Cc: Andre van Herk <andre.van.herk@prodrive-technologies.com >
Cc: Barry Wood <barry.wood@idt.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2016-08-02 19:35:36 -04:00
f5485eb0b6
rapidio/tsi721_dma: advance queue processing from transfer submit call
...
Add advancing transfer queue immediately from transfer submit call. DMA
performance improvement: This will start transfer without waiting for
'issue_pending' command if there is no DMA transfer in progress.
Link: http://lkml.kernel.org/r/1469125134-16523-8-git-send-email-alexandre.bounine@idt.com
Signed-off-by: Alexandre Bounine <alexandre.bounine@idt.com >
Cc: Matt Porter <mporter@kernel.crashing.org >
Cc: Andre van Herk <andre.van.herk@prodrive-technologies.com >
Cc: Barry Wood <barry.wood@idt.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2016-08-02 19:35:35 -04:00
e519685de3
rapidio/tsi721: add messaging mbox selector parameter
...
Add module parameter to allow load time configuration of available
RapidIO messaging mailboxes (MBOX1 - MBOX4).
Having a messaging MBOX selector mask allows to define which MBOXes are
controlled by the mport device driver and reserve some of them for
direct use by other drivers.
Link: http://lkml.kernel.org/r/1469125134-16523-7-git-send-email-alexandre.bounine@idt.com
Signed-off-by: Alexandre Bounine <alexandre.bounine@idt.com >
Tested-by: Barry Wood <barry.wood@idt.com >
Cc: Matt Porter <mporter@kernel.crashing.org >
Cc: Andre van Herk <andre.van.herk@prodrive-technologies.com >
Cc: Barry Wood <barry.wood@idt.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2016-08-02 19:35:34 -04:00
cb782cdd2f
rapidio/tsi721: add PCIe MRRS override parameter
...
Add PCIe Maximum Read Request Size (MRRS) adjustment parameter to allow
users to override configuration register value set during PCIe bus
initialization.
Performance of Tsi721 device as PCIe bus master can be improved if MRRS
is set to its maximum value (4096 bytes). Some platforms have
limitations for supported MRRS and therefore the default value should be
preserved, unless it is known that given platform supports full set of
MRRS values defined by PCI Express specification.
Link: http://lkml.kernel.org/r/1469125134-16523-6-git-send-email-alexandre.bounine@idt.com
Signed-off-by: Alexandre Bounine <alexandre.bounine@idt.com >
Cc: Matt Porter <mporter@kernel.crashing.org >
Cc: Andre van Herk <andre.van.herk@prodrive-technologies.com >
Cc: Barry Wood <barry.wood@idt.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2016-08-02 19:35:34 -04:00
4498c31adf
rapidio/tsi721_dma: add channel mask and queue size parameters
...
Add module parameters to allow load time configuration of DMA channels.
Depending on application, performance of DMA data transfers can benefit
from adjusted sizes of buffer descriptor ring and/or transaction
requests queue.
Having HW DMA channel selector mask allows to define which channels
(from seven available) are controlled by the mport device driver and
reserve some of them for direct use by other drivers.
Link: http://lkml.kernel.org/r/1469125134-16523-5-git-send-email-alexandre.bounine@idt.com
Signed-off-by: Alexandre Bounine <alexandre.bounine@idt.com >
Tested-by: Barry Wood <barry.wood@idt.com >
Cc: Matt Porter <mporter@kernel.crashing.org >
Cc: Andre van Herk <andre.van.herk@prodrive-technologies.com >
Cc: Barry Wood <barry.wood@idt.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2016-08-02 19:35:33 -04:00
f8e3a68c05
rapidio: fix return value description for dma_prep functions
...
Update return value description for rio_dma_prep_... functions to
include error-valued pointer that can be returned by HW mport device
drivers. Return values from these functions must be checked using
IS_ERR_OR_NULL macro.
This patch is applicable to kernel versions starting from v4.6-rc1.
Link: http://lkml.kernel.org/r/1469125134-16523-4-git-send-email-alexandre.bounine@idt.com
Signed-off-by: Alexandre Bounine <alexandre.bounine@idt.com >
Cc: Matt Porter <mporter@kernel.crashing.org >
Cc: Andre van Herk <andre.van.herk@prodrive-technologies.com >
Cc: Barry Wood <barry.wood@idt.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2016-08-02 19:35:33 -04:00
ea87b8e1f7
rapidio: remove unnecessary 0x prefixes before %pa extension uses
...
Patch series "RapidIO subsystem updates".
This set of patches contains RapidIO subsystem fixes and updates that
have been made since kernel v4.6. The most significant update brings
changes related to the latest revision of RapidIO specification
(rev.3.x) and introduction of next generation of RapidIO switches by IDT
(RXS1632 and RXS2448).
This patch (of 13):
This is RapidIO part of the original patch submitted by Joe Perches.
(see: https://lkml.org/lkml/2016/3/5/19 )
Since commit 3cab1e7112http://lkml.kernel.org/r/1469125134-16523-2-git-send-email-alexandre.bounine@idt.com
Signed-off-by: Joe Perches <joe@perches.com >
Signed-off-by: Alexandre Bounine <alexandre.bounine@idt.com >
Cc: Matt Porter <mporter@kernel.crashing.org >
Cc: Andre van Herk <andre.van.herk@prodrive-technologies.com >
Cc: Barry Wood <barry.wood@idt.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2016-08-02 19:35:32 -04:00
b6e8d4aa11
rapidio: add RapidIO channelized messaging driver
...
Add channelized messaging driver to support native RapidIO messaging
exchange between multiple senders/recipients on devices that use kernel
RapidIO subsystem services.
This device driver is the result of collaboration within the RapidIO.org
Software Task Group (STG) between Texas Instruments, Prodrive
Technologies, Nokia Networks, BAE and IDT. Additional input was
received from other members of RapidIO.org.
The objective was to create a character mode driver interface which
exposes messaging capabilities of RapidIO endpoint devices (mports)
directly to applications, in a manner that allows the numerous and
varied RapidIO implementations to interoperate.
This char mode device driver allows user-space applications to setup
messaging communication channels using single shared RapidIO messaging
mailbox.
By default this driver uses RapidIO MBOX_1 (MBOX_0 is reserved for use by
RIONET Ethernet emulation driver).
[weiyj.lk@gmail.com: rapidio/rio_cm: fix return value check in riocm_init()]
Link: http://lkml.kernel.org/r/1469198221-21970-1-git-send-email-alexandre.bounine@idt.com
Link: http://lkml.kernel.org/r/1468952862-18056-1-git-send-email-alexandre.bounine@idt.com
Signed-off-by: Alexandre Bounine <alexandre.bounine@idt.com >
Tested-by: Barry Wood <barry.wood@idt.com >
Cc: Matt Porter <mporter@kernel.crashing.org >
Cc: Aurelien Jacquiot <a-jacquiot@ti.com >
Cc: Andre van Herk <andre.van.herk@prodrive-technologies.com >
Cc: Barry Wood <barry.wood@idt.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2016-08-02 19:35:31 -04:00
4e1016dac1
rapidio/mport_cdev: fix uapi type definitions
...
Fix problems in uapi definitions reported by Gabriel Laskar: (see
https://lkml.org/lkml/2016/4/5/205 for details)
- move public header file rio_mport_cdev.h to include/uapi/linux directory
- change types in data structures passed as IOCTL parameters
- improve parameter checking in some IOCTL service routines
Signed-off-by: Alexandre Bounine <alexandre.bounine@idt.com >
Reported-by: Gabriel Laskar <gabriel@lse.epita.fr >
Tested-by: Barry Wood <barry.wood@idt.com >
Cc: Gabriel Laskar <gabriel@lse.epita.fr >
Cc: Matt Porter <mporter@kernel.crashing.org >
Cc: Aurelien Jacquiot <a-jacquiot@ti.com >
Cc: Andre van Herk <andre.van.herk@prodrive-technologies.com >
Cc: Barry Wood <barry.wood@idt.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2016-05-05 17:38:53 -07:00
99f23c2cde
rapidio: fix potential NULL pointer dereference
...
The change fixes improper check for a returned error value by
class_create() function, which on error returns ERR_PTR() value, thus the
original check always results in a dead code on error path.
Signed-off-by: Vladimir Zapolskiy <vz@mleia.com >
Signed-off-by: Alexandre Bounine <alexandre.bounine@idt.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2016-04-28 19:34:04 -07:00
cb107161df
Convert straggling drivers to new six-argument get_user_pages()
...
Commit d4edcf0d56cde70140fetorvalds@linux-foundation.org >
2016-04-02 18:35:05 -05:00
e8de370188
rapidio: add mport char device driver
...
Add mport character device driver to provide user space interface to
basic RapidIO subsystem operations.
See included Documentation/rapidio/mport_cdev.txt for more details.
[akpm@linux-foundation.org: fix printk warning on i386]
[dan.carpenter@oracle.com: mport_cdev: fix some error codes]
Signed-off-by: Alexandre Bounine <alexandre.bounine@idt.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Tested-by: Barry Wood <barry.wood@idt.com>
Cc: Matt Porter <mporter@kernel.crashing.org>
Cc: Aurelien Jacquiot <a-jacquiot@ti.com>
Cc: Andre van Herk <andre.van.herk@prodrive-technologies.com>
Cc: Barry Wood <barry.wood@idt.com>
Cc: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2016-03-22 15:36:02 -07:00
458bdf6e39
rapidio/tsi721_dma: fix hardware error handling
...
Add DMA channel re-initialization after an error to avoid termination of
all pending transfer requests.
Signed-off-by: Alexandre Bounine <alexandre.bounine@idt.com >
Reported-by: Barry Wood <barry.wood@idt.com >
Tested-by: Barry Wood <barry.wood@idt.com >
Cc: Matt Porter <mporter@kernel.crashing.org >
Cc: Aurelien Jacquiot <a-jacquiot@ti.com >
Cc: Andre van Herk <andre.van.herk@prodrive-technologies.com >
Cc: Barry Wood <barry.wood@idt.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2016-03-22 15:36:02 -07:00
e680b672a2
rapidio/tsi721_dma: fix synchronization issues
...
Fix synchronization issues found during testing using multiple DMA
transfer requests to the same channel:
- lost MSI-X interrupt notifications
- non-synchronized attempts to start DMA channel HW resulting in error
message from the driver
- cookie tracking/update race conditions resulting in incorrect DMA
transfer status report
Signed-off-by: Alexandre Bounine <alexandre.bounine@idt.com >
Reported-by: Barry Wood <barry.wood@idt.com >
Tested-by: Barry Wood <barry.wood@idt.com >
Cc: Matt Porter <mporter@kernel.crashing.org >
Cc: Aurelien Jacquiot <a-jacquiot@ti.com >
Cc: Andre van Herk <andre.van.herk@prodrive-technologies.com >
Cc: Barry Wood <barry.wood@idt.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2016-03-22 15:36:02 -07:00
8347245750
rapidio/tsi721_dma: update error reporting from prep_sg callback
...
Switch to returning error-valued pointer instead of simple NULL pointer.
This allows to properly identify situation when request queue is full
and therefore gives to upper layer an option to retry operation later.
Signed-off-by: Alexandre Bounine <alexandre.bounine@idt.com >
Cc: Matt Porter <mporter@kernel.crashing.org >
Cc: Aurelien Jacquiot <a-jacquiot@ti.com >
Cc: Andre van Herk <andre.van.herk@prodrive-technologies.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2016-03-22 15:36:02 -07:00
72d8a0d230
rapidio/tsi721: add filtered debug output
...
Replace "all-or-nothing" debug output with controlled debug output using
functional block masks. This allows run time control of debug messages
through 'dbg_level' module parameter.
Signed-off-by: Alexandre Bounine <alexandre.bounine@idt.com >
Cc: Matt Porter <mporter@kernel.crashing.org >
Cc: Aurelien Jacquiot <a-jacquiot@ti.com >
Cc: Andre van Herk <andre.van.herk@prodrive-technologies.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2016-03-22 15:36:02 -07:00
1679e8dabf
rapidio/tsi721: add outbound windows mapping support
...
Add device-specific callback functions to support outbound windows
mapping and release.
Signed-off-by: Alexandre Bounine <alexandre.bounine@idt.com >
Cc: Matt Porter <mporter@kernel.crashing.org >
Cc: Aurelien Jacquiot <a-jacquiot@ti.com >
Cc: Andre van Herk <andre.van.herk@prodrive-technologies.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2016-03-22 15:36:02 -07:00
93bdaca501
rapidio: add outbound window support
...
Add RapidIO controller (mport) outbound window configuration operations.
This patch is a part of the original patch submitted by Li Yang:
https://lists.ozlabs.org/pipermail/linuxppc-dev/2009-April/071210.html
For some reason the original part was not applied to mainline code
tree. The inbound window mapping part has been applied later during
tsi721 mport driver submission. Now goes the second part with
corresponding HW support.
Signed-off-by: Alexandre Bounine <alexandre.bounine@idt.com >
Cc: Matt Porter <mporter@kernel.crashing.org >
Cc: Li Yang <leoli@freescale.com >
Cc: Aurelien Jacquiot <a-jacquiot@ti.com >
Cc: Andre van Herk <andre.van.herk@prodrive-technologies.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2016-03-22 15:36:02 -07:00
2ece1caf66
rapidio/tsi721: fix locking in OB_MSG processing
...
- Add spinlock protection into outbound message queuing routine.
- Change outbound message interrupt handler to avoid deadlock when
calling registered callback routine.
- Allow infinite retries for outbound messages to avoid retry threshold
error signaling in systems with nodes that have slow message receive
queue processing.
Signed-off-by: Alexandre Bounine <alexandre.bounine@idt.com >
Cc: Matt Porter <mporter@kernel.crashing.org >
Cc: Aurelien Jacquiot <a-jacquiot@ti.com >
Cc: Andre van Herk <andre.van.herk@prodrive-technologies.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2016-03-22 15:36:02 -07:00
9a0b062742
rapidio: add global inbound port write interfaces
...
Add new Port Write handler registration interfaces that attach PW
handlers to local mport device objects. This is different from old
interface that attaches PW callback to individual RapidIO device. The
new interfaces are intended for use for common event handling (e.g.
hot-plug notifications) while the old interface is available for
individual device drivers.
This patch is based on patch proposed by Andre van Herk but preserves
existing per-device interface and adds lock protection for list
handling.
Signed-off-by: Alexandre Bounine <alexandre.bounine@idt.com >
Cc: Matt Porter <mporter@kernel.crashing.org >
Cc: Aurelien Jacquiot <a-jacquiot@ti.com >
Cc: Andre van Herk <andre.van.herk@prodrive-technologies.com >
Cc: Stephen Rothwell <sfr@canb.auug.org.au >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2016-03-22 15:36:02 -07:00
Dan Carpenter
Alexandre Bounine
Joe Perches
Vladimir Zapolskiy
Linus Torvalds