Alexey Starikovskiy
c04209a794
ACPI: EC: Enable boot EC before bus_scan
...
Some _STA methods called during bus_scan() might require EC region handler,
which might be enabled later in the scan.
Enable it explicitly before scan to avoid errors.
Reference: http://bugzilla.kernel.org/show_bug.cgi?id=9627
Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de >
Signed-off-by: Len Brown <len.brown@intel.com >
2008-01-01 14:12:55 -05:00
Len Brown
a3f095ade0
Pull bugzilla-9327 into release branch
...
Conflicts:
drivers/acpi/ec.c
Signed-off-by: Len Brown <len.brown@intel.com >
2007-11-20 20:07:49 -05:00
Alexey Starikovskiy
e790cc8bbb
ACPI: EC: Workaround for optimized controllers (version 3)
...
Some controllers fail to send confirmation GPE after address or data write.
Detect this and don't expect such confirmation in future.
This is a generalization of previous workaround
(66c5f4e736 ), which did only read address.
Reference: http://bugzilla.kernel.org/show_bug.cgi?id=9327
Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de >
Tested-by: Romano Giannetti <romano.giannetti@gmail.com >
Tested-by: Mats Johannesson
Signed-off-by: Len Brown <len.brown@intel.com >
2007-11-20 20:06:15 -05:00
Márton Németh
3ebe08a749
ACPI: EC: use printk_ratelimit(), add some DEBUG mode messages
...
Sometimes it is usefull to see raw protocol dump.
Uncomment '#define DEBUG' at the beginning of file to make EC
really verbose.
Signed-off-by: Márton Németh <nm127@freemail.hu >
Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de >
Signed-off-by: Len Brown <len.brown@intel.com >
2007-11-20 20:04:39 -05:00
Len Brown
0af2f653c5
Revert "ACPI: EC: Workaround for optimized controllers"
...
This reverts commit f2d68935ba .
2007-11-20 19:59:08 -05:00
Len Brown
e6532b8883
Pull fluff into release branch
...
Conflicts:
drivers/acpi/ec.c
Signed-off-by: Len Brown <len.brown@intel.com >
2007-11-20 01:21:47 -05:00
Len Brown
22201f7402
Pull bugzilla-9327 into release branch
2007-11-20 01:18:19 -05:00
Joe Perches
4fdb2a05ef
ACPI: Add missing spaces to printk format
...
Signed-off-by: Joe Perches <joe@perches.com >
Signed-off-by: Len Brown <len.brown@intel.com >
2007-11-19 21:53:32 -05:00
Alexey Starikovskiy
5870a8cd23
ACPI: EC: Don't init EC early if it has no _INI
...
Option to init EC early inserted to handle #8598 ASUS problem,
introduced several others.
EC driver in this particular case has fake _INI method, not present on
other machines, which don't need or break from this workaround, so lets use
its presence as a flag for early init.
http://bugzilla.kernel.org/show_bug.cgi?id=9262
http://bugzilla.kernel.org/show_bug.cgi?id=8598
https://bugzilla.novell.com/show_bug.cgi?id=334806
Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de >
Signed-off-by: Len Brown <len.brown@intel.com >
2007-11-19 12:20:48 -05:00
Alexey Starikovskiy
f2d68935ba
ACPI: EC: Workaround for optimized controllers
...
Some controllers fail to send confirmation GPE after address write.
Detect this and don't expect such confirmation in future.
This is a generalization of previous workaround
(66c5f4e736 ), which did only read address.
http://bugzilla.kernel.org/show_bug.cgi?id=9327
Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de >
Tested-by: Romano Giannetti <romano.giannetti@gmail.com >
Signed-off-by: Len Brown <len.brown@intel.com >
2007-11-19 01:05:01 -05:00
Adrian Bunk
1544fdbc85
ACPI: EC: fix use-after-free
...
This patch fixes a use-after-free introduced by
commit 30c08574da
(ACPI: EC: Add new query handler to list head)
Spotted by the Coverity checker.
Signed-off-by: Adrian Bunk <bunk@kernel.org >
Acked-by: Alexey Starikovskiy <astarikovskiy@suse.de >
Signed-off-by: Len Brown <len.brown@intel.com >
2007-10-25 16:38:02 -04:00
Alexey Starikovskiy
95b937e3f5
ACPI: EC: Output changes to operational mode
...
Insert printk() for every change in operational mode.
Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de >
Acked-by: Rafael J. Wysocki <rjw@sisk.pl >
Signed-off-by: Len Brown <len.brown@intel.com >
2007-10-25 16:31:31 -04:00
Alexey Starikovskiy
66c5f4e736
ACPI: EC: Add workaround for "optimized" controllers
...
Some controllers do not send interrupts for OBF=1 event, but send
them for IBF=0. Add workaround for them.
Reference: http://bugzilla.kernel.org/show_bug.cgi?id=8459
Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de >
Signed-off-by: Len Brown <len.brown@intel.com >
2007-10-25 16:31:31 -04:00
Alexey Starikovskiy
1c55053c21
ACPI: EC: Don't re-enable GPE for each transaction.
...
With the auto selection of operation mode, absence of GPEs does not
really degrade performance, so let PM code to handle
enabling/disabling GPEs.
This is a revert of 5d57a6a55e ,
which was meant to be temporary.
Reference: http://bugzilla.kernel.org/show_bug.cgi?id=7977
Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de >
Acked-by: Rafael J. Wysocki <rjw@sisk.pl >
Signed-off-by: Len Brown <len.brown@intel.com >
2007-10-25 16:31:31 -04:00
Alexey Starikovskiy
7843932ac4
ACPI: EC: auto select interrupt mode
...
Start in POLL mode, and if we receive confirmation GPE,
switch to INT mode.
If confirmations are not sent, switch back to POLL.
Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de >
Signed-off-by: Len Brown <len.brown@intel.com >
2007-10-25 16:31:31 -04:00
Alexey Starikovskiy
0c5d31f48e
ACPI: EC: Don't expect interrupt after last read
...
There is no interrupt after last read according to spec, so
don't set bit that we are expecting one.
Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de >
Signed-off-by: Len Brown <len.brown@intel.com >
2007-10-25 16:31:31 -04:00
Alexey Starikovskiy
080e412cc0
ACPI: EC: Replace atomic variables with bits
...
Number of flags is about to be increased, so it is better to
put them all into bits.
No functional changes.
Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de >
Acked-by: Rafael J. Wysocki <rjw@sisk.pl >
Signed-off-by: Len Brown <len.brown@intel.com >
2007-10-25 16:31:31 -04:00
Len Brown
731aa5fd99
Pull bugzilla-8709 into release branch
2007-10-10 00:30:55 -04:00
Alexey Starikovskiy
30c08574da
ACPI: EC: Add new query handler to list head.
...
Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de >
Signed-off-by: Len Brown <len.brown@intel.com >
2007-09-27 15:50:22 -04:00
Alexey Starikovskiy
4c61106066
ACPI: EC: Drop ECDT-based boot_ec as soon as we find DSDT-based one.
...
ASUS notebooks have numerous problems with EC initialization
This patch tries to work around three known issues reported
in bugzilla 8598, 8709 and 8909/8919.
Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de >
Signed-off-by: Len Brown <len.brown@intel.com >
2007-09-05 19:56:38 -04:00
Alexey Starikovskiy
2d8348b429
ACPI: EC: Check if boot_ec was really found in DSDT
...
acpi_get_devices() returns success if it did not find any device.
We have to check for this case.
Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de >
Tested-by: Daniel Ritz <daniel.ritz-ml@swissonline.ch >
Tested-by: Luca <kronos.it@gmail.com >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-08-30 22:20:13 -07:00
Alexey Starikovskiy
f9319f903f
ACPI: EC: revert fix for bugzilla 8709
...
This is a manual revert of 7c010de750 ,
a fix that broke another ASUS in 8909 and 8919.
Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de >
Signed-off-by: Len Brown <len.brown@intel.com >
2007-08-24 00:30:59 -04:00
Alexey Starikovskiy
c019b19330
ACPI: EC: Fix "no battery" regression
...
Restore deleted call to register query methods.
http://bugzilla.kernel.org/show_bug.cgi?id=8886
Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de >
Signed-off-by: Len Brown <len.brown@intel.com >
2007-08-14 01:03:42 -04:00
Alexey Starikovskiy
199e9e7d11
ACPI EC: remove potential deadlock from EC
...
Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Len Brown <len.brown@intel.com >
2007-08-11 22:26:24 -04:00
Meelis Roos
0a52450998
ACPI: EC: fix run-together printk lines
...
Signed-off-by: Meelis Roos <mroos@linux.ee >
Signed-off-by: Len Brown <len.brown@intel.com >
2007-08-03 22:42:02 -04:00