You've already forked linux-apfs
mirror of
https://github.com/linux-apfs/linux-apfs.git
synced 2026-05-01 15:00:59 -07:00
KVM: Convert i8254/i8259 locks to raw_spinlocks
The i8254/i8259 locks need to be real spinlocks on preempt-rt. Convert them to raw_spinlock. No change for !RT kernels. Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Avi Kivity <avi@redhat.com>
This commit is contained in:
committed by
Marcelo Tosatti
parent
e424e19183
commit
fa8273e954
+16
-15
@@ -44,18 +44,19 @@ static void pic_clear_isr(struct kvm_kpic_state *s, int irq)
|
||||
* Other interrupt may be delivered to PIC while lock is dropped but
|
||||
* it should be safe since PIC state is already updated at this stage.
|
||||
*/
|
||||
spin_unlock(&s->pics_state->lock);
|
||||
raw_spin_unlock(&s->pics_state->lock);
|
||||
kvm_notify_acked_irq(s->pics_state->kvm, SELECT_PIC(irq), irq);
|
||||
spin_lock(&s->pics_state->lock);
|
||||
raw_spin_lock(&s->pics_state->lock);
|
||||
}
|
||||
|
||||
void kvm_pic_clear_isr_ack(struct kvm *kvm)
|
||||
{
|
||||
struct kvm_pic *s = pic_irqchip(kvm);
|
||||
spin_lock(&s->lock);
|
||||
|
||||
raw_spin_lock(&s->lock);
|
||||
s->pics[0].isr_ack = 0xff;
|
||||
s->pics[1].isr_ack = 0xff;
|
||||
spin_unlock(&s->lock);
|
||||
raw_spin_unlock(&s->lock);
|
||||
}
|
||||
|
||||
/*
|
||||
@@ -156,9 +157,9 @@ static void pic_update_irq(struct kvm_pic *s)
|
||||
|
||||
void kvm_pic_update_irq(struct kvm_pic *s)
|
||||
{
|
||||
spin_lock(&s->lock);
|
||||
raw_spin_lock(&s->lock);
|
||||
pic_update_irq(s);
|
||||
spin_unlock(&s->lock);
|
||||
raw_spin_unlock(&s->lock);
|
||||
}
|
||||
|
||||
int kvm_pic_set_irq(void *opaque, int irq, int level)
|
||||
@@ -166,14 +167,14 @@ int kvm_pic_set_irq(void *opaque, int irq, int level)
|
||||
struct kvm_pic *s = opaque;
|
||||
int ret = -1;
|
||||
|
||||
spin_lock(&s->lock);
|
||||
raw_spin_lock(&s->lock);
|
||||
if (irq >= 0 && irq < PIC_NUM_PINS) {
|
||||
ret = pic_set_irq1(&s->pics[irq >> 3], irq & 7, level);
|
||||
pic_update_irq(s);
|
||||
trace_kvm_pic_set_irq(irq >> 3, irq & 7, s->pics[irq >> 3].elcr,
|
||||
s->pics[irq >> 3].imr, ret == 0);
|
||||
}
|
||||
spin_unlock(&s->lock);
|
||||
raw_spin_unlock(&s->lock);
|
||||
|
||||
return ret;
|
||||
}
|
||||
@@ -203,7 +204,7 @@ int kvm_pic_read_irq(struct kvm *kvm)
|
||||
int irq, irq2, intno;
|
||||
struct kvm_pic *s = pic_irqchip(kvm);
|
||||
|
||||
spin_lock(&s->lock);
|
||||
raw_spin_lock(&s->lock);
|
||||
irq = pic_get_irq(&s->pics[0]);
|
||||
if (irq >= 0) {
|
||||
pic_intack(&s->pics[0], irq);
|
||||
@@ -228,7 +229,7 @@ int kvm_pic_read_irq(struct kvm *kvm)
|
||||
intno = s->pics[0].irq_base + irq;
|
||||
}
|
||||
pic_update_irq(s);
|
||||
spin_unlock(&s->lock);
|
||||
raw_spin_unlock(&s->lock);
|
||||
|
||||
return intno;
|
||||
}
|
||||
@@ -442,7 +443,7 @@ static int picdev_write(struct kvm_io_device *this,
|
||||
printk(KERN_ERR "PIC: non byte write\n");
|
||||
return 0;
|
||||
}
|
||||
spin_lock(&s->lock);
|
||||
raw_spin_lock(&s->lock);
|
||||
switch (addr) {
|
||||
case 0x20:
|
||||
case 0x21:
|
||||
@@ -455,7 +456,7 @@ static int picdev_write(struct kvm_io_device *this,
|
||||
elcr_ioport_write(&s->pics[addr & 1], addr, data);
|
||||
break;
|
||||
}
|
||||
spin_unlock(&s->lock);
|
||||
raw_spin_unlock(&s->lock);
|
||||
return 0;
|
||||
}
|
||||
|
||||
@@ -472,7 +473,7 @@ static int picdev_read(struct kvm_io_device *this,
|
||||
printk(KERN_ERR "PIC: non byte read\n");
|
||||
return 0;
|
||||
}
|
||||
spin_lock(&s->lock);
|
||||
raw_spin_lock(&s->lock);
|
||||
switch (addr) {
|
||||
case 0x20:
|
||||
case 0x21:
|
||||
@@ -486,7 +487,7 @@ static int picdev_read(struct kvm_io_device *this,
|
||||
break;
|
||||
}
|
||||
*(unsigned char *)val = data;
|
||||
spin_unlock(&s->lock);
|
||||
raw_spin_unlock(&s->lock);
|
||||
return 0;
|
||||
}
|
||||
|
||||
@@ -520,7 +521,7 @@ struct kvm_pic *kvm_create_pic(struct kvm *kvm)
|
||||
s = kzalloc(sizeof(struct kvm_pic), GFP_KERNEL);
|
||||
if (!s)
|
||||
return NULL;
|
||||
spin_lock_init(&s->lock);
|
||||
raw_spin_lock_init(&s->lock);
|
||||
s->kvm = kvm;
|
||||
s->pics[0].elcr_mask = 0xf8;
|
||||
s->pics[1].elcr_mask = 0xde;
|
||||
|
||||
Reference in New Issue
Block a user