apfs/linux-apfs
0
0
Fork 0
mirror of https://github.com/linux-apfs/linux-apfs.git synced 2026-05-01 15:00:59 -07:00
Code Issues Packages Projects Releases Wiki Activity

PM: Avoid calling kfree() under spinlock in dev_pm_put_subsys_data()

Browse Source 
Fix dev_pm_put_subsys_data() so that it doesn't call kfree() under
a spinlock and make it return 1 whenever it leaves NULL
power.subsys_data (regardless of the reason).

Signed-off-by: Shuah Khan <shuah.kh@samsung.com>
Reviewed-by: Pavel Machek <pavel@ucw.cz>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
This commit is contained in:
Shuah Khan
2013-05-08 01:14:32 +02:00
committed by Rafael J. Wysocki
parent f722406faa
commit d5e1670afe
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/base/power/common.c
+6 -6
View File
@@ -61,24 +61,24 @@ EXPORT_SYMBOL_GPL(dev_pm_get_subsys_data);
int dev_pm_put_subsys_data(struct device *dev) int dev_pm_put_subsys_data(struct device *dev)
{ {
struct pm_subsys_data *psd; struct pm_subsys_data *psd;
int ret = 0; int ret = 1;
spin_lock_irq(&dev->power.lock); spin_lock_irq(&dev->power.lock);
psd = dev_to_psd(dev); psd = dev_to_psd(dev);
if (!psd) { if (!psd)
ret = -EINVAL;
goto out; goto out;
}
if (--psd->refcount == 0) { if (--psd->refcount == 0) {
dev->power.subsys_data = NULL; dev->power.subsys_data = NULL;
kfree(psd); } else {
ret = 1; psd = NULL;
ret = 0;
} }
out: out:
spin_unlock_irq(&dev->power.lock); spin_unlock_irq(&dev->power.lock);
kfree(psd);
return ret; return ret;
} }