apfs/linux-apfs
0
0
Fork 0
mirror of https://github.com/linux-apfs/linux-apfs.git synced 2026-05-01 15:00:59 -07:00
Code Issues Packages Projects Releases Wiki Activity

spi: loopback-test: fix potential integer overflow on multiple

Browse Source 
A multiplication of 8U * xfer-len with the type of a 32 bit unsigned int
is evaluated using 32 bit arithmetic and then used in a context that
expects an expression of type unsigned long long (64 bits).  Avoid any
potential overflow by casting BITS_PER_BYTE to unsigned long long.

Detected by CoverityScan, CID#1419691 ("Unintentional integer overflow")

Fixes: ea9936f324 ("spi: loopback-test: add elapsed time check")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Colin Ian King
2017-03-20 13:58:05 +00:00
committed by Mark Brown
parent 8687113e15
commit d2c14c64d6
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/spi/spi-loopback-test.c
+2 -1
View File
@@ -508,7 +508,8 @@ static int spi_test_check_elapsed_time(struct spi_device *spi,
for (i = 0; i < test->transfer_count; i++) { for (i = 0; i < test->transfer_count; i++) {
struct spi_transfer *xfer = test->transfers + i; struct spi_transfer *xfer = test->transfers + i;
unsigned long long nbits = BITS_PER_BYTE * xfer->len; unsigned long long nbits = (unsigned long long)BITS_PER_BYTE *
xfer->len;
delay_usecs += xfer->delay_usecs; delay_usecs += xfer->delay_usecs;
if (!xfer->speed_hz) if (!xfer->speed_hz)