You've already forked linux-apfs
mirror of
https://github.com/linux-apfs/linux-apfs.git
synced 2026-05-01 15:00:59 -07:00
RTC: Avoid races between RTC alarm wakeup and suspend.
If an RTC alarm fires just as suspend is happening, it is possible for suspend to complete and the alarm to be missed. To avoid the race, we must register the event with the PM core. As the event is made visible to userspace through a thread which is only scheduled by the interrupt, we need a pm_stay_awake/pm_relax pair preventing suspend from the interrupt until the thread completes its work. This makes the pm_wakeup_event() call in cmos_interrupt unnecessary as it provides suspend protection for all RTCs that use rtc_update_irq. Signed-off-by: NeilBrown <neilb@suse.de> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
This commit is contained in:
committed by
Rafael J. Wysocki
parent
0d7614f09c
commit
7523ceed42
@@ -568,7 +568,6 @@ static irqreturn_t cmos_interrupt(int irq, void *p)
|
||||
hpet_mask_rtc_irq_bit(RTC_AIE);
|
||||
|
||||
CMOS_READ(RTC_INTR_FLAGS);
|
||||
pm_wakeup_event(cmos_rtc.dev, 0);
|
||||
}
|
||||
spin_unlock(&rtc_lock);
|
||||
|
||||
|
||||
Reference in New Issue
Block a user