apfs/linux-apfs
0
0
Fork 0
mirror of https://github.com/linux-apfs/linux-apfs.git synced 2026-05-01 15:00:59 -07:00
Code Issues Packages Projects Releases Wiki Activity

virtio-net: restore VIRTIO_HDR_F_DATA_VALID on receiving

Browse Source 
Commit 501db51139 ("virtio: don't set VIRTIO_NET_HDR_F_DATA_VALID on
xmit") in fact disables VIRTIO_HDR_F_DATA_VALID on receiving path too,
fixing this by adding a hint (has_data_valid) and set it only on the
receiving path.

Cc: Rolf Neugebauer <rolf.neugebauer@docker.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
Acked-by: Rolf Neugebauer <rolf.neugebauer@docker.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Jason Wang
2017-01-20 14:32:42 +08:00
committed by David S. Miller
parent 69fed99baa
commit 6391a4481b
5 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/net/macvtap.c
+1 -1
View File
@@ -825,7 +825,7 @@ static ssize_t macvtap_put_user(struct macvtap_queue *q,
return -EINVAL; return -EINVAL;
if (virtio_net_hdr_from_skb(skb, &vnet_hdr, if (virtio_net_hdr_from_skb(skb, &vnet_hdr,
macvtap_is_little_endian(q))) macvtap_is_little_endian(q), true))
BUG(); BUG();
if (copy_to_iter(&vnet_hdr, sizeof(vnet_hdr), iter) != if (copy_to_iter(&vnet_hdr, sizeof(vnet_hdr), iter) !=
drivers/net/tun.c
+1 -1
View File
@@ -1360,7 +1360,7 @@ static ssize_t tun_put_user(struct tun_struct *tun,
return -EINVAL; return -EINVAL;
if (virtio_net_hdr_from_skb(skb, &gso, if (virtio_net_hdr_from_skb(skb, &gso,
tun_is_little_endian(tun))) { tun_is_little_endian(tun), true)) {
struct skb_shared_info *sinfo = skb_shinfo(skb); struct skb_shared_info *sinfo = skb_shinfo(skb);
pr_err("unexpected GSO type: " pr_err("unexpected GSO type: "
"0x%x, gso_size %d, hdr_len %d\n", "0x%x, gso_size %d, hdr_len %d\n",
drivers/net/virtio_net.c
+1 -1
View File
@@ -1104,7 +1104,7 @@ static int xmit_skb(struct send_queue *sq, struct sk_buff *skb)
hdr = skb_vnet_hdr(skb); hdr = skb_vnet_hdr(skb);
if (virtio_net_hdr_from_skb(skb, &hdr->hdr, if (virtio_net_hdr_from_skb(skb, &hdr->hdr,
virtio_is_little_endian(vi->vdev))) virtio_is_little_endian(vi->vdev), false))
BUG(); BUG();
if (vi->mergeable_rx_bufs) if (vi->mergeable_rx_bufs)
include/linux/virtio_net.h
+5 -1
View File
@@ -56,7 +56,8 @@ static inline int virtio_net_hdr_to_skb(struct sk_buff *skb,
static inline int virtio_net_hdr_from_skb(const struct sk_buff *skb, static inline int virtio_net_hdr_from_skb(const struct sk_buff *skb,
struct virtio_net_hdr *hdr, struct virtio_net_hdr *hdr,
bool little_endian) bool little_endian,
bool has_data_valid)
{ {
memset(hdr, 0, sizeof(*hdr)); /* no info leak */ memset(hdr, 0, sizeof(*hdr)); /* no info leak */
@@ -91,6 +92,9 @@ static inline int virtio_net_hdr_from_skb(const struct sk_buff *skb,
skb_checksum_start_offset(skb)); skb_checksum_start_offset(skb));
hdr->csum_offset = __cpu_to_virtio16(little_endian, hdr->csum_offset = __cpu_to_virtio16(little_endian,
skb->csum_offset); skb->csum_offset);
} else if (has_data_valid &&
skb->ip_summed == CHECKSUM_UNNECESSARY) {
hdr->flags = VIRTIO_NET_HDR_F_DATA_VALID;
} /* else everything is zero */ } /* else everything is zero */
return 0; return 0;
net/packet/af_packet.c
+2 -2
View File
@@ -1976,7 +1976,7 @@ static int packet_rcv_vnet(struct msghdr *msg, const struct sk_buff *skb,
return -EINVAL; return -EINVAL;
*len -= sizeof(vnet_hdr); *len -= sizeof(vnet_hdr);
if (virtio_net_hdr_from_skb(skb, &vnet_hdr, vio_le())) if (virtio_net_hdr_from_skb(skb, &vnet_hdr, vio_le(), true))
return -EINVAL; return -EINVAL;
return memcpy_to_msg(msg, (void *)&vnet_hdr, sizeof(vnet_hdr)); return memcpy_to_msg(msg, (void *)&vnet_hdr, sizeof(vnet_hdr));
@@ -2237,7 +2237,7 @@ static int tpacket_rcv(struct sk_buff *skb, struct net_device *dev,
if (po->has_vnet_hdr) { if (po->has_vnet_hdr) {
if (virtio_net_hdr_from_skb(skb, h.raw + macoff - if (virtio_net_hdr_from_skb(skb, h.raw + macoff -
sizeof(struct virtio_net_hdr), sizeof(struct virtio_net_hdr),
vio_le())) { vio_le(), true)) {
spin_lock(&sk->sk_receive_queue.lock); spin_lock(&sk->sk_receive_queue.lock);
goto drop_n_account; goto drop_n_account;
} }