You've already forked linux-apfs
mirror of
https://github.com/linux-apfs/linux-apfs.git
synced 2026-05-01 15:00:59 -07:00
mtd: do not use plain 0 as NULL
The first 3 arguments of 'mtd_device_parse_register()' are pointers, but many callers pass '0' instead of 'NULL'. Fix this globally. Thanks to coccinelle for making it easy to do with the following semantic patch: @@ expression mtd, types, parser_data, parts, nr_parts; @@ ( -mtd_device_parse_register(mtd, 0, parser_data, parts, nr_parts) +mtd_device_parse_register(mtd, NULL, parser_data, parts, nr_parts) | -mtd_device_parse_register(mtd, types, 0, parts, nr_parts) +mtd_device_parse_register(mtd, types, NULL, parts, nr_parts) | -mtd_device_parse_register(mtd, types, parser_data, 0, nr_parts) +mtd_device_parse_register(mtd, types, parser_data, NULL, nr_parts) ) Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
This commit is contained in:
committed by
David Woodhouse
parent
ee478af8b6
commit
42d7fbe223
@@ -60,7 +60,7 @@ static int __init flash_init(void)
|
||||
if (mymtd) {
|
||||
mymtd->owner = THIS_MODULE;
|
||||
mtd_device_parse_register(mymtd, part_probe_types,
|
||||
0, NULL, 0);
|
||||
NULL, NULL, 0);
|
||||
} else {
|
||||
pr_err("Failed to register MTD device for flash\n");
|
||||
}
|
||||
|
||||
@@ -851,7 +851,7 @@ static int spear_smi_setup_banks(struct platform_device *pdev, u32 bank)
|
||||
goto err_map;
|
||||
}
|
||||
}
|
||||
ret = mtd_device_parse_register(&flash->mtd, NULL, 0, parts, count);
|
||||
ret = mtd_device_parse_register(&flash->mtd, NULL, NULL, parts, count);
|
||||
if (ret)
|
||||
dev_err(&dev->pdev->dev, "Err MTD partition=%d\n", ret);
|
||||
|
||||
|
||||
@@ -399,9 +399,9 @@ static int __devinit sst25l_probe(struct spi_device *spi)
|
||||
flash->mtd.numeraseregions);
|
||||
|
||||
|
||||
ret = mtd_device_parse_register(&flash->mtd, NULL, 0,
|
||||
data ? data->parts : NULL,
|
||||
data ? data->nr_parts : 0);
|
||||
ret = mtd_device_parse_register(&flash->mtd, NULL, NULL,
|
||||
data ? data->parts : NULL,
|
||||
data ? data->nr_parts : 0);
|
||||
if (ret) {
|
||||
kfree(flash);
|
||||
dev_set_drvdata(&spi->dev, NULL);
|
||||
|
||||
@@ -164,8 +164,8 @@ static int __devinit bfin_flash_probe(struct platform_device *pdev)
|
||||
return -ENXIO;
|
||||
}
|
||||
|
||||
mtd_device_parse_register(state->mtd, part_probe_types, 0,
|
||||
pdata->parts, pdata->nr_parts);
|
||||
mtd_device_parse_register(state->mtd, part_probe_types, NULL,
|
||||
pdata->parts, pdata->nr_parts);
|
||||
|
||||
platform_set_drvdata(pdev, state);
|
||||
|
||||
|
||||
@@ -196,7 +196,7 @@ static int __init init_dc21285(void)
|
||||
|
||||
dc21285_mtd->owner = THIS_MODULE;
|
||||
|
||||
mtd_device_parse_register(dc21285_mtd, probes, 0, NULL, 0);
|
||||
mtd_device_parse_register(dc21285_mtd, probes, NULL, NULL, 0);
|
||||
|
||||
if(machine_is_ebsa285()) {
|
||||
/*
|
||||
|
||||
@@ -252,8 +252,8 @@ static int __devinit gpio_flash_probe(struct platform_device *pdev)
|
||||
}
|
||||
|
||||
|
||||
mtd_device_parse_register(state->mtd, part_probe_types, 0,
|
||||
pdata->parts, pdata->nr_parts);
|
||||
mtd_device_parse_register(state->mtd, part_probe_types, NULL,
|
||||
pdata->parts, pdata->nr_parts);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
@@ -85,8 +85,8 @@ static int __init h720x_mtd_init(void)
|
||||
if (mymtd) {
|
||||
mymtd->owner = THIS_MODULE;
|
||||
|
||||
mtd_device_parse_register(mymtd, NULL, 0,
|
||||
h720x_partitions, NUM_PARTITIONS);
|
||||
mtd_device_parse_register(mymtd, NULL, NULL,
|
||||
h720x_partitions, NUM_PARTITIONS);
|
||||
return 0;
|
||||
}
|
||||
|
||||
|
||||
@@ -91,7 +91,7 @@ static int __init init_impa7(void)
|
||||
if (impa7_mtd[i]) {
|
||||
impa7_mtd[i]->owner = THIS_MODULE;
|
||||
devicesfound++;
|
||||
mtd_device_parse_register(impa7_mtd[i], NULL, 0,
|
||||
mtd_device_parse_register(impa7_mtd[i], NULL, NULL,
|
||||
partitions,
|
||||
ARRAY_SIZE(partitions));
|
||||
}
|
||||
|
||||
@@ -72,7 +72,7 @@ static int __devinit vr_nor_init_partitions(struct vr_nor_mtd *p)
|
||||
{
|
||||
/* register the flash bank */
|
||||
/* partition the flash bank */
|
||||
return mtd_device_parse_register(p->info, NULL, 0, NULL, 0);
|
||||
return mtd_device_parse_register(p->info, NULL, NULL, NULL, 0);
|
||||
}
|
||||
|
||||
static void __devexit vr_nor_destroy_mtd_setup(struct vr_nor_mtd *p)
|
||||
|
||||
@@ -226,7 +226,7 @@ static int ixp2000_flash_probe(struct platform_device *dev)
|
||||
}
|
||||
info->mtd->owner = THIS_MODULE;
|
||||
|
||||
err = mtd_device_parse_register(info->mtd, probes, 0, NULL, 0);
|
||||
err = mtd_device_parse_register(info->mtd, probes, NULL, NULL, 0);
|
||||
if (err)
|
||||
goto Error;
|
||||
|
||||
|
||||
@@ -169,8 +169,9 @@ ltq_mtd_probe(struct platform_device *pdev)
|
||||
cfi->addr_unlock1 ^= 1;
|
||||
cfi->addr_unlock2 ^= 1;
|
||||
|
||||
err = mtd_device_parse_register(ltq_mtd->mtd, ltq_probe_types, 0,
|
||||
ltq_mtd_data->parts, ltq_mtd_data->nr_parts);
|
||||
err = mtd_device_parse_register(ltq_mtd->mtd, ltq_probe_types, NULL,
|
||||
ltq_mtd_data->parts,
|
||||
ltq_mtd_data->nr_parts);
|
||||
if (err) {
|
||||
dev_err(&pdev->dev, "failed to add partitions\n");
|
||||
goto err_destroy;
|
||||
|
||||
@@ -199,8 +199,9 @@ static int __devinit latch_addr_flash_probe(struct platform_device *dev)
|
||||
}
|
||||
info->mtd->owner = THIS_MODULE;
|
||||
|
||||
mtd_device_parse_register(info->mtd, NULL, 0,
|
||||
latch_addr_data->parts, latch_addr_data->nr_parts);
|
||||
mtd_device_parse_register(info->mtd, NULL, NULL,
|
||||
latch_addr_data->parts,
|
||||
latch_addr_data->nr_parts);
|
||||
return 0;
|
||||
|
||||
iounmap:
|
||||
|
||||
@@ -192,7 +192,7 @@ static int physmap_flash_probe(struct platform_device *dev)
|
||||
|
||||
part_types = physmap_data->part_probe_types ? : part_probe_types;
|
||||
|
||||
mtd_device_parse_register(info->cmtd, part_types, 0,
|
||||
mtd_device_parse_register(info->cmtd, part_types, NULL,
|
||||
physmap_data->parts, physmap_data->nr_parts);
|
||||
return 0;
|
||||
|
||||
|
||||
@@ -222,8 +222,9 @@ static int platram_probe(struct platform_device *pdev)
|
||||
/* check to see if there are any available partitions, or wether
|
||||
* to add this device whole */
|
||||
|
||||
err = mtd_device_parse_register(info->mtd, pdata->probes, 0,
|
||||
pdata->partitions, pdata->nr_partitions);
|
||||
err = mtd_device_parse_register(info->mtd, pdata->probes, NULL,
|
||||
pdata->partitions,
|
||||
pdata->nr_partitions);
|
||||
if (!err)
|
||||
dev_info(&pdev->dev, "registered mtd device\n");
|
||||
|
||||
|
||||
@@ -98,7 +98,8 @@ static int __devinit pxa2xx_flash_probe(struct platform_device *pdev)
|
||||
}
|
||||
info->mtd->owner = THIS_MODULE;
|
||||
|
||||
mtd_device_parse_register(info->mtd, probes, 0, flash->parts, flash->nr_parts);
|
||||
mtd_device_parse_register(info->mtd, probes, NULL, flash->parts,
|
||||
flash->nr_parts);
|
||||
|
||||
platform_set_drvdata(pdev, info);
|
||||
return 0;
|
||||
|
||||
@@ -102,8 +102,8 @@ static int rbtx4939_flash_probe(struct platform_device *dev)
|
||||
info->mtd->owner = THIS_MODULE;
|
||||
if (err)
|
||||
goto err_out;
|
||||
err = mtd_device_parse_register(info->mtd, NULL, 0,
|
||||
pdata->parts, pdata->nr_parts);
|
||||
err = mtd_device_parse_register(info->mtd, NULL, NULL, pdata->parts,
|
||||
pdata->nr_parts);
|
||||
|
||||
if (err)
|
||||
goto err_out;
|
||||
|
||||
@@ -264,8 +264,8 @@ static int __devinit sa1100_mtd_probe(struct platform_device *pdev)
|
||||
/*
|
||||
* Partition selection stuff.
|
||||
*/
|
||||
mtd_device_parse_register(info->mtd, part_probes, 0,
|
||||
plat->parts, plat->nr_parts);
|
||||
mtd_device_parse_register(info->mtd, part_probes, NULL, plat->parts,
|
||||
plat->nr_parts);
|
||||
|
||||
platform_set_drvdata(pdev, info);
|
||||
err = 0;
|
||||
|
||||
@@ -92,8 +92,8 @@ static int __init init_soleng_maps(void)
|
||||
mtd_device_register(eprom_mtd, NULL, 0);
|
||||
}
|
||||
|
||||
mtd_device_parse_register(flash_mtd, probes, 0,
|
||||
superh_se_partitions, NUM_PARTITIONS);
|
||||
mtd_device_parse_register(flash_mtd, probes, NULL,
|
||||
superh_se_partitions, NUM_PARTITIONS);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
@@ -142,7 +142,7 @@ static int __init init_sbc82xx_flash(void)
|
||||
nr_parts = ARRAY_SIZE(smallflash_parts);
|
||||
}
|
||||
|
||||
mtd_device_parse_register(sbcmtd[i], part_probes, 0,
|
||||
mtd_device_parse_register(sbcmtd[i], part_probes, NULL,
|
||||
defparts, nr_parts);
|
||||
}
|
||||
return 0;
|
||||
|
||||
@@ -650,8 +650,8 @@ static int __init atmel_nand_probe(struct platform_device *pdev)
|
||||
}
|
||||
|
||||
mtd->name = "atmel_nand";
|
||||
res = mtd_device_parse_register(mtd, NULL, 0,
|
||||
host->board->parts, host->board->num_parts);
|
||||
res = mtd_device_parse_register(mtd, NULL, NULL, host->board->parts,
|
||||
host->board->num_parts);
|
||||
if (!res)
|
||||
return res;
|
||||
|
||||
|
||||
Some files were not shown because too many files have changed in this diff Show More
Reference in New Issue
Block a user