apfs/linux-apfs
0
0
Fork 0
mirror of https://github.com/linux-apfs/linux-apfs.git synced 2026-05-01 15:00:59 -07:00
Code Issues Packages Projects Releases Wiki Activity

neofb: remove open_lock mutex

Browse Source 
Remove mutex from the fb_open/fb_release functions as these operations are
mutexed at fb layer.

Signed-off-by: Krzysztof Helt <krzysztof.h1@wp.pl>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Krzysztof Helt
2008-10-15 22:03:33 -07:00
committed by Linus Torvalds
parent 9c8db4a265
commit 3a568051f3
2 changed files with 2 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/video/neofb.c
+2 -8
View File
@@ -557,14 +557,12 @@ neofb_open(struct fb_info *info, int user)
{ {
struct neofb_par *par = info->par; struct neofb_par *par = info->par;
mutex_lock(&par->open_lock);
if (!par->ref_count) { if (!par->ref_count) {
memset(&par->state, 0, sizeof(struct vgastate)); memset(&par->state, 0, sizeof(struct vgastate));
par->state.flags = VGA_SAVE_MODE | VGA_SAVE_FONTS; par->state.flags = VGA_SAVE_MODE | VGA_SAVE_FONTS;
save_vga(&par->state); save_vga(&par->state);
} }
par->ref_count++; par->ref_count++;
mutex_unlock(&par->open_lock);
return 0; return 0;
} }
@@ -574,16 +572,13 @@ neofb_release(struct fb_info *info, int user)
{ {
struct neofb_par *par = info->par; struct neofb_par *par = info->par;
mutex_lock(&par->open_lock); if (!par->ref_count)
if (!par->ref_count) {
mutex_unlock(&par->open_lock);
return -EINVAL; return -EINVAL;
}
if (par->ref_count == 1) { if (par->ref_count == 1) {
restore_vga(&par->state); restore_vga(&par->state);
} }
par->ref_count--; par->ref_count--;
mutex_unlock(&par->open_lock);
return 0; return 0;
} }
@@ -1958,7 +1953,6 @@ static struct fb_info *__devinit neo_alloc_fb_info(struct pci_dev *dev, const st
info->fix.accel = id->driver_data; info->fix.accel = id->driver_data;
mutex_init(&par->open_lock);
par->pci_burst = !nopciburst; par->pci_burst = !nopciburst;
par->lcd_stretch = !nostretch; par->lcd_stretch = !nostretch;
par->libretto = libretto; par->libretto = libretto;
include/video/neomagic.h
-1
View File
@@ -123,7 +123,6 @@ typedef volatile struct {
struct neofb_par { struct neofb_par {
struct vgastate state; struct vgastate state;
struct mutex open_lock;
unsigned int ref_count; unsigned int ref_count;
unsigned char MiscOutReg; /* Misc */ unsigned char MiscOutReg; /* Misc */