You've already forked linux-apfs
mirror of
https://github.com/linux-apfs/linux-apfs.git
synced 2026-05-01 15:00:59 -07:00
rfkill: rewrite
This patch completely rewrites the rfkill core to address the following deficiencies: * all rfkill drivers need to implement polling where necessary rather than having one central implementation * updating the rfkill state cannot be done from arbitrary contexts, forcing drivers to use schedule_work and requiring lots of code * rfkill drivers need to keep track of soft/hard blocked internally -- the core should do this * the rfkill API has many unexpected quirks, for example being asymmetric wrt. alloc/free and register/unregister * rfkill can call back into a driver from within a function the driver called -- this is prone to deadlocks and generally should be avoided * rfkill-input pointlessly is a separate module * drivers need to #ifdef rfkill functions (unless they want to depend on or select RFKILL) -- rfkill should provide inlines that do nothing if it isn't compiled in * the rfkill structure is not opaque -- drivers need to initialise it correctly (lots of sanity checking code required) -- instead force drivers to pass the right variables to rfkill_alloc() * the documentation is hard to read because it always assumes the reader is completely clueless and contains way TOO MANY CAPS * the rfkill code needlessly uses a lot of locks and atomic operations in locked sections * fix LED trigger to actually change the LED when the radio state changes -- this wasn't done before Tested-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk> Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br> [thinkpad] Signed-off-by: Johannes Berg <johannes@sipsolutions.net> Signed-off-by: John W. Linville <linville@tuxdriver.com>
This commit is contained in:
committed by
John W. Linville
parent
0f6399c4c5
commit
19d337dff9
@@ -1,23 +1,9 @@
|
||||
#
|
||||
# WiMAX LAN device configuration
|
||||
#
|
||||
# Note the ugly 'depends on' on WIMAX: that disallows RFKILL to be a
|
||||
# module if WIMAX is to be linked in. The WiMAX code is done in such a
|
||||
# way that it doesn't require and explicit dependency on RFKILL in
|
||||
# case an embedded system wants to rip it out.
|
||||
#
|
||||
# As well, enablement of the RFKILL code means we need the INPUT layer
|
||||
# support to inject events coming from hw rfkill switches. That
|
||||
# dependency could be killed if input.h provided appropriate means to
|
||||
# work when input is disabled.
|
||||
|
||||
comment "WiMAX Wireless Broadband support requires CONFIG_INPUT enabled"
|
||||
depends on INPUT = n && RFKILL != n
|
||||
|
||||
menuconfig WIMAX
|
||||
tristate "WiMAX Wireless Broadband support"
|
||||
depends on (y && RFKILL != m) || m
|
||||
depends on (INPUT && RFKILL != n) || RFKILL = n
|
||||
help
|
||||
|
||||
Select to configure support for devices that provide
|
||||
|
||||
Reference in New Issue
Block a user