apfs/linux-apfs
0
0
Fork 0
mirror of https://github.com/linux-apfs/linux-apfs.git synced 2026-05-01 15:00:59 -07:00
Code Issues Packages Projects Releases Wiki Activity

remoteproc: qcom: mdt_loader: Use signed type for offset

Browse Source 
In the transition from using rproc_da_to_va(), the type of the load
offset became unsigned. This causes the subsequent check to let negative
values less than p_memsz + mem_size through and we write outside of the
buffer.

Change the type back to a signed value to catch this.

Fixes: 7f0dd07a9b ("remoteproc: qcom: mdt_loader: Refactor MDT loader")
Fixes: e7fd252262 ("remoteproc: qcom: q6v5: Decouple driver from MDT loader")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Reported-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
Acked-by: Andy Gross <andy.gross@linaro.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
This commit is contained in:
Bjorn Andersson
2017-02-15 14:00:41 -08:00
parent 231c8dfd1a
commit 01625cc5e6
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/remoteproc/qcom_q6v5_pil.c
+1 -1
View File
@@ -502,7 +502,7 @@ static int q6v5_mpss_load(struct q6v5 *qproc)
phys_addr_t max_addr = 0; phys_addr_t max_addr = 0;
bool relocate = false; bool relocate = false;
char seg_name[10]; char seg_name[10];
size_t offset; ssize_t offset;
size_t size; size_t size;
void *ptr; void *ptr;
int ret; int ret;
drivers/soc/qcom/mdt_loader.c
+1 -1
View File
@@ -98,7 +98,7 @@ int qcom_mdt_load(struct device *dev, const struct firmware *fw,
phys_addr_t min_addr = (phys_addr_t)ULLONG_MAX; phys_addr_t min_addr = (phys_addr_t)ULLONG_MAX;
phys_addr_t max_addr = 0; phys_addr_t max_addr = 0;
size_t fw_name_len; size_t fw_name_len;
size_t offset; ssize_t offset;
char *fw_name; char *fw_name;
bool relocate = false; bool relocate = false;
void *ptr; void *ptr;