mirror of
https://github.com/linux-apfs/apfstests.git
synced 2026-05-01 15:01:44 -07:00
Dave Chinner
47dbcf13f7
xfs/299 has failed for me for a long time. In fact, looking at my
logs it has never passed on any of my test machines. IOWs, the
test that was committed was fundamentally broken.
The reason is that it tests project quotas before it tests user or
group quotas and so creates a bunch of files that are owned by root
or privileged users. It think tries to manipulate them as a user,
and, unsurprisingly, it fails to do so. This then causes the test to
throw an error.
The reason it has always failed is the error that is thrown
hardcodes a uid/gid into an error message. This uid/gid is what
causes the golden output mismatch (nobody is 65534 on my machines,
not 99):
*** push past the hard block limit (expect EDQUOT)
[ROOT] 0 0 0 00 [--------] 12 0 0 00 [--------] 0 0 0 00 [--------]
[NAME] =OK= 100 500 00 [--------] 7 4 10 00 [7 days] 0 0 0 00 [--------]
- URK 99: 0 is out of range! [425,500]
+ URK 65534: 0 is out of range! [425,500]
It wasn't until I looked at the xfs/299.full file when trying to
understand why the error was being thrown and whether it shoul dhave
been in the golden output in the first place that I saw the real
problem. That is, All the user/group quota modifications were
failing because of not having permissions to write the files left
behind by the quota test, and that user and group quotas were not
being tested at all by the test.
So, firstly $SCRATCH_MNT needs to be world writeable, and secondly
each test needs to remove the files it created during the test so
they don't impact on furture test iterations.
This then exercises the user and group quotas appropriately, and so
the golden output changes completely to reflect that changes under
user quotas are actually being accounted to the correct user.
Further, the error message that I originally saw errors on goes
away, because everything is now accounted correctly.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dave Chinner <david@fromorbit.com>
249 lines
6.4 KiB
Bash
Executable File
249 lines
6.4 KiB
Bash
Executable File
#! /bin/bash
|
|
# FS QA Test No. 299
|
|
#
|
|
# Exercises basic XFS quota functionality, with all 3 quotas together
|
|
# uquota, gquota, pquota
|
|
# uqnoenforce, gqnoenforce, pqnoenforce
|
|
#
|
|
#-----------------------------------------------------------------------
|
|
# Copyright (c) 2000-2002 Silicon Graphics, Inc. All Rights Reserved.
|
|
#
|
|
# This program is free software; you can redistribute it and/or
|
|
# modify it under the terms of the GNU General Public License as
|
|
# published by the Free Software Foundation.
|
|
#
|
|
# This program is distributed in the hope that it would be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program; if not, write the Free Software Foundation,
|
|
# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
|
|
#
|
|
#-----------------------------------------------------------------------
|
|
#
|
|
|
|
seq=`basename $0`
|
|
seqres=$RESULT_DIR/$seq
|
|
echo "QA output created by $seq"
|
|
|
|
here=`pwd`
|
|
tmp=/tmp/$$
|
|
status=1 # failure is the default!
|
|
|
|
# get standard environment, filters and checks
|
|
. ./common/rc
|
|
. ./common/filter
|
|
. ./common/quota
|
|
|
|
_cleanup()
|
|
{
|
|
cd /
|
|
umount $SCRATCH_MNT 2>/dev/null
|
|
rm -f $tmp.*
|
|
}
|
|
trap "_cleanup; exit \$status" 0 1 2 3 15
|
|
|
|
# real QA test starts here
|
|
_supported_fs xfs
|
|
_supported_os Linux
|
|
|
|
cp /dev/null $seqres.full
|
|
chmod a+rwx $seqres.full # arbitrary users will write here
|
|
|
|
_require_scratch
|
|
_require_xfs_quota
|
|
_require_xfs_mkfs_crc
|
|
_require_xfs_crc
|
|
|
|
bsoft=100
|
|
bhard=500
|
|
isoft=4
|
|
ihard=10
|
|
|
|
_filter_report()
|
|
{
|
|
tr -s '[:space:]' | \
|
|
perl -npe '
|
|
s/^\#'$id' /[NAME] /g;
|
|
s/^\#0 \d+ /[ROOT] 0 /g;
|
|
s/6 days/7 days/g' |
|
|
perl -npe '
|
|
$val = 0;
|
|
if ($ENV{'LARGE_SCRATCH_DEV'}) {
|
|
$val = $ENV{'NUM_SPACE_FILES'};
|
|
}
|
|
s/(^\[ROOT\] \S+ \S+ \S+ \S+ \[--------\] )(\S+)/$1@{[$2 - $val]}/g'
|
|
}
|
|
|
|
# The actual point at which limit enforcement takes place for the
|
|
# hard block limit is variable depending on filesystem blocksize,
|
|
# and iosize. What we want to test is that the limit is enforced
|
|
# (ie. blksize less than limit but not unduly less - ~85% is kind)
|
|
# nowadays we actually get much closer to the limit before EDQUOT.
|
|
#
|
|
_filter_and_check_blks()
|
|
{
|
|
perl -npe '
|
|
if (/^\#'$id'\s+(\d+)/ && '$enforce') {
|
|
$maximum = '$bhard';
|
|
$minimum = '$bhard' * 85/100;
|
|
if (($1 < $minimum || $1 > $maximum) && '$noextsz') {
|
|
printf(" URK %d: %d is out of range! [%d,%d]\n",
|
|
'$id', $1, $minimum, $maximum);
|
|
}
|
|
s/^(\#'$id'\s+)(\d+)/\1 =OK=/g;
|
|
}
|
|
' | _filter_report
|
|
}
|
|
|
|
_qsetup()
|
|
{
|
|
opt=$1
|
|
enforce=0
|
|
if [ $opt = "u" -o $opt = "uno" ]; then
|
|
type=u
|
|
eval `_choose_uid`
|
|
elif [ $opt = "g" -o $opt = "gno" ]; then
|
|
type=g
|
|
eval `_choose_gid`
|
|
elif [ $opt = "p" -o $opt = "pno" ]; then
|
|
type=p
|
|
eval `_choose_prid`
|
|
fi
|
|
[ $opt = "u" -o $opt = "g" -o $opt = "p" ] && enforce=1
|
|
|
|
echo "Using type=$type id=$id" >> $seqres.full
|
|
}
|
|
|
|
_exercise()
|
|
{
|
|
|
|
# Figure out whether we're doing large allocations
|
|
# (bail out if they're so large they stuff the test up)
|
|
_test_inode_flag extsz-inherit $SCRATCH_MNT
|
|
noextsz=$?
|
|
extsize=`_test_inode_extsz $SCRATCH_MNT`
|
|
[ $extsize -ge 512000 ] && \
|
|
_notrun "Extent size hint is too large ($extsize bytes)"
|
|
|
|
_qsetup $1
|
|
|
|
echo "Using type=$type id=$id" >>$seqres.full
|
|
|
|
echo
|
|
echo "*** report no quota settings" | tee -a $seqres.full
|
|
xfs_quota -D $tmp.projects -P $tmp.projid -x \
|
|
-c "repquota -birnN -$type" $SCRATCH_DEV |
|
|
_filter_report | LC_COLLATE=POSIX sort -ru
|
|
|
|
echo
|
|
echo "*** report initial settings" | tee -a $seqres.full
|
|
_file_as_id $SCRATCH_MNT/initme $id $type 1024 0
|
|
echo "ls -l $SCRATCH_MNT" >>$seqres.full
|
|
ls -l $SCRATCH_MNT >>$seqres.full
|
|
xfs_quota -D $tmp.projects -P $temp.projid -x \
|
|
-c "limit -$type bsoft=${bsoft}k bhard=${bhard}k $id" \
|
|
-c "limit -$type isoft=$isoft ihard=$ihard $id" \
|
|
$SCRATCH_DEV
|
|
xfs_quota -D $tmp.projects -P $tmp.projid -x \
|
|
-c "repquota -birnN -$type" $SCRATCH_DEV |
|
|
_filter_report | LC_COLLATE=POSIX sort -ru
|
|
|
|
echo
|
|
echo "*** push past the soft inode limit" | tee -a $seqres.full
|
|
_file_as_id $SCRATCH_MNT/softie1 $id $type 1024 0
|
|
_file_as_id $SCRATCH_MNT/softie2 $id $type 1024 0
|
|
_qmount
|
|
xfs_quota -D $tmp.projects -P $tmp.projid -x \
|
|
-c "repquota -birnN -$type" $SCRATCH_DEV |
|
|
_filter_report | LC_COLLATE=POSIX sort -ru
|
|
|
|
echo
|
|
echo "*** push past the soft block limit" | tee -a $seqres.full
|
|
_file_as_id $SCRATCH_MNT/softie $id $type 1024 140
|
|
_qmount
|
|
xfs_quota -D $tmp.projects -P $tmp.projid -x \
|
|
-c "repquota -birnN -$type" $SCRATCH_DEV |
|
|
_filter_report | LC_COLLATE=POSIX sort -ru
|
|
|
|
echo
|
|
# Note: for quota accounting (not enforcement), EDQUOT is not expected
|
|
echo "*** push past the hard inode limit (expect EDQUOT)" | tee -a $seqres.full
|
|
for i in 1 2 3 4 5 6 7 8 9 10 11 12
|
|
do
|
|
_file_as_id $SCRATCH_MNT/hard$i $id $type 1024 0
|
|
done
|
|
_qmount
|
|
xfs_quota -D $tmp.projects -P $tmp.projid -x \
|
|
-c "repquota -birnN -$type" $SCRATCH_DEV |
|
|
_filter_report | LC_COLLATE=POSIX sort -ru
|
|
|
|
echo
|
|
# Note: for quota accounting (not enforcement), EDQUOT is not expected
|
|
echo "*** push past the hard block limit (expect EDQUOT)" | tee -a $seqres.full
|
|
_file_as_id $SCRATCH_MNT/softie $id $type 1024 540
|
|
echo "ls -l $SCRATCH_MNT" >>$seqres.full
|
|
ls -l $SCRATCH_MNT >>$seqres.full
|
|
_qmount
|
|
xfs_quota -D $tmp.projects -P $tmp.projid -x \
|
|
-c "repquota -birnN -$type" $SCRATCH_DEV |
|
|
_filter_and_check_blks | LC_COLLATE=POSIX sort -ru
|
|
|
|
echo
|
|
|
|
# clean up our files so we don't pollute the next run
|
|
rm -f $SCRATCH_MNT/*
|
|
|
|
}
|
|
|
|
_scratch_mkfs_xfs -m crc=1 2>/dev/null | _filter_mkfs 2>$tmp.mkfs
|
|
cat $tmp.mkfs >>$seqres.full
|
|
# keep the blocksize and data size for dd later
|
|
. $tmp.mkfs
|
|
|
|
# non-root users need to be able to write to this filesystem
|
|
chmod 777 $SCRATCH_MNT
|
|
|
|
cat >$tmp.projects <<EOF
|
|
1:$SCRATCH_MNT
|
|
EOF
|
|
|
|
cat >$tmp.projid <<EOF
|
|
root:0
|
|
scrach:1
|
|
EOF
|
|
|
|
projid_file="$tmp.projid"
|
|
|
|
echo "*** user, group, and project"
|
|
_qmount_option "uquota,gquota,pquota"
|
|
_qmount
|
|
_exercise p
|
|
_exercise g
|
|
_exercise u
|
|
|
|
echo "*** unmount"
|
|
umount $SCRATCH_MNT
|
|
|
|
|
|
_scratch_mkfs_xfs -m crc=1 2>/dev/null | _filter_mkfs 2>$tmp.mkfs
|
|
cat $tmp.mkfs >>$seqres.full
|
|
# keep the blocksize and data size for dd later
|
|
. $tmp.mkfs
|
|
|
|
echo "*** uqnoenforce, gqnoenforce, and pqnoenforce"
|
|
_qmount_option "uqnoenforce,gqnoenforce,pqnoenforce"
|
|
_qmount
|
|
_exercise uno
|
|
_exercise gno
|
|
_exercise pno
|
|
|
|
echo "*** unmount"
|
|
umount $SCRATCH_MNT
|
|
|
|
# success, all done
|
|
status=0
|
|
exit
|