mirror of
https://github.com/linux-apfs/apfstests.git
synced 2026-05-01 15:01:44 -07:00
Boris Ranto
a9f5ef25fb
Test case 223 constantly fails because the variable carrying mkfs options is not being reinitialized. Test calls function _scratch_mkfs_geom repeatedly in for loop without cleaning the MKFS_OPTIONS variable. Since _scratch_mkfs_geom only appends options to the variable, MKFS_OPTIONS looks like this in 5th iteration: MKFS_OPTIONS="-bsize=4096-b size=4096 -d su=8192,sw=4-b size=4096 -d su=16384,sw=4-b size=4096 -d su=32768,sw=4-b size=4096 -d su=65536,sw=4-b size=4096 -d su=131072,sw=4" It is also easy to see that _scratch_mkfs_geom does not append leading space when it appends the variable. Following patch fixes the issue for me and based on my testing does not break any other test case: Signed-off-by: Boris Ranto <branto@redhat.com> Signed-off-by: Eric Sandeen <sandeen@redhat.com> Reviewed-by: Eric Sandeen <sandeen@redhat.com>
102 lines
2.7 KiB
Bash
Executable File
102 lines
2.7 KiB
Bash
Executable File
#! /bin/bash
|
|
# FS QA Test No. 223
|
|
#
|
|
# File alignment tests
|
|
#
|
|
#-----------------------------------------------------------------------
|
|
# Copyright (c) 2010 Eric Sandeen. All Rights Reserved.
|
|
#
|
|
# This program is free software; you can redistribute it and/or
|
|
# modify it under the terms of the GNU General Public License as
|
|
# published by the Free Software Foundation.
|
|
#
|
|
# This program is distributed in the hope that it would be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program; if not, write the Free Software Foundation,
|
|
# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
|
|
#
|
|
#-----------------------------------------------------------------------
|
|
#
|
|
# creator
|
|
owner=sandeen@sandeen.net
|
|
|
|
seq=`basename $0`
|
|
echo "QA output created by $seq"
|
|
|
|
here=`pwd`
|
|
tmp=/tmp/$$
|
|
status=1 # failure is the default!
|
|
|
|
_cleanup()
|
|
{
|
|
rm -f $tmp.*
|
|
}
|
|
|
|
trap "_cleanup ; exit \$status" 0 1 2 3 15
|
|
|
|
# get standard environment, filters and checks
|
|
. ./common.rc
|
|
. ./common.filter
|
|
|
|
# real QA test starts here
|
|
_supported_fs generic
|
|
_supported_os Linux
|
|
|
|
_require_scratch
|
|
_require_xfs_io_falloc
|
|
|
|
rm -f $seq.full
|
|
|
|
BLOCKSIZE=4096
|
|
|
|
for SUNIT_K in 8 16 32 64 128; do
|
|
let SUNIT_BYTES=$SUNIT_K*1024
|
|
let SUNIT_BLOCKS=$SUNIT_BYTES/$BLOCKSIZE
|
|
|
|
echo "=== mkfs with su $SUNIT_BLOCKS blocks x 4 ==="
|
|
export MKFS_OPTIONS=""
|
|
_scratch_mkfs_geom $SUNIT_BYTES 4 $BLOCKSIZE >> $seq.full 2>&1
|
|
_scratch_mount
|
|
|
|
for SIZE_MULT in 1 2 8 64 256; do
|
|
let SIZE=$SIZE_MULT*$SUNIT_BYTES
|
|
|
|
echo "=== Testing size ${SIZE_MULT}*${SUNIT_K}k on ${SUNIT_K}k stripe ==="
|
|
for FILE in 1 2 3 4; do
|
|
xfs_io -F -f -c "falloc 0 $SIZE" \
|
|
$SCRATCH_MNT/file-$FILE-$SIZE-falloc \
|
|
>> $seq.full 2>&1
|
|
xfs_io -F -f -c "pwrite 0 $SIZE" \
|
|
$SCRATCH_MNT/file-$FILE-$SIZE-write \
|
|
>> $seq.full 2>&1
|
|
src/t_stripealign $SCRATCH_MNT/file-$FILE-$SIZE-falloc \
|
|
$SUNIT_BLOCKS | _filter_scratch
|
|
src/t_stripealign $SCRATCH_MNT/file-$FILE-$SIZE-write \
|
|
$SUNIT_BLOCKS | _filter_scratch
|
|
done
|
|
done
|
|
|
|
echo "=== Testing size 1g falloc on ${SUNIT_K}k stripe ==="
|
|
xfs_io -F -f -c "falloc 0 1g" \
|
|
$SCRATCH_MNT/file-1g-falloc >> $seq.full 2>&1
|
|
src/t_stripealign $SCRATCH_MNT/file-1g-falloc $SUNIT_BLOCKS \
|
|
| _filter_scratch
|
|
|
|
rm -f $SCRATCH_MNT/file-1g-falloc | _filter_scratch
|
|
|
|
echo "=== Testing size 1073745920 falloc on ${SUNIT_K}k stripe ==="
|
|
xfs_io -F -f -c "falloc 0 1073745920" \
|
|
$SCRATCH_MNT/file-1073745920-falloc >> $seq.full 2>&1
|
|
src/t_stripealign $SCRATCH_MNT/file-1073745920-falloc \
|
|
$SUNIT_BLOCKS | _filter_scratch
|
|
|
|
_scratch_unmount
|
|
done
|
|
|
|
status=0
|
|
exit
|