Files
apfstests/tests/generic/471
T
Filipe Manana a38e45b19d generic/471: adapt test when running on btrfs to avoid failure on RWF_NOWAIT write
This test currently always fails on btrfs:

generic/471 2s ... - output mismatch (see ...results//generic/471.out.bad)
    --- tests/generic/471.out   2020-06-10 19:29:03.850519863 +0100
    +++ /home/fdmanana/git/hub/xfstests/results//generic/471.out.bad   ...
    @@ -2,12 +2,10 @@
     pwrite: Resource temporarily unavailable
     wrote 8388608/8388608 bytes at offset 0
     XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
    -RWF_NOWAIT time is within limits.
    +pwrite: Resource temporarily unavailable
    +(standard_in) 1: syntax error
    +RWF_NOWAIT took  seconds

This is because btrfs is a COW filesystem and an attempt to write into a
previously written file range allocating a new extent (or multiple).
The only exceptions are when attempting to write to a file range with a
preallocated/unwritten extent or when writing to a NOCOW file that has
extents allocated in the target range already.

The test currently expects that writing into a previously written file
range succeeds, but that is not true on btrfs since we are not dealing
with a NOCOW file. So to make the test pass on btrfs, set the NOCOW bit
on the file when the filesystem is btrfs.

Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: Eryu Guan <guaneryu@gmail.com>
2020-06-21 22:34:04 +08:00

73 lines
2.1 KiB
Bash
Executable File

#! /bin/bash
# SPDX-License-Identifier: GPL-2.0
# Copyright (c) 2017, SUSE Linux Products. All Rights Reserved.
#
# FS QA Test No. 471
#
# write a file with RWF_NOWAIT and it would fail because there are no
# blocks allocated. Create a file with direct I/O and re-write it
# using RWF_NOWAIT. I/O should finish within 50 microsecods since
# block allocations are already performed.
#
seq=`basename $0`
seqres=$RESULT_DIR/$seq
echo "QA output created by $seq"
here=`pwd`
tmp=/tmp/$$
status=1 # failure is the default!
# get standard environment, filters and checks
. ./common/rc
. ./common/populate
. ./common/filter
. ./common/attr
# real QA test starts here
_supported_os Linux
_require_odirect
_require_test
_require_xfs_io_command pwrite -N
# Remove reminiscence of previously run tests
testdir=$TEST_DIR/$seq
if [ -e $testdir ]; then
rm -Rf $testdir
fi
mkdir $testdir
# Btrfs is a COW filesystem, so a RWF_NOWAIT write will always fail with -EAGAIN
# when writing to a file range except if it's a NOCOW file and an extent for the
# range already exists or if it's a COW file and preallocated/unwritten extent
# exists in the target range. So to make sure that the last write succeeds on
# all filesystems, use a NOCOW file on btrfs.
if [ $FSTYP == "btrfs" ]; then
_require_chattr C
touch $testdir/f1
$CHATTR_PROG +C $testdir/f1
fi
# Create a file with pwrite nowait (will fail with EAGAIN)
$XFS_IO_PROG -f -d -c "pwrite -N -V 1 -b 1M 0 1M" $testdir/f1
# Write the file without nowait
$XFS_IO_PROG -f -d -c "pwrite -S 0xaa -W -w -V 1 -b 1M 0 8M" $testdir/f1 | _filter_xfs_io
time_taken=`$XFS_IO_PROG -d -c "pwrite -S 0xbb -N -V 1 -b 1M 2M 1M" $testdir/f1 | awk '/^1/ {print $5}'`
# RWF_NOWAIT should finish within a short period of time so we are choosing
# a conservative value of 50 ms. Anything longer means it is waiting
# for something in the kernel which would be a fail.
if (( $(echo "$time_taken < 0.05" | bc -l) )); then
echo "RWF_NOWAIT time is within limits."
else
echo "RWF_NOWAIT took $time_taken seconds"
fi
$XFS_IO_PROG -c "pread -v 0 8M" $testdir/f1 | _filter_xfs_io_unique
# success, all done
status=0
exit