Files
apfstests/tests/xfs/439
T
Eryu Guan 69eb6281a9 fstests: _fail test by default when _scratch_mount fails
Previously _scratch_mount didn't check the mount status and most
tests continue to run even if the mount failed (unless test checks
for the mount status explicitly). This would result in running tests
on the underlying filesystem (usually rootfs) and implicit test
failures, and such failures can be annoying and are usually hard to
debug.

Now _fail test by default if _scratch_mount failed and introduce
_try_scratch_mount for tests that need to check mount results
themselves.

Suggested-by: Andreas Gruenbacher <agruenba@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Andreas Gruenbacher <agruenba@redhat.com>
Signed-off-by: Eryu Guan <eguan@redhat.com>
2018-02-22 14:02:44 +08:00

86 lines
2.5 KiB
Bash
Executable File

#! /bin/bash
# FS QA Test No. 439
#
# Regression test for commit:
# 9c92ee2 ("xfs: validate sb_logsunit is a multiple of the fs blocksize")
#
# If log stripe unit isn't a multiple of the fs blocksize and mounting,
# the invalid sb_logsunit leads to crash as soon as we try to write to
# the log.
#
#-----------------------------------------------------------------------
# Copyright (c) 2018 FUJITSU. All Rights Reserved.
# Author: Xiao Yang <yangx.jy@cn.fujitsu.com>
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License as
# published by the Free Software Foundation.
#
# This program is distributed in the hope that it would be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write the Free Software Foundation,
# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
#-----------------------------------------------------------------------
seq=`basename "$0"`
seqres="$RESULT_DIR/$seq"
echo "QA output created by $seq"
here=`pwd`
tmp=/tmp/$$
status=1 # failure is the default!
trap "_cleanup; exit \$status" 0 1 2 3 15
_cleanup()
{
rm -rf $tmp.*
}
# get standard environment, filters and checks
. ./common/rc
. ./common/filter
# real QA test starts here
_supported_os Linux
_supported_fs xfs
_require_scratch
# We corrupt XFS on purpose, and check if assert failures would crash system.
_require_no_xfs_bug_on_assert
rm -f "$seqres.full"
# Format
_scratch_mkfs > $seqres.full 2>&1 || _fail "mkfs failed"
# Set logsunit to a value which is not a multiple of the fs blocksize
blksz=$(_scratch_xfs_get_sb_field blocksize)
_scratch_xfs_set_sb_field logsunit $((blksz - 1)) >> $seqres.full 2>&1
# Check if logsunit is set correctly
lsunit=$(_scratch_xfs_get_sb_field logsunit)
[ $lsunit -ne $((blksz - 1)) ] && _notrun "failed to set sb_logsunit"
# Mount and writing log may trigger a crash on buggy kernel
# The fix applied kernel refuses to mount, so a mount failure is
# expected
if _try_scratch_mount >> $seqres.full 2>&1; then
for i in $(seq 1 1000); do
echo > ${SCRATCH_MNT}/$i
done
_scratch_unmount
fi
# We may trigger assert related WARNINGs if we corrupt log on a CONFIG_XFS_WARN
# or CONFIG_XFS_DEBUG (when bug_on_assert is disabled) build, so filter them.
_check_dmesg _filter_assert_dmesg
echo "Silence is golden"
# success, all done
status=0
exit