mirror of
https://github.com/linux-apfs/apfstests.git
synced 2026-05-01 15:01:44 -07:00
Eric Sandeen
8322038f2b
xfsrestore isn't properly restoring file capabilities; it restores them, but then chowns the file, which removes the caps: Call Trace: [<ffffffffa028de68>] xfs_xattr_set+0x118/0x120 [xfs] [<ffffffff8119a8c0>] generic_removexattr+0x80/0x90 [<ffffffff8120b408>] cap_inode_killpriv+0x28/0x30 [<ffffffff8120c666>] security_inode_killpriv+0x16/0x20 [<ffffffff81192edf>] notify_change+0x18f/0x330 [<ffffffff81176b70>] chown_common+0x60/0xa0 [<ffffffff81176c30>] sys_fchown+0x80/0xd0 [<ffffffff81537c59>] system_call_fastpath+0x16/0x1b This test demonstrates the problem. Reported-by: fugazzi® <fugazzi99@gmail.com> Signed-off-by: Eric Sandeen <sandeen@redhat.com> Reviewed-by: Ben Myers <bpm@sgi.com> Signed-off-by: Ben Myers <bpm@sgi.com>
56 lines
2.0 KiB
Plaintext
56 lines
2.0 KiB
Plaintext
QA output created by 296
|
|
Checking for xattr on source file
|
|
# file: DUMP_DIR/testfile
|
|
user.name
|
|
|
|
Checking for capability on source file
|
|
DUMP_DIR/testfile = cap_setgid,cap_setuid+ep
|
|
# file: DUMP_DIR/testfile
|
|
security.capability
|
|
|
|
Dumping to file...
|
|
xfsdump -f DUMP_FILE -M stress_tape_media -L stress_296 SCRATCH_MNT
|
|
xfsdump: using file dump (drive_simple) strategy
|
|
xfsdump: level 0 dump of HOSTNAME:SCRATCH_MNT
|
|
xfsdump: dump date: DATE
|
|
xfsdump: session id: ID
|
|
xfsdump: session label: "stress_296"
|
|
xfsdump: ino map <PHASES>
|
|
xfsdump: ino map construction complete
|
|
xfsdump: estimated dump size: NUM bytes
|
|
xfsdump: /var/xfsdump/inventory created
|
|
xfsdump: creating dump session media file 0 (media 0, file 0)
|
|
xfsdump: dumping ino map
|
|
xfsdump: dumping directories
|
|
xfsdump: dumping non-directory files
|
|
xfsdump: ending media file
|
|
xfsdump: media file size NUM bytes
|
|
xfsdump: dump size (non-dir files) : NUM bytes
|
|
xfsdump: dump complete: SECS seconds elapsed
|
|
xfsdump: Dump Status: SUCCESS
|
|
Restoring from file...
|
|
xfsrestore -f DUMP_FILE -L stress_296 RESTORE_DIR
|
|
xfsrestore: using file dump (drive_simple) strategy
|
|
xfsrestore: using online session inventory
|
|
xfsrestore: searching media for directory dump
|
|
xfsrestore: examining media file 0
|
|
xfsrestore: reading directories
|
|
xfsrestore: 2 directories and 2 entries processed
|
|
xfsrestore: directory post-processing
|
|
xfsrestore: restoring non-directory files
|
|
xfsrestore: restore complete: SECS seconds elapsed
|
|
xfsrestore: Restore Status: SUCCESS
|
|
Comparing listing of dump directory with restore directory
|
|
Files TMP.dump_dir and TMP.restore_dir are identical
|
|
Comparing dump directory with restore directory
|
|
Files DUMP_DIR/testfile and RESTORE_DIR/DUMP_SUBDIR/testfile are identical
|
|
Only in SCRATCH_MNT: RESTORE_SUBDIR
|
|
Checking for xattr on restored file
|
|
# file: RESTORE_DIR/DUMP_SUBDIR/testfile
|
|
user.name
|
|
|
|
Checking for capability on restored file
|
|
RESTORE_DIR/DUMP_SUBDIR/testfile cap_setgid,cap_setuid+ep
|
|
# file: RESTORE_DIR/DUMP_SUBDIR/testfile
|
|
security.capability
|