Ross Zwisler d79448aefe build: fix Wlog_Error_String overflow issues ...

The 'Wlog_Error_String' string is defined to be 256 bytes in length,
but in two places we write into it with a format that contains a
string (wfile->w_file) that has length 1024.  This can overflow
Wlog_Error_String, as we see in the new compiler warnings from gcc
7.2.1:

 write_log.c:124:37: warning: ‘%s’ directive writing up to 1023 bytes into
 a region of size 224 [-Wformat-overflow=]
 "Could not open write_log - open(%s, %#o, %#o) failed:  %s\n",
  ^~

Fix this by increasing the length of Wlog_Error_String to 1280
characters (1024 for wfile->w_file plus 256 for the rest of the
format string), and by using snprintf() instead of sprintf() so we
are sure we don't overflow.

Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
Reviewed-by: Eryu Guan <eguan@redhat.com>
Signed-off-by: Eryu Guan <eguan@redhat.com>

2017-12-10 17:46:05 +08:00

..

dataascii.c

Update copyright annotations and license boilerplates to correspond with SGI Legals preferences.

2005-11-09 02:50:19 +00:00

databin.c

Update copyright annotations and license boilerplates to correspond with SGI Legals preferences.

2005-11-09 02:50:19 +00:00

datapid.c

xfstests: remove unsupported conditionals

2012-11-21 08:43:45 -06:00

file_lock.c

Update copyright annotations and license boilerplates to correspond with SGI Legals preferences.

2005-11-09 02:50:19 +00:00

forker.c

Update copyright annotations and license boilerplates to correspond with SGI Legals preferences.

2005-11-09 02:50:19 +00:00

Makefile

xfstests: some refinements on "make depend"

2011-03-11 06:45:19 -06:00

open_flags.c

Update copyright annotations and license boilerplates to correspond with SGI Legals preferences.

2005-11-09 02:50:19 +00:00

pattern.c

Update copyright annotations and license boilerplates to correspond with SGI Legals preferences.

2005-11-09 02:50:19 +00:00

random_range.c

xfstests: remove unsupported conditionals

2012-11-21 08:43:45 -06:00

random.c

xfstests updates - rework build to be like other xfs packages, revive some old fs test tools and reenable xfs extensions, move ltp code into a separate subdir to help keeping in sync with real ltp project (hopefully)

2003-07-07 06:36:46 +00:00

str_to_bytes.c

tests: remove IRIX support from tests also supported on Linux

2017-07-24 12:34:41 +08:00

string_to_tokens.c

Update copyright annotations and license boilerplates to correspond with SGI Legals preferences.

2005-11-09 02:50:19 +00:00

tlibio.c

lib/tlibio: Fix a build warning

2016-04-05 11:41:40 +10:00

write_log.c

build: fix Wlog_Error_String overflow issues

2017-12-10 17:46:05 +08:00