mirror of
https://github.com/linux-apfs/apfstests.git
synced 2026-05-01 15:01:44 -07:00
Lukas Czerner
00d1bda60d
This tests corner case in FITRIM implementation where range size is smaller than file system block or zero. In this case FITRIM should fail with EINVAL. The problem was spotted in xfs and ext4 where in case of length = 0 the 'end' variable underflowed. In case of length smaller than 1 FSB FITRIM finished successfully, but we really should rather return EINVAL in both cases. (This patch has to be applied after 'Use upstream version of fstrim instead of the local one') Signed-off-by: Lukas Czerner <lczerner@redhat.com> Reviewed-by: Dave Chinner <dchinner@redhat.com> Signed-off-by: Rich Johnston <rjohnston@sgi.com>
59 lines
1.7 KiB
Bash
59 lines
1.7 KiB
Bash
#!/bin/bash
|
|
# FS QA Test No. 288
|
|
#
|
|
# This check the FITRIM argument handling in the corner case where length is
|
|
# smaller than block size of zero.
|
|
#
|
|
#-----------------------------------------------------------------------
|
|
# Copyright 2012 (C) Red Hat, Inc., Lukas Czerner <lczerner@redhat.com>
|
|
#
|
|
# This program is free software; you can redistribute it and/or
|
|
# modify it under the terms of the GNU General Public License as
|
|
# published by the Free Software Foundation.
|
|
#
|
|
# This program is distributed in the hope that it would be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program; if not, write the Free Software Foundation,
|
|
# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
|
|
#-----------------------------------------------------------------------
|
|
|
|
owner=lczerner@redhat.com
|
|
|
|
seq=`basename $0`
|
|
echo "QA output created by $seq"
|
|
|
|
status=0
|
|
trap "exit \$status" 0 1 2 3 15
|
|
|
|
# get standard environment, filters and checks
|
|
. ./common.rc
|
|
. ./common.filter
|
|
|
|
# real QA test starts here
|
|
_supported_fs generic
|
|
_supported_os Linux
|
|
|
|
_require_fstrim
|
|
_require_scratch
|
|
|
|
_scratch_mkfs >/dev/null 2>&1
|
|
_scratch_mount
|
|
_test_batched_discard $SCRATCH_MNT || _notrun "FITRIM not supported on $SCRATCH_DEV"
|
|
|
|
echo "[+] Length is zero (should fail)"
|
|
out=$("$FSTRIM_PROG" -v -o0 -l0 $SCRATCH_MNT 2>&1)
|
|
[ $? -eq 0 ] && status=1
|
|
echo $out | _filter_scratch
|
|
|
|
echo "[+] Length is smaller than block size (should fail)"
|
|
out=$("$FSTRIM_PROG" -v -o0 -l100 $SCRATCH_MNT 2>&1)
|
|
[ $? -eq 0 ] && status=1
|
|
echo $out | _filter_scratch
|
|
|
|
echo "Test done"
|
|
exit
|