Files
apfstests/tests/xfs/186
T
Eryu Guan a173f8e66d xfs/186: run test on expected XFS configuration
Usually xfs/186 _notrun on crc enabled XFS because of
_require_attr_v1, since v2 attr format is always enabled on v5 XFS.

But when testing on 512B block size XFS, i.e. MKFS_OPTIONS="-m crc=0
-b size=512", test fails. This is because crc enabled XFS was
created in the end, not 512B block size XFS with crc disabled, and
that's not what we want to test.

The reason why _scratch_mkfs_xfs creates a different XFS than
expected is that, it may ignore $MKFS_OPTIONS if mkfs fails due to
conflicts between $MKFS_OPTIONS and the provided mkfs options.

In the case of xfs/186, "-b size=512" conflicts with "-i size=512",
and the first mkfs fails, then it ends up with a 4k block size XFS
with crc enabled (the default config).

Fix it by checking crc enablement status and attr version in the
test, to make sure it's testing on expected XFS.

Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Eryu Guan <eguan@redhat.com>
2016-06-22 10:28:18 +08:00

203 lines
4.7 KiB
Bash
Executable File

#! /bin/bash
# FS QA Test No. 186
#
# Test out:
# pv#979606: xfs bug in going from attr2 back to attr1
#
# Test bug in going from attr2 back to attr1 where xfs
# (due to xfs_attr_shortform_bytesfit)
# would reset the di_forkoff to the m_offset instead of
# leaving the di_forkoff alone as was intended.
#
# We create enough dirents to push us past m_attroffset,
# and create an EA so we have a fork offset
# and then turn on attr1 and add one more EA which
# will write over the shortform dirents.
#
#-----------------------------------------------------------------------
# Copyright (c) 2008 Silicon Graphics, Inc. All Rights Reserved.
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License as
# published by the Free Software Foundation.
#
# This program is distributed in the hope that it would be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write the Free Software Foundation,
# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
#
#-----------------------------------------------------------------------
#
seq=`basename $0`
seqres=$RESULT_DIR/$seq
echo "QA output created by $seq"
here=`pwd`
tmp=/tmp/$$
status=1 # failure is the default!
trap "_cleanup; exit \$status" 0 1 2 3 15
_cleanup()
{
cd /
rm -f $tmp.*
}
_create_dirents()
{
start_num=$1
end_num=$2
cd $fork_dir
for i in `seq $start_num $end_num`; do
touch file.$i
done
}
_create_eas()
{
start_num=$1
end_num=$2
for i in `seq $start_num $end_num`; do
$SETFATTR_PROG -n user.$i -v 0xbabe $fork_dir
done
}
_rmv_eas()
{
start_num=$1
end_num=$2
for i in `seq $start_num $end_num`; do
$SETFATTR_PROG -x user.$i $fork_dir
done
}
# If filetype is available (-n ftype=1) will get v3 dirs;
# just filter/replace to make this look the same as if we
# had v2 dirs, as we are not interested in this info.
_filter_inode()
{
tee -a $seqres.full | \
sed -e "s/core.forkoff/forkoff/g" | \
egrep '^u.sfdir2|^u.sfdir3|^a.sfattr|forkoff' | \
egrep -v 'inumber|parent' | \
sed -e s/sfdir3/sfdir2/g | \
grep -v filetype
}
_filter_version()
{
tee -a $seqres.full | tr ',' '\n' | grep ATTR
}
_print_inode()
{
echo ""
echo "================================="
$XFS_DB_PROG -c "version" $SCRATCH_DEV 2>&1 | _filter_version
$XFS_DB_PROG -c "inode $inum" -c p $SCRATCH_DEV 2>&1 | _filter_inode
echo "================================="
}
_do_eas()
{
echo ""
_scratch_mount
if [ $1 = "-r" ]; then
echo "*** remove EAs start $2 end $3 ***"
_rmv_eas $2 $3
else
echo "*** create EAs start $2 end $3 ***"
_create_eas $2 $3
fi
echo ""
cd /; $UMOUNT_PROG $SCRATCH_MNT
_print_inode
}
_do_dirents()
{
num=`expr $2 - $1 + 1`
echo ""
echo "*** create $num dirents ***"
echo ""
_scratch_mount
_create_dirents $1 $2
cd /; $UMOUNT_PROG $SCRATCH_MNT
_print_inode
}
_changeto_attr1()
{
echo ""
echo "Try setting attr1 by db"
echo ""
$XFS_DB_PROG -x -c "version attr1" $SCRATCH_DEV | _filter_version
}
# get standard environment, filters and checks
. ./common/rc
. ./common/filter
. ./common/attr
# real QA test starts here
# Modify as appropriate.
_supported_fs xfs
_supported_os Linux
_require_scratch
_require_attrs
_require_attr_v1
rm -f $seqres.full
_scratch_mkfs -i attr=2,size=512 -l lazy-count=1 | _filter_mkfs \
>>$seqres.full 2>$tmp.mkfs
# import crc status and attr version
. $tmp.mkfs
# _scratch_mkfs may ignore $MKFS_OPTIONS if mkfs fails due to conflicts between
# $MKFS_OPTIONS and the provided mkfs options, which could result in creating
# an XFS we don't want. Check crc status and attr version to be sure.
if [ $_fs_has_crcs -eq 1 ]; then
_notrun "attr v1 not supported on $SCRATCH_DEV"
fi
if [ $attr -ne 2 ]; then
_notrun "need attr v2 on $SCRATCH_DEV"
fi
# set inum to root dir ino
# we'll add in dirents and EAs into the root directory
eval `$XFS_DB_PROG -r -c 'sb 0' -c 'p rootino' $SCRATCH_DEV | $SED_PROG 's/ //g'`
inum=$rootino
fork_dir=$SCRATCH_MNT
_print_inode
# add enough dirents to be inline but more
# than will fit for m_attroffset for 512b inodes
# for attr2 this is not a problem
_do_dirents 1 25
# add 1 ea so we get our forkoff happening
_do_eas -c 1 1
# now change back to attr1 where forkoff is constant now
_changeto_attr1
# now add another EA
# for a bug in xfs_add_shortform_bytesfit
# where it resets the forkoff to m_attroffset>>3 instead of
# leaving as di_forkoff
# If it resets to m_attroffset which is in the middle of
# the dirents then they will get corrupted
_do_eas -c 2 2
# success, all done
status=0
exit