mirror of
https://github.com/linux-apfs/apfstests.git
synced 2026-05-01 15:01:44 -07:00
Amir Goldstein
3408108774
seek_sanity_test checks for one of several SEEK_DATA/HOLE behaviors and allows for the default behavior of filesystems, where SEEK_HOLE always returns EOF. This means that if filesystem has a regression in finding holes, the sanity test won't catch it. And indeed this regression happened in overlayfs on kernel v4.19 and went unnoticed. To improve test coverage, add a flag -f to seek_sanity_test to indicate that the default behavior is not acceptable. Whitelist all filesystem types that are expected to detect holes and use wrapper when invoking seek_sanity_test to add the -f flag to those filesystems. Overlayfs inherits expected behavior from base fs type. Signed-off-by: Amir Goldstein <amir73il@gmail.com> Acked-by: Darrick J. Wong <darrick.wong@oracle.com> Signed-off-by: Eryu Guan <guaneryu@gmail.com>
48 lines
1.0 KiB
Bash
Executable File
48 lines
1.0 KiB
Bash
Executable File
#! /bin/bash
|
|
# SPDX-License-Identifier: GPL-2.0
|
|
# Copyright (c) 2018 SUSE. All Rights Reserved.
|
|
#
|
|
# FS QA Test No. 490
|
|
#
|
|
# Check that SEEK_DATA works properly for offsets in the middle of large holes.
|
|
# This was broken for ext4 with indirect-block based files and this test checks
|
|
# for that. The problem has been fixed by commit 2ee3ee06a8fd79 "ext4: fix hole
|
|
# length detection in ext4_ind_map_blocks()"
|
|
#
|
|
seq=`basename $0`
|
|
seqres=$RESULT_DIR/$seq
|
|
echo "QA output created by $seq"
|
|
|
|
here=`pwd`
|
|
tmp=/tmp/$$
|
|
status=1 # failure is the default!
|
|
trap "_cleanup; exit \$status" 0 1 2 3 15
|
|
|
|
# get standard environment, filters and checks
|
|
. ./common/rc
|
|
. ./common/filter
|
|
|
|
_supported_fs generic
|
|
_supported_os Linux
|
|
|
|
_require_test
|
|
_require_seek_data_hole
|
|
|
|
base_test_file=$TEST_DIR/seek_sanity_testfile.$seq
|
|
|
|
_require_test_program "seek_sanity_test"
|
|
|
|
_cleanup()
|
|
{
|
|
cd /
|
|
rm -f $tmp.*
|
|
rm -f $base_test_file*
|
|
}
|
|
|
|
_run_seek_sanity_test -s 19 -e 20 $base_test_file > $seqres.full 2>&1 ||
|
|
_fail "seek sanity check failed!"
|
|
|
|
# success, all done
|
|
status=0
|
|
exit
|