mirror of
https://github.com/linux-apfs/apfstests.git
synced 2026-05-01 15:01:44 -07:00
Andreas Gruenbacher
bd1af95e55
The runas helper runs a command as another user and/or with different group memberships. Fix the following problems: * Use setgid instead of setegid and setuid instead of seteuid. Otherwise, the command will run with the original real UID and/or GID; those could be made the effective IDs again. * When only a GID is specified, remove all supplementary GIDs. Otherwise, the command would remain in the same supplementary groups as runas -- which often is the root group. * Use execvp instead of execv which searches the PATH when necessary. The runas helper is always called either with a '/' in the pathname or as "runas ... `which program`", so we obviously want PATH lookup, anyway. * There is no advantage in fork'ing and waiting for the child over directly exec'ing the command; the test cases already have to deal with commands which can be killed by signals. Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com> Reviewed-by: Dave Chinner <dchinner@redhat.com> Signed-off-by: Dave Chinner <david@fromorbit.com>
78 lines
1.9 KiB
Bash
Executable File
78 lines
1.9 KiB
Bash
Executable File
#! /bin/bash
|
|
# FS QA Test No. 237
|
|
#
|
|
# Check user B can setfacl a file which belongs to user A
|
|
# See also http://marc.info/?l=linux-btrfs&m=127434445620298&w=2
|
|
#
|
|
#-----------------------------------------------------------------------
|
|
# Copyright (c) 2010 FUJITSU LIMITED. All Rights Reserved.
|
|
#
|
|
# This program is free software; you can redistribute it and/or
|
|
# modify it under the terms of the GNU General Public License as
|
|
# published by the Free Software Foundation.
|
|
#
|
|
# This program is distributed in the hope that it would be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program; if not, write the Free Software Foundation,
|
|
# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
|
|
#
|
|
#-----------------------------------------------------------------------
|
|
#
|
|
|
|
seq=`basename $0`
|
|
seqres=$RESULT_DIR/$seq
|
|
echo "QA output created by $seq"
|
|
|
|
here=`pwd`
|
|
tmp=/tmp/$$
|
|
runas=$here/src/runas
|
|
status=1 # FAILure is the default!
|
|
trap "_cleanup; exit \$status" 0 1 2 3 15
|
|
|
|
# get standard environment, filters and checks
|
|
. ./common/rc
|
|
. ./common/filter
|
|
. ./common/attr
|
|
|
|
_cleanup()
|
|
{
|
|
cd /
|
|
rm -f $tmp.*
|
|
[ -n "$TEST_DIR" ] && rm -rf $TEST_DIR/$seq.dir1
|
|
}
|
|
|
|
# real QA test starts here
|
|
_supported_fs generic
|
|
# only Linux supports fallocate
|
|
_supported_os Linux
|
|
_require_test
|
|
|
|
[ -x $runas ] || _notrun "$runas executable not found"
|
|
|
|
rm -f $seqres.full
|
|
|
|
_need_to_be_root
|
|
_acl_setup_ids
|
|
_require_acls
|
|
|
|
# get dir
|
|
cd $TEST_DIR
|
|
rm -rf $seq.dir1
|
|
mkdir $seq.dir1
|
|
cd $seq.dir1
|
|
|
|
touch file1
|
|
chown $acl1.$acl1 file1
|
|
|
|
echo "Expect to FAIL"
|
|
$runas -u $acl2 -g $acl2 -- setfacl -m u::rwx file1 2>&1 | sed 's/^setfacl: \/.*file1: Operation not permitted$/setfacl: file1: Operation not permitted/'
|
|
|
|
echo "Test over."
|
|
# success, all done
|
|
status=0
|
|
exit
|